From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752801AbbIBCaq (ORCPT ); Tue, 1 Sep 2015 22:30:46 -0400 Received: from mail-bl2on0140.outbound.protection.outlook.com ([65.55.169.140]:3200 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751682AbbIBCap (ORCPT ); Tue, 1 Sep 2015 22:30:45 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=freescale.com; Message-ID: <1441161032.4966.123.camel@freescale.com> Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage muram From: Scott Wood To: Zhao Qiang-B45475 CC: "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "lauraa@codeaurora.org" , Xie Xiaobo-R63061 , "benh@kernel.crashing.org" , Li Yang-Leo-R58472 , "paulus@samba.org" Date: Tue, 1 Sep 2015 21:30:32 -0500 In-Reply-To: References: <1441011520-15424-1-git-send-email-qiang.zhao@freescale.com> <1441011520-15424-2-git-send-email-qiang.zhao@freescale.com> <1441154062.4966.113.camel@freescale.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.0-fta1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [2601:448:8100:f9f:12bf:48ff:fe84:c9a0] X-ClientProxiedBy: BLUPR16CA0039.namprd16.prod.outlook.com (25.164.14.49) To BY1PR03MB1482.namprd03.prod.outlook.com (25.162.210.140) X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1482;2:7y9NSh6gOQ1LaUB9i3/QRkLignGIiU7w44Y7oc/pdCwEsVP5g5frsV98Xx1AnMv/cmZS+oWmHC9OHoqpvX+wI0gMf6cXRFx649od9cWofrCZw/FyrLkAFU9YP8vyhhCGud7o7kOLNbJBXjr51/tdamK9Upt/mbrkzO93D7pJteE=;3:iknsc8qv2AH9dTTHj0gFSCoJ2njtd6q6gbWRnfSg3EJ2FKkvoMQfoekHxnfFnsCG2IWtr1e4b1nId9DZwJhpcF1pRaUs5rAj1m4jhhr1Wad60wgDQ9IFeYy6z5GH411ZSv14fMTwi1BSc+C9P+Zf2g==;25:zDwN5uVeQVhYmb/qoRw+Yp9f70sxbNo8ayOACAHb4ZpP+aQWnCe/agdKZm+bUG0vPJPqBr5fpwvdIWzAl2LaoIkTczsUP6UWyKfVzO76o1m3/QFQJ4yd5S7rjJcYPnfib4k/eWUOJqN82YOSNHGZT6hSO0IHt6UB19jy9qFxlTcT3SlLIwD/c8j0iR5sw3bn7OT0Q1pdhFhGnCJV7sCFBtAekzdEmhslu5hFORs1HUY+zrs3zihmgOQ8xdX9u8rT1syqzo8qAfNqBqnEJwRuoA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1482;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1340; X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1482;20:bKI/lmcTD6TuPP20AxNLpn0T6VMr79xvsMAJwoXDuEZVgFjA/6hto9/wUGLX+xYAkMljJRtB75wjVniNv1M17EhDhY6GgTzMpuUVjcR1cjgFNdHg+UU0UpcStancJ9sSBZc7JyJKfkv9v4YOihpuEnRbxYEG6XpoXhBepwi321lPmcmqSTHlxw9SgXaoT6dKDdkfY6rwxfY3QdQh7FavBgIPeg/xAwmX6DGHI1F3rUGBfiFM49ROtLfoOjegOkd/vzeW1tvG0b52UbhA25+n4dhO5LZnD+D2EuEwAzOGFQqltxuycJJwpJirLBoRpD/P8BDwVDMGQ+KsUm1PVgMtzaxmu8ZCRzVxkBa1hbeQKEVEnoIvDuXYiTLcn4dKEzWuG3K+kdRqT20AQ9Pj8PMgpoYN2r8PP49P0n0vWIlHg0gGmVvC+cUV2DLm9qD5ovaDpxPfYhkBmyBMS8hJgjWynZbndQ+0Nuc7H3aJq45hRjhykOCEZSlZKQ6tpv70VHxJ;4:dXCpmHZRLPKkoj5DThASNXyjaGPlUx69qRPNdWDIWgXw/KbLcJA4E+3KGTFKrvm9y6OKXw3ZS9RAgXxbIz5QbKM1w+v255kwNaPYgD6ulwSFKCBfxYEu4OKfeFaJPno7ZE8j7XvCxitk947tZXVvggEpbB/Gqlo3/Dzb/0whZFCusCxGjxNzaLkf0XIKxPh6umHVWRzjbvFIZEWimXWbXXAIjjaf9A7rKbveWWQSV9Qb+ASvJzxDmb/pKcUk5oQExLy2rwjfVJ7tgyfpH9pQav/ovCbrVXHPmf2ZMVxgUsJOwt7sXkp3xo1BXk4R7u7h X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(8121501046)(3002001);SRVR:BY1PR03MB1482;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1482; X-Forefront-PRVS: 0687389FB0 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(13464003)(199003)(377454003)(24454002)(377424004)(189002)(122386002)(64706001)(40100003)(5007970100001)(103116003)(50986999)(110136002)(76176999)(36756003)(77156002)(5004730100002)(5001860100001)(86362001)(87976001)(5001960100002)(46102003)(4001450100002)(101416001)(5001830100001)(50466002)(106356001)(97736004)(68736005)(4001540100001)(92566002)(5820100001)(105586002)(93886004)(189998001)(19580395003)(62966003)(47776003)(42186005)(50226001)(19580405001)(2950100001)(81156007)(33646002)(23676002)(77096005)(99106002)(3826002)(5001840100002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR03MB1482;H:[IPv6:2601:448:8100:f9f:12bf:48ff:fe84:c9a0];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTFQUjAzTUIxNDgyOzIzOkh4aWFSL1p1SFFGd3l0WTJLNDR4VnE5ZHNM?= =?utf-8?B?MzdyTCtXQm9zVFU0UTdtR3lobmhmc1hodnJrNnk2M3E5VnFicmZjMDRQN3Va?= =?utf-8?B?djRJcVE0a1Yzc2xLSUVQRExMOGdURllnMEg4ZDZhUC9naUdMbGhKZ3UrazZl?= =?utf-8?B?T1JyWkprdmt5dFRSVVViWFA1MnNNQjFIckVzWCsxODdHMXllMndzQlczeHRX?= =?utf-8?B?bk5JWVpaRjNyYjJ2ZlJ3eWF3MitCczh1WlN4d3o1R1JrWFhLR0x5ZUxpR05W?= =?utf-8?B?VHB2WER2K2dFa3NZOGxjdUhDcnNhMGxDQU9SZEtobjVDWENDQ1VRZTFJNC9a?= =?utf-8?B?eHExMGRWK0VsSVl0TlRoeGh1RVNxcDVhSVI3RGRXdjQ3a1EzTGZyY3RyenZn?= =?utf-8?B?QmxGRGJlWFhHS0VOek1JY3M4cDJxM21ZMXc5SlN1N1BFZjNOK3BkTmdJcnhB?= =?utf-8?B?Y1BhMzdCTHZTQmpzMEtNU1AyaGtpWENWTUxPb1c3NkdIL3RhekFBZDQ2N3RS?= =?utf-8?B?a2R4TUdKVkEybnc1bEZxeW1Yc2MxLy9heUtIUkZPTDArZ0kyM1VVc052QS9O?= =?utf-8?B?UCtZVHQ1Q0RCUkVLWjdvQ09wK1J2WlJWSXh2NHhOendHWEJrN1ZFU2VKaDdM?= =?utf-8?B?bTdTMUNLTkwzU0M5RFAvSjRQb3JscDU0MThpR2oyZlB4OGJMYnhkRWJRbzRs?= =?utf-8?B?S20xelkyVGc2Q2ZBeThmWkVhVDgwQTBGNHplbXNlYVNLOUdUdnE0cTdnaVVY?= =?utf-8?B?azRRN1hUWmRwZjlDQWZ5SUQ3MDh6VTlXdHY4NXBoZEdYN3JqcDB5cEdDNjhm?= =?utf-8?B?NWE2SmFLV0gzaFpWS1VINWlCWDhDTHVFS1prVi9FZHB1SWFnRU5MejNXRDZ0?= =?utf-8?B?aC83ZnZwWVNiVXA5bnE2REdmZmpQRDV1cWM5QWx4T3VSZVdpMng2d0lrbm1o?= =?utf-8?B?SVFSNG9uaUlVeUxIVVFoWEx3eEtwYU42V2FsUW8rWVZNZjVMR1ZYVWhlRVho?= =?utf-8?B?dEpSVTV0K0pXVC9jT2JMZGgyR05ZM1JJOFJzR0MwM25VeUN1cGNSelhBS1Y1?= =?utf-8?B?VCtzNklFVjV4eUlvWURlZk04ZzByblJVUkRIcGtiSWhmbzZqSFkwUWZDMjJE?= =?utf-8?B?RXZWRFJIcjg5aGp6YzB4VEZobzBtUWR4cGh2OEtpcXBFWVpXdnE0UXJhaGJk?= =?utf-8?B?b2Z5UHQ2M3BjbCsvOUFJK2FBazNmb0lOV3UzaDBqYWVOWFBtMHNBUDUyZlhI?= =?utf-8?B?VEwyeVRmbzVJRms0NjF6UXBNMWtXNlkxc3Y4YUpzNjZ5eGNBQjVtbDRta3F5?= =?utf-8?B?RUMyQjM2UWVKblMvZnpENnVhd015RHRadEdPR21MblBVTHVoS1ZCeHBHK0ZL?= =?utf-8?B?T0lHamM4bUw5Y0tMQmFrVkJndmpEb2FzMFowVC9CMHJnVmpxSUhFUkV5ekNS?= =?utf-8?B?MjFSMHlFQTJJbHVqRFZwV1QxUHgzaStDL0FLSlQvZURwQlVBalhSQzRSd1Vn?= =?utf-8?B?cGh2YkxLcjlDNHlUMTZPN0NJbzIvYWFnTlFqM211cXpGclhVNlRwVlJ1b2ZO?= =?utf-8?B?NXliL0FMN0V5TUdRVEU1QkJtakQwTUpGdGJoN3NtZGozWHplR3E2Nnc2Q0tR?= =?utf-8?B?MzgxdytKY0VXdnRqNjJ1akdNNmZ5NjFBNWN2TEpzVmxXQmpVZzQwOW9FWGcv?= =?utf-8?B?RjkvR0FzREdOeVk0UmNNM0V2dk5DT1MzT3pjWDdSK3VRUnNvVzRoNE95bU42?= =?utf-8?B?SEhEckZUazJyWWxwOVRZRWNSdjhUUkVCdVN6OXc5d3EzSHV6UlZtVzE0Q1Nq?= =?utf-8?Q?jf9TdCNMa+7jG?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1482;5:t5wwWmnFDaIIwuTSjRm3X9sFbznSyJ0U0Mfp/Jr9JBa7rTcFjR16pKCEw8N+Qtq5UvnuBZHjr2+OSdHYHBRbrNlpd6PiRB3jEkQEAveFM1gCJLGAPrdhPOZ3ULcn7ESaJSR5g63yiHVjm4svev7FaA==;24:wEFeZbSqoq4OLFDJHL2TdXsE2MuUiPSBsm0Tw38KD9CxTTK7p6CDmq4YEAk8gaOb6QJW9V5ayHQmYeDc0bbIvgjD1jj/fc9IQ4Y/p6HJoDM=;20:06NzOTh/mZNMhmUmEvwrqtoALNEs7dXNknj3OdSUZ/V3rr1uUdXyGZD5DZZZ6vXqf5+gD0CB0/EQyc+1BtaBFQ== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2015 02:30:40.2706 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1482 X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1340;2:0V1kXvccHSlIl5526+b4Qfn/FAtM+cKsmVzCduT4x5KxsnS9XX3LUUEY6464oWw2OKCF5wjW+1okf0Qu7IJLAingU7OtZZDgZCfTjCUrrXtku2VIO54dRR+sbnVNnlvuJnmgEB0HjG0kTXBZ3G/y/FJtSgv0rr0hv4gcgJTYL0E=;3:qPOfOHHyOciKt3e1jg6spfzkvTX2fD+naff5hu1ronHpsuHTyt9nRhGlz9xxyqeyAA8GwHWSCJgcYKcsdp41bpVsj5W0gX9lIsUtF+94EFbTgKCwEViaJoMBEPaC1HVu37uDwR2sz0b8BvXaJ042QQ==;25:wzem1pLRhUhtaxLyYV+m5m8pW9Klgasc1p2NU29lrhvYf0LZ876b7VH203cmr7Z6sE8y2+oSGPpgGOZBsEHozrEGdptpY5ismDU1e9OniGyzDiuVsG8gMlLNvDJT/SlFUPD0pysxzlFILg3EMPN4xlIDVKV4q3Ain2eHLGHJIw2Ppia7854SET7krvyruHL157S+PUHFpg21+e1kWdiATKoE/ptsuVHyfntwhCmCz7d0sP2EMdcYXM4re7YCjBfuxGMtzRvUSHFNQAVyC1wXXg==;23:g9CIVCAHzK3+ZNtZF4SKxqLSrz58NVYNNxV66FdQKwLlOJ/dZiIBPWaXrJOGzGdoz3tz6fcFjCkOqZqXu/M2pJszi8p16xuVJJII/wZA0NtWv9CkkpZj0RElinX6EWa4u13HCxR2P6HHf5y03kMxCyvSJa2Ogjxd6RisTgVR9jN2ZqVDP/2icSLcUs6O5ZAK X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-09-01 at 21:22 -0500, Zhao Qiang-B45475 wrote: > On Wed, 2015-09-02 at 8:34AM +0800, Wood Scott-B07421 wrote: > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Wednesday, September 02, 2015 8:34 AM > > To: Zhao Qiang-B45475 > > Cc: linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > lauraa@codeaurora.org; Xie Xiaobo-R63061; benh@kernel.crashing.org; Li > > Yang-Leo-R58472; paulus@samba.org > > Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage > > muram > > > > On Mon, 2015-08-31 at 16:58 +0800, Zhao Qiang wrote: > > > > > -int cpm_muram_init(void) > > > -{ > > > - struct device_node *np; > > > - struct resource r; > > > - u32 zero[OF_MAX_ADDR_CELLS] = {}; > > > - resource_size_t max = 0; > > > - int i = 0; > > > - int ret = 0; > > > - > > > - if (muram_pbase) > > > - return 0; > > > - > > > - spin_lock_init(&cpm_muram_lock); > > > - /* initialize the info header */ > > > - rh_init(&cpm_muram_info, 1, > > > - sizeof(cpm_boot_muram_rh_block) / > > > - sizeof(cpm_boot_muram_rh_block[0]), > > > - cpm_boot_muram_rh_block); > > > - > > > - np = of_find_compatible_node(NULL, NULL, "fsl,cpm-muram-data"); > > > - if (!np) { > > > - /* try legacy bindings */ > > > - np = of_find_node_by_name(NULL, "data-only"); > > > - if (!np) { > > > - printk(KERN_ERR "Cannot find CPM muram data > > node"); > > > - ret = -ENODEV; > > > - goto out; > > > - } > > > - } > > > - > > > - muram_pbase = of_translate_address(np, zero); > > > - if (muram_pbase == (phys_addr_t)OF_BAD_ADDR) { > > > - printk(KERN_ERR "Cannot translate zero through CPM muram > > node"); > > > - ret = -ENODEV; > > > - goto out; > > > - } > > > > Did you pass -M -C to git format-patch? > > > Yes! Then maybe it's the qe/cpm rename churn, or similar, that prevented it from being identified as a move? -Scott