From: Lucas Stach <l.stach@pengutronix.de>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] cpufreq: dt: Tolerance applies on both sides of target voltage
Date: Wed, 02 Sep 2015 11:39:45 +0200 [thread overview]
Message-ID: <1441186785.3137.2.camel@pengutronix.de> (raw)
In-Reply-To: <4166ff63e1992adefd757cd3774e841e137024f9.1441184706.git.viresh.kumar@linaro.org>
Am Mittwoch, den 02.09.2015, 14:36 +0530 schrieb Viresh Kumar:
> Tolerance applies on both sides of the target voltage, i.e. both min and
> max sides.
While I'm not really comfortable with the above, it is exactly how OPPv1
and the voltage tolerance property are specified.
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> But while checking if a voltage is supported by the regulator
> or not, we haven't taken care of tolerance on the lower side. Fix that.
>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Fixes: 045ee45c4ff2 ("cpufreq: cpufreq-dt: disable unsupported OPPs")
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> drivers/cpufreq/cpufreq-dt.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c
> index b1131cf89757..3b64c203bf99 100644
> --- a/drivers/cpufreq/cpufreq-dt.c
> +++ b/drivers/cpufreq/cpufreq-dt.c
> @@ -303,7 +303,8 @@ static int cpufreq_init(struct cpufreq_policy *policy)
> rcu_read_unlock();
>
> tol_uV = opp_uV * priv->voltage_tolerance / 100;
> - if (regulator_is_supported_voltage(cpu_reg, opp_uV,
> + if (regulator_is_supported_voltage(cpu_reg,
> + opp_uV - tol_uV,
> opp_uV + tol_uV)) {
> if (opp_uV < min_uV)
> min_uV = opp_uV;
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2015-09-02 9:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1441184706.git.viresh.kumar@linaro.org>
2015-09-02 9:06 ` [PATCH 1/3] cpufreq: dt: Check OPP count before marking them shared Viresh Kumar
2015-09-02 9:06 ` [PATCH 2/3] cpufreq: dt: Print error on failing to mark OPPs as shared Viresh Kumar
2015-09-02 9:06 ` [PATCH 3/3] cpufreq: dt: Tolerance applies on both sides of target voltage Viresh Kumar
2015-09-02 9:39 ` Lucas Stach [this message]
2015-09-02 9:44 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441186785.3137.2.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox