From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752761AbbICF6H (ORCPT ); Thu, 3 Sep 2015 01:58:07 -0400 Received: from smtprelay0056.hostedemail.com ([216.40.44.56]:42797 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750820AbbICF6F (ORCPT ); Thu, 3 Sep 2015 01:58:05 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:1801:2393:2559:2562:2828:3138:3139:3140:3141:3142:3354:3622:3865:3866:3867:3868:3872:3873:3874:4321:4423:4605:5007:6119:6261:6742:6743:7903:9036:10004:10400:10848:11026:11233:11473:11658:11914:12043:12438:12517:12519:12740:13161:13229:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: air80_7ff36c230fa63 X-Filterd-Recvd-Size: 4359 Message-ID: <1441259878.12163.75.camel@perches.com> Subject: Re: [PATCH v4 01/16] drm: exynos/dp: fix code style From: Joe Perches To: Yakir Yang Cc: Krzysztof Kozlowski , Heiko Stuebner , Thierry Reding , Jingoo Han , Inki Dae , Kukjin Kim , Mark Yao , Russell King , djkurtz@chromium.com, dianders@chromium.com, seanpaul@chromium.com, ajaynumb@gmail.com, Andrzej Hajda , Kyungmin Park , David Airlie , Gustavo Padovan , Andy Yan , Kumar Gala , Ian Campbell , Rob Herring , Pawel Moll , Kishon Vijay Abraham I , architt@codeaurora.org, robherring2@gmail.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Date: Wed, 02 Sep 2015 22:57:58 -0700 In-Reply-To: <55E7DBA7.90504@rock-chips.com> References: <1441086371-24838-1-git-send-email-ykk@rock-chips.com> <1441086399-24889-1-git-send-email-ykk@rock-chips.com> <55E79297.3050203@samsung.com> <55E7D4E4.6070808@rock-chips.com> <55E7D5EB.1060505@samsung.com> <55E7DBA7.90504@rock-chips.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-09-03 at 13:33 +0800, Yakir Yang wrote: [] > >>>> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c [] > >>>> @@ -155,24 +156,22 @@ static int exynos_dp_read_edid(struct > >>>> exynos_dp_device *dp) > >>>> } > >>>> exynos_dp_read_byte_from_dpcd(dp, DP_TEST_REQUEST, > >>>> - &test_vector); > >>>> + &test_vector); > >>>> if (test_vector & DP_TEST_LINK_EDID_READ) { > >>>> - exynos_dp_write_byte_to_dpcd(dp, > >>>> - DP_TEST_EDID_CHECKSUM, > >>>> + exynos_dp_write_byte_to_dpcd( > >>>> + dp, DP_TEST_EDID_CHECKSUM, > >>>> edid[EDID_BLOCK_LENGTH + EDID_CHECKSUM]); > >>>> - exynos_dp_write_byte_to_dpcd(dp, > >>>> - DP_TEST_RESPONSE, > >>>> + exynos_dp_write_byte_to_dpcd( > >>>> + dp, DP_TEST_RESPONSE, > >>>> DP_TEST_EDID_CHECKSUM_WRITE); > >>> To me, missing argument after opening parenthesis, looks worse. I would > >>> prefer: > >>> > >>> exynos_dp_write_byte_to_dpcd(dp, > >>> > >>> Why you moved the 'dp' argument to new line? > >> Hmm... Just like style tool indicate, no more warning after > >> that change. > >> > >> For now, I would like to follow the original style, just improved > >> some obvious style problem. :-) > > What was the checkpatch warning that said 'dp' has to move to new line? > > I tried this and I don't see it. > > checkpatch haven't remind me that put dp to new line would fix > this warning, this just come from my experiments. And I works, > no more warnings from checkpatch, so I toke this style. Checkpatch isn't a great arbiter of style. It's just a brainless tool. Always use your instead of anything brainless. If it were code I was writing, I'd ignore 80 columns warnings where appropriate. These are long function names and long macro defines, so it's inappropriate to use 80 columns as a guiding style. I'd write: exynos_dp_read_byte_from_dpcd(dp, DP_TEST_REQUEST, &test_vector); if (test_vector & DP_TEST_LINK_EDID_READ) { exynos_dp_write_byte_to_dpcd(dp, DP_TEST_EDID_CHECKSUM, edid[EDID_BLOCK_LENGTH + EDID_CHECKSUM]); exynos_dp_write_byte_to_dpcd(dp, DP_TEST_RESPONSE, DP_TEST_EDID_CHECKSUM_WRITE); }