From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760258AbbIDSdm (ORCPT ); Fri, 4 Sep 2015 14:33:42 -0400 Received: from smtprelay0095.hostedemail.com ([216.40.44.95]:51612 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755488AbbIDSdk (ORCPT ); Fri, 4 Sep 2015 14:33:40 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:800:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2553:2559:2562:2693:2828:2915:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4250:4321:5007:6261:7514:7576:7875:7903:9010:10004:10400:10848:11232:11658:11914:12043:12109:12294:12517:12519:12740:13069:13095:13149:13161:13229:13230:13311:13357:21060:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: coach21_59dec0d744311 X-Filterd-Recvd-Size: 2848 Message-ID: <1441391616.28194.8.camel@perches.com> Subject: Re: [PATCH] Staging: fsl-mc/bus: mc-bus.c: Fixed coding style issues From: Joe Perches To: "gregkh@linuxfoundation.org" Cc: Jose Rivera , Nayeemahmed Badebade , Stuart Yoder , "agraf@suse.de" , "hgujulan@visteon.com" , "linux-kernel@vger.kernel.org" Date: Fri, 04 Sep 2015 11:33:36 -0700 In-Reply-To: <20150904180017.GA6649@kroah.com> References: <20150903164834.GD31709@kroah.com> <1441386033-2900-1-git-send-email-itachi.opsrc@gmail.com> <20150904180017.GA6649@kroah.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-09-04 at 11:00 -0700, gregkh@linuxfoundation.org wrote: > On Fri, Sep 04, 2015 at 05:48:55PM +0000, Jose Rivera wrote: > > > -----Original Message----- > > > From: Nayeemahmed Badebade [mailto:itachi.opsrc@gmail.com] [] > > > Fixed coding style issues where kernel types u16,u64,u32 should be > > > preferred over uint16_t,uint64_t,uint32_t [] > > Thanks for your interests in helping us clean up this coding style issue. > > However, doing this for all the files related to the MC bus driver (not just > > for one) is something that I intend to do in a future patch as > > part of the "Cleanup" item of our TODO list. > > Doing this clean up across the board for all files is preferable than > > doing it just for this file in this patch. > > Sorry, but we never postpone a change submitted by someone just because > someone says "sometime in the future we will be making much the same > change". That's a sure way to kill productivity and stop developers > from helping you out. > > If you really wanted to make this type of change, you would have done so > already, so obviously it's not a high priority. I'll take Nayeemahmed's > patch. There's a problem with doing this on a file-by-file basis for a particular subsystem/driver. Doing so can break compilation because of differences between header files and compilation units. It's likely much better to do something like: $ git ls-files -- drivers/staging/fsl-mc/*.[ch] | \ xargs sed -r -i \ -e 's/\buint(8|16|32|64)_t\b/u\1/g' \ -e 's/\bint(8|16|32|64)_t\b/s\1/g' then verify, compile, test, and submit the diff.