* [PATCH v2] Documentation: add Device tree bindings for hwmon/nct7802
@ 2015-09-06 21:59 Constantine Shulyupin
2015-09-07 12:35 ` Mark Rutland
0 siblings, 1 reply; 2+ messages in thread
From: Constantine Shulyupin @ 2015-09-06 21:59 UTC (permalink / raw)
To: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Constantine Shulyupin,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: Guenter Roeck
Changed in v2:
- Removed nct7802,reg-init
- Added registers initialization by names
Introduced in v1:
- nct7802,reg-init
Signed-off-by: Constantine Shulyupin <const@MakeLinux.com>
---
---
.../devicetree/bindings/hwmon/nct7802.txt | 24 ++++++++++++++++++++++
1 file changed, 24 insertions(+)
create mode 100644 Documentation/devicetree/bindings/hwmon/nct7802.txt
diff --git a/Documentation/devicetree/bindings/hwmon/nct7802.txt b/Documentation/devicetree/bindings/hwmon/nct7802.txt
new file mode 100644
index 0000000..56214bf
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/nct7802.txt
@@ -0,0 +1,24 @@
+Nuvoton NCT7802Y Hardware Monitoring IC
+
+Required node properties:
+
+ - "compatible": must be "nuvoton,nct7802"
+ - "reg": I2C bus address of the device
+
+Optional properties:
+
+One byte registers:
+ - nct7802,Start
+ - nct7802,Mode
+ - nct7802,EnPECI
+ - nct7802,EnFan
+ - nct7802,EnV
+
+Example nct7802 node:
+
+nct7802 {
+ compatible = "nuvoton,nct7802";
+ reg = <0x2a>;
+ nct7802,Start = <0x01>;
+ nct7802,Mode = <0x7E>; // RTD1_MD = 2
+};
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] Documentation: add Device tree bindings for hwmon/nct7802
2015-09-06 21:59 [PATCH v2] Documentation: add Device tree bindings for hwmon/nct7802 Constantine Shulyupin
@ 2015-09-07 12:35 ` Mark Rutland
0 siblings, 0 replies; 2+ messages in thread
From: Mark Rutland @ 2015-09-07 12:35 UTC (permalink / raw)
To: Constantine Shulyupin
Cc: Rob Herring, Pawel Moll, Ian Campbell, Kumar Gala,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, Guenter Roeck
On Sun, Sep 06, 2015 at 10:59:49PM +0100, Constantine Shulyupin wrote:
> Changed in v2:
> - Removed nct7802,reg-init
> - Added registers initialization by names
>
> Introduced in v1:
> - nct7802,reg-init
>
> Signed-off-by: Constantine Shulyupin <const@MakeLinux.com>
> ---
> ---
> .../devicetree/bindings/hwmon/nct7802.txt | 24 ++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/nct7802.txt
>
> diff --git a/Documentation/devicetree/bindings/hwmon/nct7802.txt b/Documentation/devicetree/bindings/hwmon/nct7802.txt
> new file mode 100644
> index 0000000..56214bf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/nct7802.txt
> @@ -0,0 +1,24 @@
> +Nuvoton NCT7802Y Hardware Monitoring IC
> +
> +Required node properties:
> +
> + - "compatible": must be "nuvoton,nct7802"
> + - "reg": I2C bus address of the device
> +
> +Optional properties:
> +
> +One byte registers:
> + - nct7802,Start
> + - nct7802,Mode
> + - nct7802,EnPECI
> + - nct7802,EnFan
> + - nct7802,EnV
The binding doesn't describe what these actually represent, what type
they are, etc.
Also, "nct7802" is not a vendor prefix, and the camelcase naming is
unusual.
Why do you think you need these? Why must raw valeus be used rather than
giving the kernel the information it needs to derive these for itself?
Mark.
> +
> +Example nct7802 node:
> +
> +nct7802 {
> + compatible = "nuvoton,nct7802";
> + reg = <0x2a>;
> + nct7802,Start = <0x01>;
> + nct7802,Mode = <0x7E>; // RTD1_MD = 2
> +};
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-07 12:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-06 21:59 [PATCH v2] Documentation: add Device tree bindings for hwmon/nct7802 Constantine Shulyupin
2015-09-07 12:35 ` Mark Rutland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).