From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751717AbbIGNcP (ORCPT ); Mon, 7 Sep 2015 09:32:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37220 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750977AbbIGNcN (ORCPT ); Mon, 7 Sep 2015 09:32:13 -0400 Message-ID: <1441632729.27149.23.camel@redhat.com> Subject: Re: [PATCH] virtio-gpu: fix compilation warnings From: Gerd Hoffmann To: Mike Rapoport Cc: David Airlie , dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Date: Mon, 07 Sep 2015 15:32:09 +0200 In-Reply-To: <1441186241-5458-1-git-send-email-mike.rapoport@gmail.com> References: <1441186241-5458-1-git-send-email-mike.rapoport@gmail.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mi, 2015-09-02 at 12:30 +0300, Mike Rapoport wrote: > Update snprintf format in virtgpu_fence.c and virtgpu_debugfs.c to fix the > following compilation warnings: > > C [M] drivers/gpu/drm/virtio/virtgpu_fence.o > drivers/gpu/drm/virtio/virtgpu_fence.c: In function ‘virtio_timeline_value_str’ : > drivers/gpu/drm/virtio/virtgpu_fence.c:64:2: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘long long int’ [-Wformat=] > snprintf(str, size, "%lu", atomic64_read(&fence->drv->last_seq)); > ^ > CC [M] drivers/gpu/drm/virtio/virtgpu_debugfs.o > drivers/gpu/drm/virtio/virtgpu_debugfs.c: In function ‘virtio_gpu_debugfs_irq_info’: > drivers/gpu/drm/virtio/virtgpu_debugfs.c:39:6: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘long long int’ [-Wformat=] > vgdev->fence_drv.sync_seq); Doesn't fly. I assume this removes the warnings for 32bit builds, but with the patch applied I get warnings on 64bit builds ... cheers, Gerd