From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754690AbbIIQis (ORCPT ); Wed, 9 Sep 2015 12:38:48 -0400 Received: from mail-bn1bon0147.outbound.protection.outlook.com ([157.56.111.147]:57711 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752879AbbIIQip (ORCPT ); Wed, 9 Sep 2015 12:38:45 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Message-ID: <1441816715.29081.8.camel@freescale.com> Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage muram From: Scott Wood To: Zhao Qiang-B45475 CC: "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "lauraa@codeaurora.org" , Xie Xiaobo-R63061 , "benh@kernel.crashing.org" , Li Yang-Leo-R58472 , "paulus@samba.org" Date: Wed, 9 Sep 2015 11:38:35 -0500 In-Reply-To: References: <1441011520-15424-1-git-send-email-qiang.zhao@freescale.com> <1441011520-15424-2-git-send-email-qiang.zhao@freescale.com> <1441154062.4966.113.camel@freescale.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.0-fta1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [2601:448:8100:f9f:12bf:48ff:fe84:c9a0] X-ClientProxiedBy: BY2PR01CA0001.prod.exchangelabs.com (25.163.25.11) To CY1PR03MB1485.namprd03.prod.outlook.com (25.163.17.158) X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1485;2:NIqeo+aEc3AW6WJesSSgKNhFmy00fV+NEfyCMu1fsGPetXUlip7iyC7SpoBe5GsUKRJHOQnLBll2Gz+X8z39aoCE+WjjAxYC4SJpd5EbzGLWnnAipZ1HFJ2JvnmKExJA0QVhngk39VX++zfKFxBuP0xOooaf0wwfCzTKpYKIcHY=;3:LZPF19YArg/g2py0EY6O9SS8BX3tMrFY+v+DFlsVoltNT+WKbLZJF6zXKHeZBRsnxBX7Im7Ao0k3AmpzNiYfb+NgFswfjsxRbdFvIkb07S7lf2V5QtcV9ArnimGfzVjQF2AeqfOPZ0QESVhMXvV8Fg==;25:zjdcK7aML7dh+mJsBCuzt0Jr734gWUY63gv26rhg6V5IP5vnItCG3D/Uj98cWMIMxnPOIaxyz/H+Q21sPCgCbK5KEQST3qkanTNYHrDsBbJ2MA6s2HiQ1TiY17W/E0h2LxceZiRczdxmOLJcrpAbV9SzrmRx5DJZBjPaRBiCJqiY3570oE2C6A+BOlNPsFcThozyeUJKXJzIyvfLssy+D8AgNzyNCOLfvmnbs/jSVkaHD2raoOE6AcZpAmjRIzZuFb8cRvJ/4TkXm8EQFxuSSQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1485; X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1485;20:fbD4TvHipXCs6vXvYMTqwjX87tqLKH0qf7qIrg1FilYgPMPuCjzvXpJlSflEBFStNxUqvwrcY07Mo5f4/7lzjtbVRhfO4XNtqnYWiAMOdRTJjT0deJEhS7eeczPTIZGRG6ye2PqPxn7I5J35SmuNdjGjz9gIwrBJtDshaSuMUvIunDqsKcs35taM3rd9EliwPfkdngp5HhtFc1hoXjt5cOLrGwo/YrwNRdxY2hvZrs9wHTK+e5VZ78GY+uYjOcnggvZtUuafgT6CIS9yrPz+xzRT6L/Q02AK2eTNjswD6hzIlgpEYG/Tdykfb2d1p0kCJvQuUpNb5BHgVAK6Cl0eiiH3txBmBFXWQ8rOuonGJ8uZZRqhXgmZIoUg1Dey6ITUlPle3ki6+hP76gKh0jT3mCL3lc8pJ6uT3eYGv3Rcv1wL3NjpBULNwS+G23JoXOBR/mwWvVWnYmvo6L4cWFkoiFSY4CBujJF3mDN7JOoWMNdOs8zPYD0PwoHg+JQGuiq2;4:8PGVcXTLdsq+BZKadJIw6uBfg0R9HAYLPt9/swr1OrqNot0pn51RaKTHg/fFY73TUtMUg3GAFlmNiiy1CQDp1ym/5T3SrNT/UH3ybq0S8kPz5H3vZzOY+Sq2/n5UtzUniF60N3QukHMhAQJoGqY+nXqjrwvR5B6w9rPJc0U2MOOEMI5gxDovjeScH2QTbieKKks4up4sDr+dc+qmVOjbs0veYfJWYZfLg2A09b7VCcIMPXuLw4l8bgr5U+7SPzUh52pTyv8NE5ohSf8b5KQm2qc//86BJuch6Pip9EOh3MPcacd8N/HySwqSgMzJS2CyhVcn2/ylda9wNTEmaQpIlQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(8121501046)(3002001);SRVR:CY1PR03MB1485;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1485; X-Forefront-PRVS: 0694C54398 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(377424004)(24454002)(377454003)(13464003)(189002)(199003)(4001540100001)(50466002)(23676002)(5820100001)(2950100001)(87976001)(101416001)(5007970100001)(77096005)(46102003)(4001450100002)(5004730100002)(50226001)(36756003)(68736005)(122386002)(106356001)(105586002)(93886004)(110136002)(77156002)(189998001)(33646002)(5001960100002)(103116003)(50986999)(62966003)(81156007)(97736004)(64706001)(92566002)(42186005)(40100003)(5001860100001)(86362001)(19580405001)(47776003)(76176999)(19580395003)(5001830100001)(99106002)(3826002)(5001840100002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR03MB1485;H:[IPv6:2601:448:8100:f9f:12bf:48ff:fe84:c9a0];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjAzTUIxNDg1OzIzOmFNVnM0MGhwZjZIcW9hZWc2R2hZSUE2VTB2?= =?utf-8?B?L0JZU1Y0bGRhc3hDeDdOY0cyS2ZWUCttNDhtR2lXRDdraEppQUE0NzVxOHVE?= =?utf-8?B?d2VycXNya1lWemJKWE41dzk2RkcyYnhzd01KU2VWY0ZTeUJyU1EyaGNLYi9W?= =?utf-8?B?Qjhxa0kyYmxQakx4RmovZ0h3WDBScEJOYVA0Q1l0VU9ZSjA0QVZmb1JjRUph?= =?utf-8?B?RVRZMFg4TTc5YVJBZFFsNm9uZmlLbUNoT1Vpd3QwUXErbjF3MXJtb2RKeS9B?= =?utf-8?B?U09HNE9YbU9oU2FiWEhWU2RhanpIbTJoVE9XcGl0amxCS2NrWENZdmYzd2cx?= =?utf-8?B?UHlBaVVkbVpJVEJvVzBJUjZpMzlVNXBjYjFHVGtYRUJ0MmY4OFV2eStpZHA3?= =?utf-8?B?emdrWDV2N0ZvQ3VnOXRKWDVmdExqWHhneDJqZFhNTkZ4Z1pRZG1vTlJnYWpn?= =?utf-8?B?WUIwQzRlMStsb2YwQ3lIb1BWMDhSZnRHZkIzRXpoMEJwQjFpNzRUaFNrSklV?= =?utf-8?B?T0x0dVM1T29qbFdCczFtYlBpVUw4WTh6eHlhU1B4U0VmdUUxa0ZPMUg2YUtq?= =?utf-8?B?RU5uNDZsa3YrR1FwR1NSbDFFQngrKzl4V3hiYy83YUIvNEJES3grOEtkS0hP?= =?utf-8?B?bnB3em1Fb2RpbmZRRXh2Z201c1hheDJlOCs2SmJiNS9HS3lBMG4rZkk2bG5a?= =?utf-8?B?dTdHd0V1MjV3djNJbW14NGpnOGx6MERvcGQ1UGpqenJaT1BDN2lGcW9PNDJN?= =?utf-8?B?UkdYbHA0WVA3TkxLUk92YjZHTFdPdFd2TGlEMzdEYnJKM3hSeE96VEs3WjBk?= =?utf-8?B?TitHU2V0S2tiQ3JkWno5RndBaVJHZkQ1ZFErTWRna1BFSG9Ca0VLYjdSSUFo?= =?utf-8?B?blFuZms4RE8xd1VYdVVOUHp6ZUpVcVlrUFRZYnlZTnVLckVUcnErc3l6bnkx?= =?utf-8?B?NU1jRm9pUXI2c2tNU3E5cStBTkxoUDRpeFpYd0dlaE5vbUVsVUkwNXA2aWo3?= =?utf-8?B?YTZ3OTd4b3VFdmkwS0J0SEVPa1NVZXgzYzZ5KzhXcklDT3A0bVlzbHgwR3Br?= =?utf-8?B?WTgwdmZmK2MrVWtpaFVqUkFFYWdxdC9pMzhyazlWMEh3ZmZQeVhQMkRHQnZE?= =?utf-8?B?ZFpUemUzc2JCMVFYeTk4N1VXaFFnbXRBY2pwdUNtSU1PUVhsNHRJbEppYU5l?= =?utf-8?B?eFI4RDBuU0NoaVFuSHdtZUUxMW95L2xsYTlKdGxlTnBEeTZJRlpWWU9hd1Bu?= =?utf-8?B?RVdqSzh5b1F5ZlR3ek5tN2pBRi9ZSnpyNm9SaWpVWlAxRnF5MGhEa2wycFdF?= =?utf-8?B?Z2FaY0hGb1EvS2JBd1ByMUV5RUwxS28yNU9PUi9pVERWdDB2Rm9aMlBUY21l?= =?utf-8?B?aHRnelR2WnN6UmlLTlZQT200dEpabmVaU2ppRk5JeG9adEFmOUxtT29nVnpS?= =?utf-8?B?U0EySjl0bTM4dFMwUHpNVHhNY0t3V3hTVUFrNG9oeUVFTUVidVpWcTZqSnNu?= =?utf-8?B?V2FqeW0xSHJuQXFhRGtKdzJGS29Bb3FuWXRsV1p2Q21OQ3ozUmw4bGFISitW?= =?utf-8?B?cnVNWHdtSkhEVUw5MCtrYjZaV1ZpQ3NXaGx4b1lsS0l4ajRtTlNEMlcwdTdp?= =?utf-8?B?QVlVYVlnL201bkNEczM3NWhiWnZic21CRkEvakN1aklQV29uVjFrZzU1YmZY?= =?utf-8?B?QUdUR3l0WXhveXlISTQzZmswMnFQQ05vNDZoQXFQcER5Qlg5K2tYZnowd0M5?= =?utf-8?B?SWtPYkpWRFdBWjcvS2RLTXJqNkRNT3FrcDZ5UmVWMEg5OFhEWkJPcWVsYkFU?= =?utf-8?Q?5f4Di6On3kmle?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1485;5:4P4PpS/gksdXM5Rp5YNQM0jV6z16DOUsIUjiSeIfmQ6ejSiR729mltW0GeZiF+1AvJCioQYtdd2EgsYTQOKSPcmrOQUf0HKtZ7/RwYgTNgugqZrQiPCSXe+by38K0bRUAaAk1GsAdptqakd2oIgakg==;24:kqo/7NxLhtFXkbJzWAQl7iLJY+ngQFK9IfYWZFoHkPAqTKIWABb9vRQ7NFWqvbzVqTiLgeB85MoMDmUBRh8HsCftsTjlMrqgIKzubrncWlI=;20:N5vQVblqX1x2mWOn5qKFrPT0KCRHFb0riSw+YPNpKoKVp6T3sfSbNqtifOHCNtrYETLCDSIBzVAz6Ka2PixZoA== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2015 16:38:41.7852 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1485 X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1453;2:N5MNuRrTA2SIL/F2bHXJm4dI6+sDVDvx1LAMDdFUUpPKqAHzS+4bt/yipagfiosDHEP+Qcog3h4hG8Qwk1KsAe24wy9PRuC0eTFHg91I3cWc6uTLRERj0ZHU8OSVTt4xK04EinSMJ1U/RTI5bh5QSQDJEleBAIdCs0ov7vz0tLw=;23:cPRQBHm5HbWEus5u/jfGt7W6ThdO/9RFrfz20W4okZ2us7praNkph9ObGN92RpRfR6uv75yOX3OCTkJismznGAkcVJSqqiTE4dbtq9EoZdp8y2ahzwt8USzYRrmiWUwcXz8ghTVv2rmHl7T2XLRUvZkWKI0oHU6y1ffloPsRtDl5o6k7VFT7f4Rxej0Ds6/2 X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2015-09-06 at 01:37 -0500, Zhao Qiang-B45475 wrote: > On Mon, 2015-09-2 at 8:34 +0800, Wood Scott-B07421 wrote: > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Wednesday, September 02, 2015 8:34 AM > > To: Zhao Qiang-B45475 > > Cc: linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > lauraa@codeaurora.org; Xie Xiaobo-R63061; benh@kernel.crashing.org; Li > > Yang-Leo-R58472; paulus@samba.org > > Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage > > muram > > > > On Mon, 2015-08-31 at 16:58 +0800, Zhao Qiang wrote: > > > > > @@ -187,12 +190,25 @@ static inline int qe_alive_during_sleep(void) } > > > > > > /* we actually use cpm_muram implementation, define this for > > > convenience */ -#define qe_muram_init cpm_muram_init -#define > > > qe_muram_alloc cpm_muram_alloc -#define qe_muram_alloc_fixed > > > cpm_muram_alloc_fixed -#define qe_muram_free cpm_muram_free -#define > > > qe_muram_addr cpm_muram_addr -#define qe_muram_offset cpm_muram_offset > > > +#define cpm_muram_init qe_muram_init > > > +#define cpm_muram_alloc qe_muram_alloc #define cpm_muram_alloc_fixed > > > +qe_muram_alloc_fixed #define cpm_muram_free qe_muram_free #define > > > +cpm_muram_addr qe_muram_addr #define cpm_muram_offset qe_muram_offset > > > > Why? This is unnecessary churn. > > > This is necessary. QE is on both ARM and PowerPC, its code is under public > code. > But CPM is only on PowerPC and its code is under PowerPC. > So when build ARM, QE will not find cpm_muram_* function. If you move the cpm_muram functions to drivers/soc, then ARM will find them. There is no need to rename them. -Scott