From: Joe Perches <joe@perches.com>
To: Tejun Heo <tj@kernel.org>
Cc: Maurizio Lombardi <mlombard@redhat.com>,
akpm@linux-foundation.org, linux@rasmusvillemoes.dk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/vsprintf.c: increase the size of the field_width variable
Date: Wed, 09 Sep 2015 09:55:11 -0700 [thread overview]
Message-ID: <1441817711.17219.61.camel@perches.com> (raw)
In-Reply-To: <20150909163643.GC22909@mtj.duckdns.org>
On Wed, 2015-09-09 at 12:36 -0400, Tejun Heo wrote:
> On Wed, Sep 09, 2015 at 09:33:52AM -0700, Joe Perches wrote:
> > On Wed, 2015-09-09 at 12:13 +0200, Maurizio Lombardi wrote:
> > > When printing a bitmap using the "%*pb[l]" printk format
> > > a 16 bit variable (field_width) is used to store the size of the bitmap.
> > > In some cases 16 bits are not sufficient, the variable overflows and
> > > printk does not work as expected.
> >
> > If more than 16 bits are necessary, it couldn't work
> > as a single printk is limited to 1024 bytes.
>
> It's weird to fail silently tho. What we can do is just capping it at
> 16bit max and append something to indicate that the bitmap has been
> truncated if truncation actually happened.
It might be reasonable to output ... after the last
comma or dash of the bitmap output when buf >= end.
It also might be better to not reuse spec in
bitmap_string and bitmap_list_string.
next prev parent reply other threads:[~2015-09-09 16:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-09 10:13 [PATCH] lib/vsprintf.c: increase the size of the field_width variable Maurizio Lombardi
2015-09-09 13:39 ` Tejun Heo
2015-09-09 16:33 ` Joe Perches
2015-09-09 16:36 ` Tejun Heo
2015-09-09 16:55 ` Joe Perches [this message]
2015-09-09 18:51 ` Rasmus Villemoes
2015-09-09 19:26 ` Joe Perches
2015-09-10 14:36 ` Tejun Heo
2015-09-10 15:41 ` Joe Perches
2015-09-10 15:47 ` Tejun Heo
2015-09-10 7:04 ` Maurizio Lombardi
2015-09-10 7:13 ` Maurizio Lombardi
2015-09-10 7:38 ` Joe Perches
2015-09-10 7:56 ` Rasmus Villemoes
2015-09-10 8:17 ` Joe Perches
2015-09-10 14:43 ` Tejun Heo
2015-09-10 8:39 ` Maurizio Lombardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441817711.17219.61.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mlombard@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox