From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753119AbbIISqF (ORCPT ); Wed, 9 Sep 2015 14:46:05 -0400 Received: from smtprelay0002.hostedemail.com ([216.40.44.2]:45744 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750819AbbIISp7 (ORCPT ); Wed, 9 Sep 2015 14:45:59 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1537:1567:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:2919:3138:3139:3140:3141:3142:3622:3743:3865:3867:3868:3871:3872:4321:5007:6261:10004:10400:10848:11232:11658:11914:12296:12517:12519:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: ray28_3407515203a55 X-Filterd-Recvd-Size: 1340 Message-ID: <1441824356.17219.69.camel@perches.com> Subject: Re: [PATCH 3/4] net: mv643xx_eth: use kzalloc From: Joe Perches To: Rasmus Villemoes Cc: Sebastian Hesselbarth , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 09 Sep 2015 11:45:56 -0700 In-Reply-To: <87r3m74f2k.fsf@rasmusvillemoes.dk> References: <1441787886-7214-1-git-send-email-linux@rasmusvillemoes.dk> <1441787886-7214-4-git-send-email-linux@rasmusvillemoes.dk> <1441814431.17219.46.camel@perches.com> <87r3m74f2k.fsf@rasmusvillemoes.dk> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-09-09 at 20:34 +0200, Rasmus Villemoes wrote: > mc_spec and mc_other are u32*, we allocate 0x200 = 512 bytes = 128 > u32s, and pointer arithmetic makes mc_other point to the latter 64. Then > the memory is cleared 256 bytes at a time. > > It's unusual and slightly obfuscated code, but I don't think it's > wrong. Right, misread.