From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754898AbbIIVZv (ORCPT ); Wed, 9 Sep 2015 17:25:51 -0400 Received: from mail-bl2on0101.outbound.protection.outlook.com ([65.55.169.101]:59205 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751808AbbIIVZr (ORCPT ); Wed, 9 Sep 2015 17:25:47 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Message-ID: <1441833937.29081.45.camel@freescale.com> Subject: Re: [PATCH v3] powerpc/dts: Add and fix 1588 timer node for eTSEC From: Scott Wood To: Lu Yangbo-B47093 CC: "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" Date: Wed, 9 Sep 2015 16:25:37 -0500 In-Reply-To: References: <1438153958-1400-1-git-send-email-yangbo.lu@freescale.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.0-fta1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [2601:448:8100:f9f:12bf:48ff:fe84:c9a0] X-ClientProxiedBy: BY2PR05CA055.namprd05.prod.outlook.com (10.141.250.45) To BLUPR03MB1473.namprd03.prod.outlook.com (25.163.81.158) X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB1473;2:RpwcGdaCuH9w0uZtkfFgHWi5mqqV8pfbNdMxnrZuBzLbYDBnx/EX7oQaruSIptqRQFQKzJHLi1egYYxPNFBATuTGrbKycCKqam3hzC7MAIYJSlmI3W47SYtlhMCgm8W3E9MylSBm0pNVb3upPmwmkEVnmaqbDQ1BMldXmD62m7Q=;3:6rkbmstzBrGsT8Xr5f1m6cuktTVmpC1aHacLS8zPoKpzqCzXKC5s0IaFn0ur0e1duUc10WtJrnBSej2hpmVSktFMKcASyvfrxWoSvh8WGda9c2ndVCwKfvtYrSXZsOdRY9OI7Vvg62wgNdxaPrH5mg==;25:aj4Y5AhZubEDfyXUCG/PAu4BDl8ijGm4TJYwmf+hAZgdhx4Mwbsfq1sURtz8XTlA0lhvgvxztHASjB41nokkWzyotCmsliUwus8JglDw0ez442mAIHqlQTfsF560W+QhT45E2AecAbl5P144LTMhM1TD5BfaUsVcppb/sL8xAIUtG0BnodowX1QV9H2/uccFeKxvGApN1aZWMwTtXHaSnV1k5CSipHM9WiQLN/Hg+RHVsYI7jTRZRt8SqHLCnyyJdt0jOAOlZIlz16ifk1zG/g== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1473; X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB1473;20:0fgtEz8fodER5OJ7q3WvJWkY+pg0/k4nUwknLgRpAN2V+dW99kQQiQp0Qv6fDiTBoDEUQP6ZA6i3xjS/Mk1gPFP3MlJ/vtLjK217WSDawxKUyZnYWT3nist/9HWqLGubpCb/R9APmiLgLO9+DYr14l1FcwRY5vAkuSbNxauKfXuPhRQNAFWrdczxeauPRh3ZLHC/KkadnZ5f+hCEkXSB20K3jxDBP7PSii2vuME4kmBaPwSM9QvYeFiVqIVSZJaL5Gr23UWPXp/f9RXGg4BJBBfcL4sc6EjJHoZksCjT0s9TbOarSIPkuWB7/+kn0Z9oQ96+ZbhAb0//WMWEPKablkFNtWHnQK4/UvLJBE8nKJKrwFsiD4coHzRkaqwQf8Iob47uKNUoqHtklugp0Ix6k2lOMJkEoVHnI/PifKA4yFN22+oDMZb7gk3MEwgu/fuRcJz9ernsR/2PkdWAX4hAJOnMXO5EI/qnVXcxRk6JTZn/NXivfXjlhsPQoYkq6Trk;4:Q2O/ywmDd/xXiGRtJYynSBDadToDl3lVRVy8buK/IjPwVO2gePi0QMPmbijGhSYRvSud5IHAPLwcwGa59vQkW/wzjnxc+w+/hTUeyA+EFABvPXE4An6e3o9P047wnyzPiybIJ6+i2eZEa454mI0RJvfhj/ULUQIZQcyVgDqhiHwgAH5lxC5m2Pp+NWtg3E45dfx0YeDvKvFW+LyVM/iZ+KrZd4kFOMO2hxaj5bguVyeMQ9nGmW1yRrqm8W1ZQ4APIQ26eD6flv84kRDFO0hedY7AuqWkEWd9aZFJZ3Fj1c4YS/vKXT1LfTNUCHAgHUfE X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(8121501046)(3002001);SRVR:BLUPR03MB1473;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1473; X-Forefront-PRVS: 0694C54398 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(377424004)(13464003)(199003)(189002)(377454003)(24454002)(92566002)(5820100001)(122386002)(77156002)(47776003)(36756003)(23676002)(68736005)(86362001)(62966003)(105586002)(2950100001)(110136002)(5001960100002)(575784001)(40100003)(81156007)(101416001)(106356001)(103116003)(19580395003)(19580405001)(77096005)(5001830100001)(5004730100002)(76176999)(189998001)(64706001)(42186005)(97736004)(4001540100001)(4001450100002)(33646002)(87976001)(46102003)(5007970100001)(50986999)(50466002)(50226001)(5001860100001)(99106002)(3826002)(5001840100002);DIR:OUT;SFP:1102;SCL:1;SRVR:BLUPR03MB1473;H:[IPv6:2601:448:8100:f9f:12bf:48ff:fe84:c9a0];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTFVQUjAzTUIxNDczOzIzOjdYOEt5Wld0YyttTHlpdWZwaUpOclRWRzFq?= =?utf-8?B?M1NPRFA3YVNML1NtNTZkMVdybG5SK1B3V3g4RGsraDRFemd4SnB5c2d5S3lI?= =?utf-8?B?d0R2NWVISDEyVkdFWGxKWHk2L2wxaUJsc1hYVkh0N0ZmalNjZXlTWU5RL2NR?= =?utf-8?B?emt3NzhNWXUraCtTMGNnS3BkZlNabnh4V2VhZ1M0dlN4ZW9WNHRvN2twNHFY?= =?utf-8?B?RmRjbndrTGNUNEFHWEdkaHZtY29zU041Ujh5TS9RbUI0SXplN0VLN0xCajlN?= =?utf-8?B?Rk9ITjdqNk5LWkRTejdmZENIMURITWgyTG5JcVVDdVlhTHVKL3oxMldLRm1P?= =?utf-8?B?Ymt6UTNiMExJUFNUaDkwZEtRbDBYT3hwNFZpL2o5Y2ROa2xEajJ4QklvTWxj?= =?utf-8?B?R04vMkZWSlJGa2cxUzNBWVAvemx2YjEyOUZUekYydlp4bFphcHV1Tmh0Sk9L?= =?utf-8?B?a1lvdmNRZ09wQ3dKRy9TTFZ3akc4Tk1QWkdhSG53a1U0UHNqMi9lVExFMkZi?= =?utf-8?B?dmVRazVCOXIydW54dW82ZE1PcjMwUFU5SkdJWVNoL0MzcWhTRkdNWWV2T215?= =?utf-8?B?dnBuWllnazlOYXlSQ1V3MUorSTMycHFFenc3Y2l0YmVYeFFvSEwyeEY5Q05T?= =?utf-8?B?L25ZWlQ3OVR4bTdSemc1ODJ2cE5zUEpBS3A1NE9FMXVQYzNEYVJubDFqTFhJ?= =?utf-8?B?aTlzVzlwMDk5a0tjY1VHZ0tjdEFLY0JhMFRKQmdrU0pseGRjVXZvTDRFMlI5?= =?utf-8?B?UHJVNUFSajJBMUlXUlpIUGM5V3dmbzlOMk9kRU1HVG9rU3VYWWRuRHZGdzBK?= =?utf-8?B?V0MzQ3lGVjVuOGttU0ZsNC9RWWlGT1ZqdSswajBYb2Q3V0tlbmRncmYxc2pY?= =?utf-8?B?OHVXQ1YyamJ0K3JxOEZYcGZLeloydDUrcUoreGU2eEpJMFZnSXpNT1JEWnFZ?= =?utf-8?B?MngreUtpOFJCeE10OTUyeFhtREFkcytoMGgxUVNlUitzU09CNEJucVRHcXlB?= =?utf-8?B?M0hheFh1WWp5R3Mxblg2MEVBQzJSNWJvNUNKR2toRnFkdk5PdGdhMHlqOGZi?= =?utf-8?B?Zmg4UUc0bDVjbWphWVFkZVZ4U0txeWJZZDlnTGljVjhWdlJ6MFcrTzQwc1d5?= =?utf-8?B?S2ZVZktZdnNYbkE5dGNPOFIzSDdISTRQeVlWTy8rVkhIMjQzc0l5Q1U3Y3Rs?= =?utf-8?B?WmI5eEVSZGpOTjFqa053c0lmUnhQdzJzeUFWL2hvQms5MjY5dEdpVjA4OTBv?= =?utf-8?B?eG1iTFFjekZnUVp4VHhYNm9YNklOS2RKZDd0K0xyZitrckd3NVhHRlg1N2Zz?= =?utf-8?B?N0JjRUlZZmoyaEhPYzFSOUdKcEpTbXhZa2huaFQ1amwzblJ1M0ltZE9qbVdU?= =?utf-8?B?N1ZDRmkvOGlIb0Z2bGdGbmpvdHBvZDJxV1YxUTJsMlF3aHVEdjNNOWtRZk54?= =?utf-8?B?bnM5N2dlb3I3N24xVHlRYnZWWEZMZTF0cXNjQkl6VUJpclVBWEpJem5OUU5a?= =?utf-8?B?djFyOVJBQmRxNXEvU292ZXpwM3NmbXNXZFVneFg2QTVkS0pocnNhcWo3R29M?= =?utf-8?B?OStrTzRTaklUQVVtTVR3WXlMTVplZkMyQWlPMUNxZ3l1S3BreW41V1lWQUUr?= =?utf-8?B?V2lFRitSTk1iQjlWWTcyZWM4OE1Zcm1uajZhZEtTOFNjMktLWkV4bEFkVkZn?= =?utf-8?B?VTMyeWJMelpZNWdrQm9JTjdqUVBJOGJRM2grWXhNWU5vWWxtYWowRzBySnM3?= =?utf-8?B?VnoxWElZa1kzbWJybnFXYmd6bDBJdzFVR0h4c2t2MnBXbzBOUVpqQWttU1Va?= =?utf-8?Q?ss84x5vy25DLn?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB1473;5:ciIPM79C5V7fuctsapQFJtjb2gmHgwe+24lY0mKCN3RXRjSD7eQ97ihhIVArkwRj+O/M0FuReNIfkjyDkUSmUxYPAZeu7ZQirn79SP6zp7OQPol8IzcFuWzdG+D7rqCg3KM06BBuXIZ2KsoXpZ4bjg==;24:yhYKEKpoUsrgKXyOX0O0uBJBLNqn5QGfM4+mtLjng+zBBkfaDpnzmK3uZXfxyNSAem7kOmMY/NsJqBxaKZaqc4E3w+rTHPC/OucjMNCFCpE=;20:Bum4PX7F3akFOaD22TpleuyPEfR0MNV8ntue6Vdsq1a0enLo4Y86Yt/7opvlLhlbACe1bdYFZNO6aWcFsPnIQg== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2015 21:25:42.8759 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1473 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-09-07 at 01:57 -0500, Lu Yangbo-B47093 wrote: > Any comments? > > -Yangbo Lu Sorry, this somehow got marked as Awaiting Upstream in patchwork but not applied to my tree. I'll take it next time. -Scott > > > -----Original Message----- > > From: Yangbo Lu [mailto:yangbo.lu@freescale.com] > > Sent: Wednesday, July 29, 2015 3:13 PM > > To: linuxppc-dev@lists.ozlabs.org; linux-kernel@vger.kernel.org; Wood > > Scott-B07421 > > Cc: Lu Yangbo-B47093 > > Subject: [PATCH v3] powerpc/dts: Add and fix 1588 timer node for eTSEC > > > > Add 1588 timer node in files: > > arch/powerpc/boot/dts/bsc9131rdb.dtsi > > arch/powerpc/boot/dts/bsc9132qds.dtsi > > arch/powerpc/boot/dts/p1010rdb.dtsi > > arch/powerpc/boot/dts/p1020rdb-pd.dts > > arch/powerpc/boot/dts/p1021rdb-pc.dtsi > > arch/powerpc/boot/dts/p1022ds.dtsi > > arch/powerpc/boot/dts/p1025twr.dtsi > > For P2020RDB-PC, registers' values should be calculated based on default > > 1588 reference clock(300MHz) not 250MHz, and fix this in file: > > arch/powerpc/boot/dts/p2020rdb-pc.dtsi > > > > Signed-off-by: Yangbo Lu > > --- > > Changes for v3: > > - Changed 'tmr-add' to hex value > > - Modified commit message > > Changes for v2: > > - Changed hex value to decimal value in dts > > - Modified commit message > > - Modified 1588 node in p2020rdb-pc.dtsi > > --- > > arch/powerpc/boot/dts/bsc9131rdb.dtsi | 12 ++++++++++++ > > arch/powerpc/boot/dts/bsc9132qds.dtsi | 12 ++++++++++++ > > arch/powerpc/boot/dts/p1010rdb.dtsi | 12 ++++++++++++ > > arch/powerpc/boot/dts/p1020rdb-pd.dts | 12 ++++++++++++ > > arch/powerpc/boot/dts/p1021rdb-pc.dtsi | 12 ++++++++++++ > > arch/powerpc/boot/dts/p1022ds.dtsi | 12 ++++++++++++ > > arch/powerpc/boot/dts/p1025twr.dtsi | 12 ++++++++++++ > > arch/powerpc/boot/dts/p2020rdb-pc.dtsi | 12 ++++++------ > > 8 files changed, 90 insertions(+), 6 deletions(-) > > > > diff --git a/arch/powerpc/boot/dts/bsc9131rdb.dtsi > > b/arch/powerpc/boot/dts/bsc9131rdb.dtsi > > index 45efcba..f4d96d2 100644 > > --- a/arch/powerpc/boot/dts/bsc9131rdb.dtsi > > +++ b/arch/powerpc/boot/dts/bsc9131rdb.dtsi > > @@ -80,6 +80,18 @@ > > status = "disabled"; > > }; > > > > + ptp_clock@b0e00{ > > + compatible = "fsl,etsec-ptp"; > > + reg = <0xb0e00 0xb0>; > > + interrupts = <68 2 0 0 69 2 0 0>; > > + fsl,tclk-period = <5>; > > + fsl,tmr-prsc = <2>; > > + fsl,tmr-add = <0xcccccccd>; > > + fsl,tmr-fiper1 = <999999995>; > > + fsl,tmr-fiper2 = <99990>; > > + fsl,max-adj = <249999999>; > > + }; > > + > > enet0: ethernet@b0000{ > > phy-handle = <&phy0>; > > phy-connection-type = "rgmii-id"; > > diff --git a/arch/powerpc/boot/dts/bsc9132qds.dtsi > > b/arch/powerpc/boot/dts/bsc9132qds.dtsi > > index af8e888..7a13bf2 100644 > > --- a/arch/powerpc/boot/dts/bsc9132qds.dtsi > > +++ b/arch/powerpc/boot/dts/bsc9132qds.dtsi > > @@ -87,6 +87,18 @@ > > }; > > }; > > > > + ptp_clock@b0e00{ > > + compatible = "fsl,etsec-ptp"; > > + reg = <0xb0e00 0xb0>; > > + interrupts = <68 2 0 0 69 2 0 0>; > > + fsl,tclk-period = <5>; > > + fsl,tmr-prsc = <2>; > > + fsl,tmr-add = <0xcccccccd>; > > + fsl,tmr-fiper1 = <999999995>; > > + fsl,tmr-fiper2 = <99990>; > > + fsl,max-adj = <249999999>; > > + }; > > + > > enet0: ethernet@b0000{ > > phy-handle = <&phy0>; > > tbi-handle = <&tbi0>; > > diff --git a/arch/powerpc/boot/dts/p1010rdb.dtsi > > b/arch/powerpc/boot/dts/p1010rdb.dtsi > > index ea534ef..0f0ced6 100644 > > --- a/arch/powerpc/boot/dts/p1010rdb.dtsi > > +++ b/arch/powerpc/boot/dts/p1010rdb.dtsi > > @@ -186,6 +186,18 @@ > > }; > > }; > > > > + ptp_clock@b0e00{ > > + compatible = "fsl,etsec-ptp"; > > + reg = <0xb0e00 0xb0>; > > + interrupts = <68 2 0 0 69 2 0 0>; > > + fsl,tclk-period = <10>; > > + fsl,tmr-prsc = <2>; > > + fsl,tmr-add = <0x80000016>; > > + fsl,tmr-fiper1 = <999999990>; > > + fsl,tmr-fiper2 = <99990>; > > + fsl,max-adj = <199999999>; > > + }; > > + > > enet0: ethernet@b0000{ > > phy-handle = <&phy0>; > > phy-connection-type = "rgmii-id"; > > diff --git a/arch/powerpc/boot/dts/p1020rdb-pd.dts > > b/arch/powerpc/boot/dts/p1020rdb-pd.dts > > index 987017e..c7c6416 100644 > > --- a/arch/powerpc/boot/dts/p1020rdb-pd.dts > > +++ b/arch/powerpc/boot/dts/p1020rdb-pd.dts > > @@ -225,6 +225,18 @@ > > }; > > }; > > > > + ptp_clock@b0e00{ > > + compatible = "fsl,etsec-ptp"; > > + reg = <0xb0e00 0xb0>; > > + interrupts = <68 2 0 0 69 2 0 0>; > > + fsl,tclk-period = <10>; > > + fsl,tmr-prsc = <2>; > > + fsl,tmr-add = <0x80000016>; > > + fsl,tmr-fiper1 = <999999990>; > > + fsl,tmr-fiper2 = <99990>; > > + fsl,max-adj = <199999999>; > > + }; > > + > > enet0: ethernet@b0000{ > > fixed-link = <1 1 1000 0 0>; > > phy-connection-type = "rgmii-id"; > > diff --git a/arch/powerpc/boot/dts/p1021rdb-pc.dtsi > > b/arch/powerpc/boot/dts/p1021rdb-pc.dtsi > > index d6274c5..e8a0f95 100644 > > --- a/arch/powerpc/boot/dts/p1021rdb-pc.dtsi > > +++ b/arch/powerpc/boot/dts/p1021rdb-pc.dtsi > > @@ -224,6 +224,18 @@ > > }; > > }; > > > > + ptp_clock@b0e00{ > > + compatible = "fsl,etsec-ptp"; > > + reg = <0xb0e00 0xb0>; > > + interrupts = <68 2 0 0 69 2 0 0>; > > + fsl,tclk-period = <10>; > > + fsl,tmr-prsc = <2>; > > + fsl,tmr-add = <0x80000016>; > > + fsl,tmr-fiper1 = <999999990>; > > + fsl,tmr-fiper2 = <99990>; > > + fsl,max-adj = <199999999>; > > + }; > > + > > enet0: ethernet@b0000{ > > fixed-link = <1 1 1000 0 0>; > > phy-connection-type = "rgmii-id"; > > diff --git a/arch/powerpc/boot/dts/p1022ds.dtsi > > b/arch/powerpc/boot/dts/p1022ds.dtsi > > index 957e0dc..149da0f 100644 > > --- a/arch/powerpc/boot/dts/p1022ds.dtsi > > +++ b/arch/powerpc/boot/dts/p1022ds.dtsi > > @@ -215,6 +215,18 @@ > > }; > > }; > > > > + ptp_clock@b0e00{ > > + compatible = "fsl,etsec-ptp"; > > + reg = <0xb0e00 0xb0>; > > + interrupts = <68 2 0 0 69 2 0 0>; > > + fsl,tclk-period = <5>; > > + fsl,tmr-prsc = <2>; > > + fsl,tmr-add = <0xc01ebd3d>; > > + fsl,tmr-fiper1 = <999999995>; > > + fsl,tmr-fiper2 = <99990>; > > + fsl,max-adj = <266499999>; > > + }; > > + > > ethernet@b0000{ > > phy-handle = <&phy0>; > > phy-connection-type = "rgmii-id"; > > diff --git a/arch/powerpc/boot/dts/p1025twr.dtsi > > b/arch/powerpc/boot/dts/p1025twr.dtsi > > index 8453501..08816fb 100644 > > --- a/arch/powerpc/boot/dts/p1025twr.dtsi > > +++ b/arch/powerpc/boot/dts/p1025twr.dtsi > > @@ -138,6 +138,18 @@ > > }; > > }; > > > > + ptp_clock@b0e00{ > > + compatible = "fsl,etsec-ptp"; > > + reg = <0xb0e00 0xb0>; > > + interrupts = <68 2 0 0 69 2 0 0>; > > + fsl,tclk-period = <10>; > > + fsl,tmr-prsc = <2>; > > + fsl,tmr-add = <0xc0000021>; > > + fsl,tmr-fiper1 = <999999990>; > > + fsl,tmr-fiper2 = <99990>; > > + fsl,max-adj = <133333332>; > > + }; > > + > > enet0: ethernet@b0000{ > > phy-handle = <&phy0>; > > phy-connection-type = "rgmii-id"; > > diff --git a/arch/powerpc/boot/dts/p2020rdb-pc.dtsi > > b/arch/powerpc/boot/dts/p2020rdb-pc.dtsi > > index c21d1c7..ad2e242 100644 > > --- a/arch/powerpc/boot/dts/p2020rdb-pc.dtsi > > +++ b/arch/powerpc/boot/dts/p2020rdb-pc.dtsi > > @@ -215,12 +215,12 @@ > > }; > > > > ptp_clock@24e00{ > > - fsl,tclk-period = <5>; > > - fsl,tmr-prsc = <200>; > > - fsl,tmr-add = <0xCCCCCCCD>; > > - fsl,tmr-fiper1 = <0x3B9AC9FB>; > > - fsl,tmr-fiper2 = <0x0001869B>; > > - fsl,max-adj = <249999999>; > > + fsl,tclk-period = <5>; > > + fsl,tmr-prsc = <2>; > > + fsl,tmr-add = <0xaaaaaaab>; > > + fsl,tmr-fiper1 = <999999995>; > > + fsl,tmr-fiper2 = <99990>; > > + fsl,max-adj = <299999999>; > > }; > > > > enet0: ethernet@24000{ > > -- > > 2.1.0.27.g96db324 >