From: Joe Perches <joe@perches.com>
To: Shraddha Barke <shraddha.6596@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Jonathan Cameron <jic23@kernel.org>,
Peter Meerwald <pmeerw@pmeerw.net>,
Hartmut Knaack <knaack.h@gmx.de>,
linux-kernel@vger.kernel.org, Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH 6/6] Staging: iio: resolver: Prefer using the BIT macro
Date: Wed, 09 Sep 2015 21:24:41 -0700 [thread overview]
Message-ID: <1441859081.17219.125.camel@perches.com> (raw)
In-Reply-To: <1441858434-2846-6-git-send-email-shraddha.6596@gmail.com>
On Thu, 2015-09-10 at 09:43 +0530, Shraddha Barke wrote:
> This patch replaces bit shifting on 1 with the BIT(x) macro
> as it's extensively used by other function in this driver.
[]
> diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c
[]
> @@ -149,7 +149,7 @@ int ad2s1210_update_frequency_control_word(struct ad2s1210_state *st)
> int ret;
> unsigned char fcw;
>
> - fcw = (unsigned char)(st->fexcit * (1 << 15) / st->fclkin);
> + fcw = (unsigned char)(st->fexcit * BIT(15) / st->fclkin);
Multiplying by a bit isn't very obvious.
Maybe just shift it.
fcw = (unsigned char)((st->fexcit << 15) / st->fclkin);
next prev parent reply other threads:[~2015-09-10 4:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 4:13 [PATCH 1/6] Staging: iio: addac: adt7316.c : Prefer using BIT macro Shraddha Barke
2015-09-10 4:13 ` [PATCH 2/6] Staging: iio: cdc: ad7152.c: Prefer using the " Shraddha Barke
2015-09-10 6:01 ` Julia Lawall
2015-09-10 4:13 ` [PATCH 3/6] Staging: iio: meter: " Shraddha Barke
2015-09-10 4:13 ` [PATCH 4/6] Staging: iio: cdc: ad7746.c: " Shraddha Barke
2015-09-10 5:59 ` Julia Lawall
2015-09-10 4:13 ` [PATCH 5/6] Staging: iio: impedance-analyzer: " Shraddha Barke
2015-09-10 5:57 ` Julia Lawall
2015-09-10 10:05 ` Shraddha Barke
2015-09-10 12:42 ` Julia Lawall
2015-09-10 4:13 ` [PATCH 6/6] Staging: iio: resolver: " Shraddha Barke
2015-09-10 4:24 ` Joe Perches [this message]
2015-09-10 8:05 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441859081.17219.125.camel@perches.com \
--to=joe@perches.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=julia.lawall@lip6.fr \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=shraddha.6596@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox