From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751722AbbIJWJT (ORCPT ); Thu, 10 Sep 2015 18:09:19 -0400 Received: from mail-bn1bn0107.outbound.protection.outlook.com ([157.56.110.107]:59373 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751660AbbIJWJO (ORCPT ); Thu, 10 Sep 2015 18:09:14 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Message-ID: <1441922945.2909.12.camel@freescale.com> Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage muram From: Scott Wood To: Zhao Qiang-B45475 CC: "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "lauraa@codeaurora.org" , Xie Xiaobo-R63061 , "benh@kernel.crashing.org" , Li Yang-Leo-R58472 , "paulus@samba.org" Date: Thu, 10 Sep 2015 17:09:05 -0500 In-Reply-To: References: <1441011520-15424-1-git-send-email-qiang.zhao@freescale.com> <1441011520-15424-2-git-send-email-qiang.zhao@freescale.com> <1441154062.4966.113.camel@freescale.com> <1441816715.29081.8.camel@freescale.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.0-fta1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [2601:448:8100:f9f:12bf:48ff:fe84:c9a0] X-ClientProxiedBy: DM3PR10CA0013.namprd10.prod.outlook.com (25.164.12.23) To BY1PR03MB1484.namprd03.prod.outlook.com (25.162.210.142) X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1484;2:B9wXK7LYeA85XzA8PpLvSzEyrWiQYBcignhcf1uIZTe8aVWHma757BOvFLTBsboQ+U9D1hLZ9ABBFYAEGGR7TIzm9wUOFW5kJnShlBEXqsVRdNnXFL9tpE7GShbgIWDWfJaByXNmlOwMgckTEAZLTOOOqDSezOYhKim6RuhhAVo=;3:xPtgRGRKKcyUPUIB1vtdXgbrjRxKJY2kCk6riv43EUVpU4yqdjld/r10KcI+cguvM5KzbmK9tveQ9Fv5d1ai8LIh/57Los41ZZ0EV5nsckTTzvqwK0bZTQPjGFcTsha4sNeFR7VL8XqSUmNHRenQdw==;25:Xws0FTPcWaQptprtsN8qQMMm5R8M3OKId9Y5Cyq6mV4iXzxn/zJUzEUdRcXMmOuiVg+YSUz+1P/w7SehE66/uyX5VdxtYqepOzIf84kTzeH8RRL6tFwApFwR14qmIjjEqh4s1/Y/od/sYYPsqhyWw7Z3D1WFja7cUFSfcvkATjbZpOQzr4xQc70tGNjIY38dgYjgsav99jnbAE3EnVmHxFxlnYPKL69grMLq+Zja/bAbEPS9I0TajnaUioIO1bzm X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1484; X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1484;20:pZrfDa40cKIRRSobcfSKWn/gAo8q0NU4xqWimLJAgox6P519yJLzqS/0WNG5LRBQr+mcqsbxkMObJQI2wcXAmEJIX/nQlNXGwozY/N3RNMFho2H8BWHZIFF+trlIfVnVjosn2WE+N/OjNcSLTdzV17DugM1xgR7vk2nHiRCg5oBikzEEAp8Liz4PMjfr+JFIZ9w4B6pjnEho17ywyPBtvlq54L3HeYi/MEsmNNfXiVwRJmNV5p+6R2HWvuBOfPqUqOaGD97Q+yXozy8m4UvSed4CMwRuUhsFYWfWgZkoiXAdZ5tupaZRy3SElxwTqcp64pdywnrywRVbO3X1OJhAXY47VnftFxgdmKluBcIN++XWogVK54wgwNa9p55xqMm9gh/HMi6au3V4HCOp6JfUAJ4Z/MT7crPHRbJrE8vfLK+wgvp3IbyMexEBBT6I2es18Mcq4i0yZCViPL846NveADRtAc8X4/v3LDDhr9dQReh9a7dUSYBG7yHj2Aed6cXZ;4:w7V/IEGtxJgxRjDs/4Z3pn8Dd10+CD9bavOwL5eTWZoh0vh1hD421wpO8jdN6qMOlRNLnhsNdWQFTVawBfwTPAztzvfPQqYlb5ixWL3WKpqGnLtwHlYZ29xyhrm1ngGtJAoSDMXivPu3M5i2rKiCqdv/+NUU4NlT6+qEXpCuA8Lo1jUzx0aGGWG+Ouz0UA9iSV7xLotDy9zSewXkhaAx6pob9IWIr1hV4UpZF/J4UK1KZRU0+76dZ7NJPTO3iO7dbjPUdlllJqjpOlOcuQmI734SiGzlqV3kT/o29UfSA9dAhpL6C1FckSWxmm7a1jiV X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(8121501046)(3002001);SRVR:BY1PR03MB1484;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1484; X-Forefront-PRVS: 06952FC175 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(24454002)(377424004)(13464003)(199003)(189002)(377454003)(5001860100001)(68736005)(106356001)(50226001)(5007970100001)(2950100001)(64706001)(92566002)(50466002)(5004730100002)(87976001)(62966003)(5820100001)(103116003)(77156002)(50986999)(86362001)(19580405001)(36756003)(19580395003)(93886004)(77096005)(47776003)(101416001)(105586002)(23676002)(40100003)(81156007)(97736004)(122386002)(46102003)(189998001)(5001960100002)(5001830100001)(42186005)(4001450100002)(76176999)(4001540100001)(5001920100001)(110136002)(33646002)(99106002)(3826002)(5001840100002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR03MB1484;H:[IPv6:2601:448:8100:f9f:12bf:48ff:fe84:c9a0];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTFQUjAzTUIxNDg0OzIzOks4blJHbmdNS1BEcTFjSGxZNmU3cGo5eGZG?= =?utf-8?B?KzNHZGU2ckV3aWROZkREQVVBVDhzaHVMZjVOYkNUL3lRcDJOYlRrS3FaQUcv?= =?utf-8?B?ZnBIYmlDRDhoZjgzLzhQd1U4UXZtVklBYStab1F6bUxjejR1dE1KM0VLcys2?= =?utf-8?B?SE9FQ1BSdko4SCttekRybXVYejFDTmh0d2syc2w5ZEFGZmdCd01rT20yakFs?= =?utf-8?B?ZXdCVFYxWnNjR3gya0Vtdm5FN0wzRWV6RWlRMGdDQ1VoSjZTdnRBZE5WUTVT?= =?utf-8?B?WVBYZmVhVEp0ZTRxVGVuUHA0SlE5V3RXYUxXWkNUYnRGZ0MwdFYwdHVwaXdl?= =?utf-8?B?RGhLY0pQZ1VLd1JMYzU0NGQyVldYZ0hXN1FwbzljZWFsR3pubElOQjA5aU9y?= =?utf-8?B?MWNTQlJ0Rk5qS0dGeGhBclJWaXlnR2crb1o5V251Zlk1NStrb2pZNEN2cHJq?= =?utf-8?B?eHRldE11QXhyRG1GT1F6cVZXWjUvd1packJoMmNPbnhGTkZuZm8zdHYvMTA4?= =?utf-8?B?UWljUm9ac1VsS25yeVFpcm5jeTVGdTNqSmdseE04cHNUYml1VXBGSnk0aDZK?= =?utf-8?B?SHBLcGQyL3ptUWhod281cUVkcFgvWG9rY1dPZjhNMVEyYXc0b3lCWk5NRHFl?= =?utf-8?B?RDI1R01oNEVDTkVpOTZvS3VkRXRDb3U4Y1lWTjJJbWYwSjhzRUpGVk1ESzJ2?= =?utf-8?B?ems2a2RlQ2x3YTkvNmswWnpJTTNSU0ZnanlZVEw2TVZkRXdYSVNEV3JMVFpQ?= =?utf-8?B?RUtwUmpXUGFlSm12bUM3U1ROVjFIczRmSDA4K1prc3RKSmdtTWhUN3ErdTNy?= =?utf-8?B?cExDclMyV20vaXhKd0NvWGxtbW1KSitVSzRoaExSazJlWDJIbi95Sk9vZy9B?= =?utf-8?B?MkNYTlJkdU5paFNBWDBGVkh5cVYyNk1tY1RFek1JZzNPVVFTTWl4OFVtYXFC?= =?utf-8?B?dGpRWGlxZEZSbVVFMzdrWExBQzRxT1RDUSt3Q0IrU1Jod2o4N1BpcEJqZEw3?= =?utf-8?B?TnVZNXBXRXowdHZUTS8zOHRwVmxjem8xZ3pyMXplQlVlaUswK2RBZWtzOEJi?= =?utf-8?B?bVUxMm5vNDhlVnlJdDJZRTllQWkxY1JMQ1o1ZVRYVEZZZTdTd3lNR3E3OXFp?= =?utf-8?B?d0FocGRLcXR1TnNTRm51OERWczcxMFFRNWVjNGYySW4ybUdQMFpBblhoUkNG?= =?utf-8?B?Vld0SjhEcUszR1I4WUhVL2VJUm9nMnVXclJIQW9xSWVUR2hicWdMM1RqcFYz?= =?utf-8?B?VHRQTVRNaW1FbXpyZklvWnJ6TWsyNlJRQ21DaVgzUnM2MEhhZUZHUHdZVExo?= =?utf-8?B?ekNKYmRCSGZMWGpUTEtnSS9xOGhDcXVtVVdsTXBjdGg0RW5TS2ZkeEcraURG?= =?utf-8?B?TG1ENytXZFRQNWE4cUlQa2RtK2NUcytaS2ZuaTQzOWg3ZkpqNWplMzZYMFJP?= =?utf-8?B?UmhWRExaekdnQ2dWd0wzZm5pNUh3MDBiMlpkM0VZK3p4K041cEJXV21Fc211?= =?utf-8?B?WWRES1BmKzU4S3pRYlVQelREeUw2c0lWa1B0T09vcHlVTFVqSDM4YkpWVVlU?= =?utf-8?B?QVlrTnNNQW5xRmU1cEtKSVZweG96SmlSQWtZNyt4Ukh4dEdjTnJXTWxMeHNS?= =?utf-8?B?VFpvRkw2a2ErVW1udXlLTEhoUG9MRXg0dGtFNDR4MDAyaU16TEtMMGRNbUVY?= =?utf-8?B?d1cvcE95MGNiOHRWRmVDR2NOd0lvMzRiS3BDUk5keERqMERUODNIQTZ2YWI2?= =?utf-8?B?aGh2dTVhUEVURjNEQXpyUkV5a1hsdEdaTWxUcXFZb3c3UFh3dHJLaEFZTEdv?= =?utf-8?B?bWJuekZmeTh6MmxsRlJFR3NoNyt6S2VPZm1HU2hPMC9tWWU5K0FhbFBDK1By?= =?utf-8?Q?VRZgthfJPf8=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1484;5:7IaAEWOe0iVxdAzitF06ZxGnZyohVxqipgxnUGQxrvFxHyPp2N0x7m3tZTnZ4SP2/YD9R2QPRLQ7OK0RHKOcDewLJ90vBPAMn6SoVNokNmVBOwgxSCGMhjMsba2e3g1Li3S13SsPxtwaWQzHcOTjDg==;24:xUB39FGahfiXORahaNZ9/nc0XlI+WDurPStkttIE5CyvJtunFnmmf6kiGNDIxr51PtQ41rXKf/64N7k/n8ZTlScLxHqxn0kDTEAd0SaAwwE=;20:k1RXiLe32P6dV/4LKYeoOlfhSwD82zRHBoZ4/1d/istfjHEIWFJEGNk4IiO+82VN6cn5Ln0tH1mFCiMFv6ojfg== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2015 22:09:10.6879 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1484 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-09-09 at 21:34 -0500, Zhao Qiang-B45475 wrote: > On Mon, 2015-09-10 at 12:39 -0500, Wood Scott-B07421 wrote: > > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Thursday, September 10, 2015 12:39 AM > > To: Zhao Qiang-B45475 > > Cc: linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > lauraa@codeaurora.org; Xie Xiaobo-R63061; benh@kernel.crashing.org; Li > > Yang-Leo-R58472; paulus@samba.org > > Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage > > muram > > > > On Sun, 2015-09-06 at 01:37 -0500, Zhao Qiang-B45475 wrote: > > > On Mon, 2015-09-2 at 8:34 +0800, Wood Scott-B07421 wrote: > > > > -----Original Message----- > > > > From: Wood Scott-B07421 > > > > Sent: Wednesday, September 02, 2015 8:34 AM > > > > To: Zhao Qiang-B45475 > > > > Cc: linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > > > lauraa@codeaurora.org; Xie Xiaobo-R63061; benh@kernel.crashing.org; > > > > Li Yang-Leo-R58472; paulus@samba.org > > > > Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to > > > > manage muram > > > > > > > > On Mon, 2015-08-31 at 16:58 +0800, Zhao Qiang wrote: > > > > > > > > > @@ -187,12 +190,25 @@ static inline int > > > > > qe_alive_during_sleep(void) } > > > > > > > > > > /* we actually use cpm_muram implementation, define this for > > > > > convenience */ -#define qe_muram_init cpm_muram_init -#define > > > > > qe_muram_alloc cpm_muram_alloc -#define qe_muram_alloc_fixed > > > > > cpm_muram_alloc_fixed -#define qe_muram_free cpm_muram_free > > > > > -#define qe_muram_addr cpm_muram_addr -#define qe_muram_offset > > > > > cpm_muram_offset > > > > > +#define cpm_muram_init qe_muram_init #define cpm_muram_alloc > > > > > +qe_muram_alloc #define cpm_muram_alloc_fixed qe_muram_alloc_fixed > > > > > +#define cpm_muram_free qe_muram_free #define cpm_muram_addr > > > > > +qe_muram_addr #define cpm_muram_offset qe_muram_offset > > > > > > > > Why? This is unnecessary churn. > > > > > > > This is necessary. QE is on both ARM and PowerPC, its code is under > > > public code. > > > But CPM is only on PowerPC and its code is under PowerPC. > > > So when build ARM, QE will not find cpm_muram_* function. > > > > If you move the cpm_muram functions to drivers/soc, then ARM will find > > them. > > There is no need to rename them. > > Yes, moving cpm_muram can handle this issue. However, cpm is not necessary > To move to public code, and a churn is simpler than moving cpm_muram. > Please consider my suggestion, Thank you! What do you mean by "public code"? You're already moving cpm_muram. I'm just asking that you not rename it while you do so. If it absolutely must be renamed, do it in a different patch from the one that moves the code, though I don't see why the rename is helpful. -Scott