From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753476AbbIKSbP (ORCPT ); Fri, 11 Sep 2015 14:31:15 -0400 Received: from mx2.parallels.com ([199.115.105.18]:37881 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751775AbbIKSbO (ORCPT ); Fri, 11 Sep 2015 14:31:14 -0400 From: James Bottomley To: "akpm@linux-foundation.org" CC: "linux@rasmusvillemoes.dk" , "andriy.shevchenko@linux.intel.com" , "vkuznets@redhat.com" , "linux-kernel@vger.kernel.org" , "kys@microsoft.com" Subject: Re: [PATCH] lib/string_helpers.c: fix infinite loop in string_get_size() Thread-Topic: [PATCH] lib/string_helpers.c: fix infinite loop in string_get_size() Thread-Index: AQHQ5xElQ/AWGVePjEuqnLeWY03SE5424luAgAFE4oA= Date: Fri, 11 Sep 2015 18:31:07 +0000 Message-ID: <1441996263.6276.4.camel@Odin.com> References: <1441371393-15030-1-git-send-email-vkuznets@redhat.com> <20150910160815.30d56ee48bbfdf5eed783c53@linux-foundation.org> In-Reply-To: <20150910160815.30d56ee48bbfdf5eed783c53@linux-foundation.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-mailer: Evolution 3.12.11 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [151.124.179.37] Content-Type: multipart/mixed; boundary="_002_144199626362764camelOdincom_" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --_002_144199626362764camelOdincom_ Content-Type: text/plain; charset="utf-8" Content-ID: <05ED5A402305984CACE1D7C672C5E57D@sw.swsoft.com> Content-Transfer-Encoding: base64 T24gVGh1LCAyMDE1LTA5LTEwIGF0IDE2OjA4IC0wNzAwLCBBbmRyZXcgTW9ydG9uIHdyb3RlOg0K PiBPbiBGcmksICA0IFNlcCAyMDE1IDE0OjU2OjMzICswMjAwIFZpdGFseSBLdXpuZXRzb3YgPHZr dXpuZXRzQHJlZGhhdC5jb20+IHdyb3RlOg0KPiANCj4gPiBzdHJpbmdfZ2V0X3NpemUoMSwgNTEy LCAwLCAuLi4sIC4uLikgY2FsbCByZXN1bHRzIGluIGFuIGluZmluaXRlIGxvb3AuIFRoZQ0KPiA+ IHByb2JsZW0gaXMgdGhhdCBpZiBzaXplID09IDAgd2hlbiB3ZSBzdGFydCBjYWxjdWxhdGluZyBz Zl9jYXAgdGhpcyBsb29wDQo+ID4gd2lsbCBuZXZlciBlbmQuDQo+ID4gDQo+ID4gVGhlIGNhbGxl ciBjYXVzaW5nIHRoZSBpc3N1ZSBpcyBzZF9yZWFkX2NhcGFjaXR5KCksIHRoZSBwcm9ibGVtIHdh cyBub3RpY2VkDQo+ID4gb24gSHlwZXItVi4NCj4gDQo+IFdoZW4gZml4aW5nIGJ1Z3MsIHBsZWFz ZSBwcm92aWRlIGVub3VnaCBpbmZvIGZvciBvdGhlcnMgdG8gYmUgYWJsZSB0bw0KPiB1bmRlcnN0 YW5kIHdoaWNoIGtlcm5lbCB2ZXJzaW9uKHMpIG5lZWQgdGhlIGZpeC4gIEluIHRoaXMgY2FzZTog d2hhdA0KPiBlbmQtdXNlciBhY3Rpb24gdHJpZ2dlcnMgdGhpcyBidWc/ICAoaW93LCBob3cgZG9l cyBzZGtwLT5jYXBhY2l0eQ0KPiBiZWNvbWUgemVybz8pDQoNCkFueSBtb3JlIGRldGFpbHMuICBU aGUgYXR0YWNoZWQgcHJvZ3JhbW1lLCB3aGljaCBpcyBjdXQgc3RyYWlnaHQgb3V0IG9mDQp0aGUg YWxnb3JpdGhtIGluIHN0cmluZ19oZWxwZXJzLmMgYW5kIG1vZGlmaWVkIGZvciBhIEMgZW52aXJv bm1lbnQNCnNsaWdodGx5IChvbmx5IGluIGRvX2RpdiBhbmQgdGhlIHR5cGVkZWZzKSBwcm9kdWNl cyB0aGlzDQoNCmhlbGxvDQpTVFJJTkcgSVMgNTEyIEINCg0KV2l0aCB5b3VyIGlucHV0LCBzbyBJ IGRvbid0IHRoaW5rIHRoZSBwcm9ibGVtIGlzIHdoZXJlIHlvdSB0aGluayBpdCBpcy4NCg0KSmFt ZXMNCg0K --_002_144199626362764camelOdincom_ Content-Type: text/x-csrc; name="test.c" Content-Description: test.c Content-Disposition: attachment; filename="test.c"; size=2502; creation-date="Fri, 11 Sep 2015 18:31:07 GMT"; modification-date="Fri, 11 Sep 2015 18:31:07 GMT" Content-ID: Content-Transfer-Encoding: base64 I2luY2x1ZGUgPHN5cy90eXBlcy5oPgojaW5jbHVkZSA8c3RyaW5nLmg+CiNpbmNsdWRlIDxzdGRp by5oPgoKIyBkZWZpbmUgZG9fZGl2KG4sYmFzZSkgKHsJCQkJCVwKCXUzMiBfX2Jhc2UgPSAoYmFz ZSk7CQkJCVwKCXUzMiBfX3JlbTsJCQkJCQlcCglfX3JlbSA9ICgodTY0KShuKSkgJSBfX2Jhc2U7 CQkJXAoJKG4pID0gKCh1NjQpKG4pKSAvIF9fYmFzZTsJCQkJXAoJX19yZW07CQkJCQkJCVwKIH0p CgojZGVmaW5lIEFSUkFZX1NJWkUoYXJyKSAoc2l6ZW9mKGFycikgLyBzaXplb2YoKGFycilbMF0p KQoKdHlwZWRlZiB1bnNpZ25lZCBsb25nIGxvbmcgdTY0Owp0eXBlZGVmIHVuc2lnbmVkIGludCB1 MzI7CgplbnVtIHN0cmluZ19zaXplX3VuaXRzIHsKICBTVFJJTkdfVU5JVFNfMiwKICBTVFJJTkdf VU5JVFNfMTAsCn07CgovKioKICogc3RyaW5nX2dldF9zaXplIC0gZ2V0IHRoZSBzaXplIGluIHRo ZSBzcGVjaWZpZWQgdW5pdHMKICogQHNpemU6CVRoZSBzaXplIHRvIGJlIGNvbnZlcnRlZCBpbiBi bG9ja3MKICogQGJsa19zaXplOglTaXplIG9mIHRoZSBibG9jayAodXNlIDEgZm9yIHNpemUgaW4g Ynl0ZXMpCiAqIEB1bml0czoJdW5pdHMgdG8gdXNlIChwb3dlcnMgb2YgMTAwMCBvciAxMDI0KQog KiBAYnVmOglidWZmZXIgdG8gZm9ybWF0IHRvCiAqIEBsZW46CWxlbmd0aCBvZiBidWZmZXIKICoK ICogVGhpcyBmdW5jdGlvbiByZXR1cm5zIGEgc3RyaW5nIGZvcm1hdHRlZCB0byAzIHNpZ25pZmlj YW50IGZpZ3VyZXMKICogZ2l2aW5nIHRoZSBzaXplIGluIHRoZSByZXF1aXJlZCB1bml0cy4gIEBi dWYgc2hvdWxkIGhhdmUgcm9vbSBmb3IKICogYXQgbGVhc3QgOSBieXRlcyBhbmQgd2lsbCBhbHdh eXMgYmUgemVybyB0ZXJtaW5hdGVkLgogKgogKi8Kdm9pZCBzdHJpbmdfZ2V0X3NpemUodTY0IHNp emUsIHU2NCBibGtfc2l6ZSwgY29uc3QgZW51bSBzdHJpbmdfc2l6ZV91bml0cyB1bml0cywKCQkg ICAgIGNoYXIgKmJ1ZiwgaW50IGxlbikKewoJc3RhdGljIGNvbnN0IGNoYXIgKmNvbnN0IHVuaXRz XzEwW10gPSB7CgkJIkIiLCAia0IiLCAiTUIiLCAiR0IiLCAiVEIiLCAiUEIiLCAiRUIiLCAiWkIi LCAiWUIiCgl9OwoJc3RhdGljIGNvbnN0IGNoYXIgKmNvbnN0IHVuaXRzXzJbXSA9IHsKCQkiQiIs ICJLaUIiLCAiTWlCIiwgIkdpQiIsICJUaUIiLCAiUGlCIiwgIkVpQiIsICJaaUIiLCAiWWlCIgoJ fTsKCXN0YXRpYyBjb25zdCBjaGFyICpjb25zdCAqY29uc3QgdW5pdHNfc3RyW10gPSB7CgkJW1NU UklOR19VTklUU18xMF0gPSB1bml0c18xMCwKCQlbU1RSSU5HX1VOSVRTXzJdID0gdW5pdHNfMiwK CX07CglzdGF0aWMgY29uc3QgdW5zaWduZWQgaW50IGRpdmlzb3JbXSA9IHsKCQlbU1RSSU5HX1VO SVRTXzEwXSA9IDEwMDAsCgkJW1NUUklOR19VTklUU18yXSA9IDEwMjQsCgl9OwoJaW50IGksIGo7 Cgl1MzIgcmVtYWluZGVyID0gMCwgc2ZfY2FwLCBleHA7CgljaGFyIHRtcFs4XTsKCWNvbnN0IGNo YXIgKnVuaXQ7CgoJdG1wWzBdID0gJ1wwJzsKCWkgPSAwOwoJaWYgKCFzaXplKQoJCWdvdG8gb3V0 OwoKCXdoaWxlIChibGtfc2l6ZSA+PSBkaXZpc29yW3VuaXRzXSkgewoJCXJlbWFpbmRlciA9IGRv X2RpdihibGtfc2l6ZSwgZGl2aXNvclt1bml0c10pOwoJCWkrKzsKCX0KCglleHAgPSBkaXZpc29y W3VuaXRzXSAvICh1MzIpYmxrX3NpemU7CglpZiAoc2l6ZSA+PSBleHApIHsKCQlyZW1haW5kZXIg PSBkb19kaXYoc2l6ZSwgZGl2aXNvclt1bml0c10pOwoJCXJlbWFpbmRlciAqPSBibGtfc2l6ZTsK CQlpKys7Cgl9IGVsc2UgewoJCXJlbWFpbmRlciAqPSBzaXplOwoJfQoKCXNpemUgKj0gYmxrX3Np emU7CglzaXplICs9IHJlbWFpbmRlciAvIGRpdmlzb3JbdW5pdHNdOwoJcmVtYWluZGVyICU9IGRp dmlzb3JbdW5pdHNdOwoKCXdoaWxlIChzaXplID49IGRpdmlzb3JbdW5pdHNdKSB7CgkJcmVtYWlu ZGVyID0gZG9fZGl2KHNpemUsIGRpdmlzb3JbdW5pdHNdKTsKCQlpKys7Cgl9CgoJc2ZfY2FwID0g c2l6ZTsKCWZvciAoaiA9IDA7IHNmX2NhcCoxMCA8IDEwMDA7IGorKykKCQlzZl9jYXAgKj0gMTA7 CgoJaWYgKGopIHsKCQlyZW1haW5kZXIgKj0gMTAwMDsKCQlyZW1haW5kZXIgLz0gZGl2aXNvclt1 bml0c107CgkJc25wcmludGYodG1wLCBzaXplb2YodG1wKSwgIi4lMDN1IiwgcmVtYWluZGVyKTsK CQl0bXBbaisxXSA9ICdcMCc7Cgl9Cgogb3V0OgoJaWYgKGkgPj0gQVJSQVlfU0laRSh1bml0c18y KSkKCQl1bml0ID0gIlVOSyI7CgllbHNlCgkJdW5pdCA9IHVuaXRzX3N0clt1bml0c11baV07CgoJ c25wcmludGYoYnVmLCBsZW4sICIldSVzICVzIiwgKHUzMilzaXplLAoJCSB0bXAsIHVuaXQpOwp9 CgppbnQgbWFpbihjaGFyICphcmdjW10sIGludCBhcmd2KQp7CmNoYXIgYnVmWzUxMl07Cgpwcmlu dGYoImhlbGxvXG4iKTsKc3RyaW5nX2dldF9zaXplKDEsIDUxMiwgU1RSSU5HX1VOSVRTXzIsIGJ1 Ziwgc2l6ZW9mKGJ1ZikpOwpwcmludGYoIlNUUklORyBJUyAlc1xuIiwgYnVmKTsKCn0K --_002_144199626362764camelOdincom_--