[PATCH] lib/string_helpers.c: fix infinite loop in string_get_size()

Vitaly Kuznetsov
2015-09-04T12:56:39Z

string_get_size(1, 512, 0, ..., ...) call results in an infinite loop. The
problem is that if size == 0 when we start calculating sf_cap this loop
will never end.

The caller causing the issue is sd_read_capacity(), the problem was noticed
on Hyper-V.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
lib/string_helpers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/string_helpers.c b/lib/string_helpers.c
index c98ae81..a155c7b 100644
--- a/lib/string_helpers.c
+++ b/lib/string_helpers.c
@@ -76,7 +76,7 @@ void string_get_size(u64 size, u64 blk_size, const enum string_size_units units,
i++;
}

- sf_cap = size;
+ sf_cap = size ? size : 1;
for (j = 0; sf_cap*10 < 1000; j++)
sf_cap *= 10;

--
2.4.3