Re: [PATCH] lib/string_helpers.c: fix infinite loop in string_get_size()

Andrew Morton
2015-09-10T23:08:17Z

On Fri, 4 Sep 2015 14:56:33 +0200 Vitaly Kuznetsov <vkuznets@redhat.com> wrote:

> string_get_size(1, 512, 0, ..., ...) call results in an infinite loop. The
> problem is that if size == 0 when we start calculating sf_cap this loop
> will never end.
>
> The caller causing the issue is sd_read_capacity(), the problem was noticed
> on Hyper-V.

When fixing bugs, please provide enough info for others to be able to
understand which kernel version(s) need the fix. In this case: what
end-user action triggers this bug? (iow, how does sdkp->capacity
become zero?)