* [PATCH] Staging: lustre: lustre: lov: lov_dev.c: Added missing blank line
@ 2015-09-14 9:11 Sakshi Vaid
2015-09-14 14:12 ` Greg KH
2015-09-14 15:29 ` [PATCH v2] " Sakshi Vaid
0 siblings, 2 replies; 3+ messages in thread
From: Sakshi Vaid @ 2015-09-14 9:11 UTC (permalink / raw)
To: oleg.drokin
Cc: andreas.dilger, gregkh, jinshan.xiong, HPDD-discuss, devel,
linux-kernel, Sakshi Vaid
Added a missing blank line after declarations.
158: WARNING: Missing a blank line after declarations
183: WARNING: Missing a blank line after declarations
Signed-off-by: Sakshi Vaid <sakshivaid95@gmail.com>
---
drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 4 ++--
drivers/staging/lustre/lustre/lov/lov_dev.c | 2 ++
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
index d31bf73..68cf1b7 100644
--- a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
+++ b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
@@ -828,8 +828,8 @@ int ccc_prep_size(const struct lu_env *env, struct cl_object *obj,
* --bug 17336 */
loff_t size = cl_isize_read(inode);
loff_t cur_index = start >> PAGE_CACHE_SHIFT;
- loff_t size_index = ((size - 1)
- >> PAGE_CACHE_SHIFT);
+ loff_t size_index =
+ ((size - 1) >> PAGE_CACHE_SHIFT);
if ((size == 0 && cur_index != 0) ||
size_index < cur_index)
diff --git a/drivers/staging/lustre/lustre/lov/lov_dev.c b/drivers/staging/lustre/lustre/lov/lov_dev.c
index 796a015..aadb8f2 100644
--- a/drivers/staging/lustre/lustre/lov/lov_dev.c
+++ b/drivers/staging/lustre/lustre/lov/lov_dev.c
@@ -155,6 +155,7 @@ static void lov_key_fini(const struct lu_context *ctx,
struct lu_context_key *key, void *data)
{
struct lov_thread_info *info = data;
+
LINVRNT(list_empty(&info->lti_closure.clc_list));
OBD_SLAB_FREE_PTR(info, lov_thread_kmem);
}
@@ -180,6 +181,7 @@ static void lov_session_key_fini(const struct lu_context *ctx,
struct lu_context_key *key, void *data)
{
struct lov_session *info = data;
+
OBD_SLAB_FREE_PTR(info, lov_session_kmem);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Staging: lustre: lustre: lov: lov_dev.c: Added missing blank line
2015-09-14 9:11 [PATCH] Staging: lustre: lustre: lov: lov_dev.c: Added missing blank line Sakshi Vaid
@ 2015-09-14 14:12 ` Greg KH
2015-09-14 15:29 ` [PATCH v2] " Sakshi Vaid
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2015-09-14 14:12 UTC (permalink / raw)
To: Sakshi Vaid
Cc: oleg.drokin, devel, andreas.dilger, linux-kernel, HPDD-discuss,
jinshan.xiong
On Mon, Sep 14, 2015 at 02:41:24PM +0530, Sakshi Vaid wrote:
> Added a missing blank line after declarations.
>
> 158: WARNING: Missing a blank line after declarations
> 183: WARNING: Missing a blank line after declarations
>
> Signed-off-by: Sakshi Vaid <sakshivaid95@gmail.com>
> ---
> drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 4 ++--
> drivers/staging/lustre/lustre/lov/lov_dev.c | 2 ++
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
> index d31bf73..68cf1b7 100644
> --- a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
> +++ b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
> @@ -828,8 +828,8 @@ int ccc_prep_size(const struct lu_env *env, struct cl_object *obj,
> * --bug 17336 */
> loff_t size = cl_isize_read(inode);
> loff_t cur_index = start >> PAGE_CACHE_SHIFT;
> - loff_t size_index = ((size - 1)
> - >> PAGE_CACHE_SHIFT);
> + loff_t size_index =
> + ((size - 1) >> PAGE_CACHE_SHIFT);
This change has nothing to do with what you said you were doing up at
the top of the changelog :(
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] Staging: lustre: lustre: lov: lov_dev.c: Added missing blank line
2015-09-14 9:11 [PATCH] Staging: lustre: lustre: lov: lov_dev.c: Added missing blank line Sakshi Vaid
2015-09-14 14:12 ` Greg KH
@ 2015-09-14 15:29 ` Sakshi Vaid
1 sibling, 0 replies; 3+ messages in thread
From: Sakshi Vaid @ 2015-09-14 15:29 UTC (permalink / raw)
To: andreas.dilger
Cc: gregkh, jinshan.xiong, HPDD-discuss, devel, linux-kernel,
Sakshi Vaid
line 158: WARNING: Missing a blank line after declarations
line 183: WARNING: Missing a blank line after declarations
Added a missing blank line after declartions.
Signed-off-by: Sakshi Vaid <sakshivaid95@gmail.com>
---
drivers/staging/lustre/lustre/lov/lov_dev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/lustre/lustre/lov/lov_dev.c b/drivers/staging/lustre/lustre/lov/lov_dev.c
index 796a015..aadb8f2 100644
--- a/drivers/staging/lustre/lustre/lov/lov_dev.c
+++ b/drivers/staging/lustre/lustre/lov/lov_dev.c
@@ -155,6 +155,7 @@ static void lov_key_fini(const struct lu_context *ctx,
struct lu_context_key *key, void *data)
{
struct lov_thread_info *info = data;
+
LINVRNT(list_empty(&info->lti_closure.clc_list));
OBD_SLAB_FREE_PTR(info, lov_thread_kmem);
}
@@ -180,6 +181,7 @@ static void lov_session_key_fini(const struct lu_context *ctx,
struct lu_context_key *key, void *data)
{
struct lov_session *info = data;
+
OBD_SLAB_FREE_PTR(info, lov_session_kmem);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-14 15:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-14 9:11 [PATCH] Staging: lustre: lustre: lov: lov_dev.c: Added missing blank line Sakshi Vaid
2015-09-14 14:12 ` Greg KH
2015-09-14 15:29 ` [PATCH v2] " Sakshi Vaid
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).