From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751816AbbINSKE (ORCPT ); Mon, 14 Sep 2015 14:10:04 -0400 Received: from queue01b.mail.zen.net.uk ([212.23.3.242]:34167 "EHLO queue01b.mail.zen.net.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750944AbbINSKA (ORCPT ); Mon, 14 Sep 2015 14:10:00 -0400 X-Greylist: delayed 3017 seconds by postgrey-1.27 at vger.kernel.org; Mon, 14 Sep 2015 14:10:00 EDT Message-ID: <1442251092.2850.53.camel@linaro.org> Subject: Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI sensors From: "Jon Medhurst (Tixy)" To: Punit Agrawal Cc: Mark Rutland , "devicetree@vger.kernel.org" , "linux-pm@vger.kernel.org" , Liviu Dudau , "linux-kernel@vger.kernel.org" , "lm-sensors@lm-sensors.org" , "edubezval@gmail.com" , "robh+dt@kernel.org" , "linux@roeck-us.net" , Sudeep Holla , "linux-arm-kernel@lists.infradead.org" Date: Mon, 14 Sep 2015 18:18:12 +0100 In-Reply-To: <9hhk2rtdq1f.fsf@e105922-lin.cambridge.arm.com> References: <1442235619-4029-1-git-send-email-punit.agrawal@arm.com> <1442235619-4029-2-git-send-email-punit.agrawal@arm.com> <20150914131448.GC7002@leverpostej> <9hhh9mxf7lg.fsf@e105922-lin.cambridge.arm.com> <20150914134949.GE7002@leverpostej> <9hhk2rtdq1f.fsf@e105922-lin.cambridge.arm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-smarthost01a-IP: [82.69.122.217] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-09-14 at 15:38 +0100, Punit Agrawal wrote: > Mark Rutland writes: > > >> >> +Sensor bindings for the sensors based on SCPI Message Protocol > >> >> +-------------------------------------------------------------- > >> >> +SCPI provides an API to access the various sensors on the SoC. > >> >> + > >> >> +Required properties: > >> >> +- compatible : should be "arm,scpi-sensors". > >> >> +- #thermal-sensor-cells: should be set to 1. This property follows the > >> >> + thermal device tree bindings[2]. > >> > > >> > You need to specify what the valid values for this cell are. > >> > >> The enumeration depends on the number of sensors exported by SCP > >> firmware - which is platform dependent. I could add add something like > >> if you think that is helpful - > >> > >> "Valid cell value is a number between 0..n-1, where n is the number > >> of sensors exported by SCP firmware." > > > > Can the FW identifer space have holes? Or are they always contiguous? > > The way the SCP interface is defined, the sensor identifiers are > contiguous, Is there any documentation other than DUI0922A? [1] From what I can seen that just says it's a 16-bit value and doesn't put any particular constraints on its value. [1] http://community.arm.com/servlet/JiveServlet/download/8401-40-18262/DUI0922A_scp_message_interface.pdf -- Tixy