From: "Andrew F. Davis" <afd@ti.com>
To: "Pali Rohár" <pali.rohar@gmail.com>,
"Sebastian Reichel" <sre@kernel.org>,
"Dmitry Eremin-Solenikov" <dbaryshkov@gmail.com>,
"David Woodhouse" <dwmw2@infradead.org>
Cc: Dan Murphy <dmurphy@ti.com>, <linux-pm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, "Andrew F. Davis" <afd@ti.com>
Subject: [PATCH v4 3/7] power: bq27xxx_battery: Platform initialization must declare a device
Date: Mon, 14 Sep 2015 16:26:09 -0500 [thread overview]
Message-ID: <1442265973-32261-4-git-send-email-afd@ti.com> (raw)
In-Reply-To: <1442265973-32261-1-git-send-email-afd@ti.com>
When initialized as a platform device the initializer must now specify
a device. An empty device name is no longer valid.
Signed-off-by: Andrew F. Davis <afd@ti.com>
---
drivers/power/bq27xxx_battery.c | 9 ++++++---
drivers/w1/slaves/w1_bq27000.c | 1 +
include/linux/power/bq27xxx_battery.h | 6 +++++-
3 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers/power/bq27xxx_battery.c b/drivers/power/bq27xxx_battery.c
index e72055c..0734413 100644
--- a/drivers/power/bq27xxx_battery.c
+++ b/drivers/power/bq27xxx_battery.c
@@ -91,8 +91,6 @@ struct bq27xxx_access_methods {
int (*read)(struct bq27xxx_device_info *di, u8 reg, bool single);
};
-enum bq27xxx_chip { BQ27000, BQ27500, BQ27425, BQ27742, BQ27510};
-
struct bq27xxx_reg_cache {
int temperature;
int time_to_empty;
@@ -1036,6 +1034,11 @@ static int bq27xxx_battery_platform_probe(struct platform_device *pdev)
return -EINVAL;
}
+ if (!pdata->chip) {
+ dev_err(&pdev->dev, "no device supplied\n");
+ return -EINVAL;
+ }
+
di = devm_kzalloc(&pdev->dev, sizeof(*di), GFP_KERNEL);
if (!di)
return -ENOMEM;
@@ -1043,7 +1046,7 @@ static int bq27xxx_battery_platform_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, di);
di->dev = &pdev->dev;
- di->chip = BQ27000;
+ di->chip = pdata->chip;
name = pdata->name ?: dev_name(&pdev->dev);
di->bus.read = &bq27xxx_battery_platform_read;
diff --git a/drivers/w1/slaves/w1_bq27000.c b/drivers/w1/slaves/w1_bq27000.c
index 8480531..9f4a86b 100644
--- a/drivers/w1/slaves/w1_bq27000.c
+++ b/drivers/w1/slaves/w1_bq27000.c
@@ -42,6 +42,7 @@ static int w1_bq27000_read(struct device *dev, unsigned int reg)
static struct bq27xxx_platform_data bq27000_battery_info = {
.read = w1_bq27000_read,
.name = "bq27000-battery",
+ .chip = BQ27000,
};
static int w1_bq27000_add_slave(struct w1_slave *sl)
diff --git a/include/linux/power/bq27xxx_battery.h b/include/linux/power/bq27xxx_battery.h
index e70a93a..a4efb10 100644
--- a/include/linux/power/bq27xxx_battery.h
+++ b/include/linux/power/bq27xxx_battery.h
@@ -3,7 +3,8 @@
/**
* struct bq27xxx_plaform_data - Platform data for bq27xxx devices
- * @name: Name of the battery. If NULL the driver will fallback to "bq27000".
+ * @name: Name of the battery.
+ * @chip: Chip class number of this device.
* @read: HDQ read callback.
* This function should provide access to the HDQ bus the battery is
* connected to.
@@ -11,8 +12,11 @@
* register to be read. The return value should either be the content of
* the passed register or an error value.
*/
+enum bq27xxx_chip { BQ27000 = 1, BQ27500, BQ27425, BQ27742, BQ27510 };
+
struct bq27xxx_platform_data {
const char *name;
+ enum bq27xxx_chip chip;
int (*read)(struct device *dev, unsigned int);
};
--
1.9.1
next prev parent reply other threads:[~2015-09-14 21:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 21:26 [PATCH v4 0/7] Add support for additional bq27xxx devices Andrew F. Davis
2015-09-14 21:26 ` [PATCH v4 1/7] power: bq27x00_battery: Remove unneeded i2c MODULE_ALIAS Andrew F. Davis
2015-09-21 8:33 ` Pali Rohár
2015-09-22 15:18 ` Sebastian Reichel
2015-09-14 21:26 ` [PATCH v4 2/7] power: bq27x00_battery: Renaming for consistency Andrew F. Davis
2015-09-15 8:32 ` Laurentiu Palcu
2015-09-15 16:53 ` Andrew F. Davis
2015-09-22 16:10 ` Sebastian Reichel
2015-09-14 21:26 ` Andrew F. Davis [this message]
2015-09-21 8:41 ` [PATCH v4 3/7] power: bq27xxx_battery: Platform initialization must declare a device Pali Rohár
2015-09-21 18:40 ` Andrew F. Davis
2015-09-14 21:26 ` [PATCH v4 4/7] power: bq27xxx_battery: Fix typos and change naming for state of charge functions Andrew F. Davis
2015-09-21 8:36 ` Pali Rohár
2015-09-14 21:26 ` [PATCH v4 5/7] power: bq27xxx_battery: Add support for additional bq27xxx family devices Andrew F. Davis
2015-09-21 8:46 ` Pali Rohár
2015-09-21 19:02 ` Andrew F. Davis
2015-09-14 21:26 ` [PATCH v4 6/7] power: bq27xxx_battery: Cleanup health checking Andrew F. Davis
2015-09-21 8:35 ` Pali Rohár
2015-09-14 21:26 ` [PATCH v4 7/7] power: bq27xxx_battery: Add interrupt handling support Andrew F. Davis
2015-09-15 18:47 ` Andreas Dannenberg
2015-09-15 20:53 ` Andrew F. Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442265973-32261-4-git-send-email-afd@ti.com \
--to=afd@ti.com \
--cc=dbaryshkov@gmail.com \
--cc=dmurphy@ti.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox