From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Lee Duncan <lduncan@suse.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Hannes Reinecke <hare@suse.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
Christoph Hellwig <hch@infradead.org>,
Tejun Heo <htejun@gmail.com>
Subject: Re: [PATCH 01/17] Add ida and idr helper routines.
Date: Tue, 15 Sep 2015 11:20:23 -0700 [thread overview]
Message-ID: <1442341223.2177.8.camel@HansenPartnership.com> (raw)
In-Reply-To: <915ec9ff5e9cc1fae0b36bf7d4c4cb115439e15d.1442263512.git.lduncan@suse.com>
On Tue, 2015-09-15 at 09:46 -0700, Lee Duncan wrote:
> Clients of the ida and idr index-management routines
> tend to use the same calling sequences much of the time,
> so this change adds helper functions for allocating and
> releasing indexes of either flavor, i.e. with or
> without pointer management.
>
> Inline functions added for idr:
> idr_get_index_in_range
> idr_get_index (in range 0,0)
> idr_put_index
> And for ida:
> ida_get_index
> ida_put_index
Every consumer of this I've seen seems to have the pattern of allocating
the ida and the protecting spinlock together. If that's the case, why
not move the spinlock into struct ida so it doesn't have to be
separately allocated and passed in to all the helpers?
Also, you need a cc of Tejun (added on this one) because he's the one
who last did significant work in ida/idr.
James
next prev parent reply other threads:[~2015-09-15 18:20 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 16:46 [PATCH 00/17] Create and use ida and idr helper routines Lee Duncan
2015-09-15 16:46 ` [PATCH 01/17] Add " Lee Duncan
2015-09-15 18:20 ` James Bottomley [this message]
2015-09-15 18:27 ` Tejun Heo
2015-09-15 18:38 ` James Bottomley
2015-09-15 18:41 ` Tejun Heo
2015-09-18 15:42 ` Lee Duncan
2015-09-18 15:49 ` Tejun Heo
2015-09-15 16:46 ` [PATCH 02/17] Update scsi hosts to use idr for host number mgmt Lee Duncan
2015-09-15 16:46 ` [PATCH 03/17] Update the st driver to use idr helper functions Lee Duncan
2015-09-15 16:46 ` [PATCH 04/17] Update the ch " Lee Duncan
2015-09-15 16:46 ` [PATCH 05/17] Update the md " Lee Duncan
2015-09-15 18:05 ` Mike Snitzer
2015-09-17 20:51 ` Lee Duncan
2015-09-15 16:46 ` [PATCH 06/17] Update the infiniband uverbs " Lee Duncan
2015-09-15 16:46 ` [PATCH 07/17] Update the memstick " Lee Duncan
2015-09-15 16:46 ` [PATCH 08/17] Update the mmc " Lee Duncan
2015-09-16 6:48 ` Ulf Hansson
2015-09-15 16:46 ` [PATCH 09/17] Update the virtgpu " Lee Duncan
2015-09-15 16:46 ` [PATCH 10/17] Update the DCA DMA " Lee Duncan
2015-09-15 16:46 ` [PATCH 11/17] Update the rtsx multifunction " Lee Duncan
2015-09-15 16:46 ` [PATCH 12/17] Update the TI Flash Media " Lee Duncan
2015-09-15 16:46 ` [PATCH 13/17] Update the SCSI disk driver to use ida " Lee Duncan
2015-09-15 16:46 ` [PATCH 14/17] Update the rsxx flash adapter " Lee Duncan
2015-09-15 16:46 ` [PATCH 15/17] Update the NVMe SSD " Lee Duncan
2015-09-15 16:46 ` [PATCH 16/17] Update the Micron PCIe " Lee Duncan
2015-09-15 16:46 ` [PATCH 17/17] Update the ARM soc base " Lee Duncan
-- strict thread matches above, loose matches on Subject: below --
2015-09-16 17:50 [PATCH 00/17] Create and use ida and idr helper routines [RESEND] Lee Duncan
2015-09-16 17:50 ` [PATCH 01/17] Add ida and idr helper routines Lee Duncan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442341223.2177.8.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=hare@suse.com \
--cc=hch@infradead.org \
--cc=htejun@gmail.com \
--cc=jthumshirn@suse.de \
--cc=lduncan@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox