From: Eric Curtin <ericcurtin17@gmail.com>
To: valentina.manea.m@gmail.com, shuah.kh@samsung.com
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: First kernel patch (optimization)
Date: Tue, 15 Sep 2015 20:53:28 +0100 [thread overview]
Message-ID: <1442346808-3784-1-git-send-email-ericcurtin17@gmail.com> (raw)
My first kernel patch, hope I did everything correctly! Instead of calling strlen on every iteration of the for loop, just call it once instead and store in a variable.
Signed-off-by: Eric Curtin <ericcurtin17@gmail.com>
diff --git a/tools/usb/usbip/src/usbip_detach.c b/tools/usb/usbip/src/usbip_detach.c
index 05c6d15..9db9d21 100644
--- a/tools/usb/usbip/src/usbip_detach.c
+++ b/tools/usb/usbip/src/usbip_detach.c
@@ -47,7 +47,9 @@ static int detach_port(char *port)
uint8_t portnum;
char path[PATH_MAX+1];
- for (unsigned int i = 0; i < strlen(port); i++)
+ unsigned int port_len = strlen(port);
+
+ for (unsigned int i = 0; i < port_len; i++)
if (!isdigit(port[i])) {
err("invalid port %s", port);
return -1;
next reply other threads:[~2015-09-15 19:53 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 19:53 Eric Curtin [this message]
2015-09-15 20:11 ` First kernel patch (optimization) Felipe Balbi
2015-09-16 0:09 ` Steve Calfee
2015-09-16 11:45 ` Austin S Hemmelgarn
2015-09-16 12:56 ` David Laight
2015-09-17 1:49 ` Jaime Arrocha
2015-09-17 8:45 ` David Laight
2015-09-16 13:24 ` Greg KH
2015-09-16 16:03 ` Eric Curtin
2015-09-16 16:40 ` Theodore Ts'o
2015-09-16 17:24 ` Raymond Jennings
2015-09-16 17:26 ` Josh Boyer
2015-09-18 3:12 ` Theodore Ts'o
2015-09-18 7:42 ` Greg KH
2015-09-18 9:31 ` Raymond Jennings
2015-09-18 19:08 ` Austin S Hemmelgarn
2015-09-19 2:26 ` Theodore Ts'o
2015-09-19 4:22 ` Sudip Mukherjee
2015-09-19 5:18 ` Greg KH
2015-09-19 12:20 ` Theodore Ts'o
2015-09-19 12:52 ` Alexander Holler
2015-09-19 14:14 ` Alexander Holler
2015-09-19 14:22 ` Theodore Ts'o
2015-09-19 17:47 ` Alexander Holler
2015-09-20 2:21 ` Theodore Ts'o
2015-09-20 10:41 ` Alexander Holler
2015-09-21 15:47 ` Austin S Hemmelgarn
2015-09-21 17:20 ` Alexander Holler
2015-09-21 18:41 ` Alexander Holler
2015-09-23 8:59 ` Alexander Holler
2015-09-28 6:54 ` Thiago Farina
2015-09-28 14:20 ` Greg KH
2015-09-16 20:02 ` Greg KH
2015-09-16 20:21 ` Eric Curtin
2015-09-16 22:38 ` Greg KH
2015-09-22 17:38 ` Linus Torvalds
2015-09-22 18:18 ` Eric Curtin
2015-09-25 22:06 ` Dmitry Torokhov
2015-09-26 13:28 ` Eric Curtin
2015-09-29 13:51 ` Austin S Hemmelgarn
2015-09-29 14:47 ` Eric Curtin
-- strict thread matches above, loose matches on Subject: below --
2015-09-15 19:52 Eric Curtin
2015-09-15 21:57 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442346808-3784-1-git-send-email-ericcurtin17@gmail.com \
--to=ericcurtin17@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=shuah.kh@samsung.com \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox