[PATCH] misc: hpilo: Add mini and max value of module parameter in description

[PATCH] misc: hpilo: Add mini and max value of module parameter in description

[Masanari Iida]

This patch add minimum and maximum value of module parameter
max_ccb in hpilo.c.

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
---
 drivers/misc/hpilo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/hpilo.c b/drivers/misc/hpilo.c
index b83e3ca..d45cff0 100644
--- a/drivers/misc/hpilo.c
+++ b/drivers/misc/hpilo.c
@@ -906,7 +906,7 @@ MODULE_AUTHOR("David Altobelli <david.altobelli@hp.com>");
 MODULE_LICENSE("GPL v2");
 
 module_param(max_ccb, uint, 0444);
-MODULE_PARM_DESC(max_ccb, "Maximum number of HP iLO channels to attach (16)");
+MODULE_PARM_DESC(max_ccb, "Maximum number of HP iLO channels to attach (8-24)(default=16)");
 
 module_init(ilo_init);
 module_exit(ilo_exit);
-- 
2.6.0.rc2

RE: [PATCH] misc: hpilo: Add mini and max value of module parameter in description

[Altobelli, David]

That works for me, if it helps people understand what's going on.

I need to change my email from @hp to @hpe.

-----Original Message-----
From: Masanari Iida [mailto:standby24x7@gmail.com] 
Sent: Wednesday, September 16, 2015 10:32 AM
To: arnd@arndb.de; gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org; Altobelli, David
Cc: Masanari Iida
Subject: [PATCH] misc: hpilo: Add mini and max value of module parameter in description

This patch add minimum and maximum value of module parameter
max_ccb in hpilo.c.

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
---
 drivers/misc/hpilo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/hpilo.c b/drivers/misc/hpilo.c
index b83e3ca..d45cff0 100644
--- a/drivers/misc/hpilo.c
+++ b/drivers/misc/hpilo.c
@@ -906,7 +906,7 @@ MODULE_AUTHOR("David Altobelli <david.altobelli@hp.com>");
 MODULE_LICENSE("GPL v2");
 
 module_param(max_ccb, uint, 0444);
-MODULE_PARM_DESC(max_ccb, "Maximum number of HP iLO channels to attach (16)");
+MODULE_PARM_DESC(max_ccb, "Maximum number of HP iLO channels to attach (8-24)(default=16)");
 
 module_init(ilo_init);
 module_exit(ilo_exit);
-- 
2.6.0.rc2

[PATCH v2, 1/2] misc: hpilo: Add min and max value of module parameter in description

[Masanari Iida]

This patch add minimum and maximum value of module parameter
max_ccb in hpilo.c.

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
---
 drivers/misc/hpilo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/hpilo.c b/drivers/misc/hpilo.c
index b83e3ca..d45cff0 100644
--- a/drivers/misc/hpilo.c
+++ b/drivers/misc/hpilo.c
@@ -906,7 +906,7 @@ MODULE_AUTHOR("David Altobelli <david.altobelli@hp.com>");
 MODULE_LICENSE("GPL v2");
 
 module_param(max_ccb, uint, 0444);
-MODULE_PARM_DESC(max_ccb, "Maximum number of HP iLO channels to attach (16)");
+MODULE_PARM_DESC(max_ccb, "Maximum number of HP iLO channels to attach (8-24)(default=16)");
 
 module_init(ilo_init);
 module_exit(ilo_exit);
-- 
2.6.0.rc2

[PATCH v2, 2/2] misc: hpilo: Change e-mail address from hp.com to hpe.com

[Masanari Iida]

This patch changes maintainer's email address from
hp.com to hpe.com in hpilo.c.

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
---
 drivers/misc/hpilo.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/hpilo.c b/drivers/misc/hpilo.c
index d45cff0..d6a901c 100644
--- a/drivers/misc/hpilo.c
+++ b/drivers/misc/hpilo.c
@@ -2,7 +2,7 @@
  * Driver for the HP iLO management processor.
  *
  * Copyright (C) 2008 Hewlett-Packard Development Company, L.P.
- *	David Altobelli <david.altobelli@hp.com>
+ *	David Altobelli <david.altobelli@hpe.com>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 2 as
@@ -902,7 +902,7 @@ static void __exit ilo_exit(void)
 MODULE_VERSION("1.4.1");
 MODULE_ALIAS(ILO_NAME);
 MODULE_DESCRIPTION(ILO_NAME);
-MODULE_AUTHOR("David Altobelli <david.altobelli@hp.com>");
+MODULE_AUTHOR("David Altobelli <david.altobelli@hpe.com>");
 MODULE_LICENSE("GPL v2");
 
 module_param(max_ccb, uint, 0444);
-- 
2.6.0.rc2

Re: [PATCH] misc: hpilo: Add mini and max value of module parameter in description

[Masanari Iida]

On Fri, Sep 18, 2015 at 5:52 AM, Altobelli, David
<david.altobelli@hpe.com> wrote:
> That works for me, if it helps people understand what's going on.
>
> I need to change my email from @hp to @hpe.
>
Thanks for the comment.
I sent another patch to change all @hp to @hpe in hpilo.c

Masanari

Re: [PATCH v2, 2/2] misc: hpilo: Change e-mail address from hp.com to hpe.com

[Greg KH]

On Fri, Sep 18, 2015 at 12:32:13PM +0900, Masanari Iida wrote:
> This patch changes maintainer's email address from
> hp.com to hpe.com in hpilo.c.
> 
> Signed-off-by: Masanari Iida <standby24x7@gmail.com>
> ---
>  drivers/misc/hpilo.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

I'd like to get an ack from the driver author before accepting something
like this...

RE: [PATCH v2, 2/2] misc: hpilo: Change e-mail address from hp.com to hpe.com

[Altobelli, David]

-----Original Message-----
From: Greg KH [mailto:gregkh@linuxfoundation.org] 
Sent: Sunday, September 20, 2015 9:29 PM
To: Masanari Iida
Cc: Altobelli, David; linux-kernel@vger.kernel.org; arnd@arndb.de
Subject: Re: [PATCH v2, 2/2] misc: hpilo: Change e-mail address from hp.com to hpe.com

>On Fri, Sep 18, 2015 at 12:32:13PM +0900, Masanari Iida wrote:
>> This patch changes maintainer's email address from hp.com to hpe.com 
>> in hpilo.c.
>> 
>> Signed-off-by: Masanari Iida <standby24x7@gmail.com>
>> ---
>>  drivers/misc/hpilo.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)

>I'd like to get an ack from the driver author before accepting something like this...

Sorry, wasn't really sure if anyone needed that (sorry about formatting)...

Acked-by: David Altobelli <david.altobelli@hpe.com>