From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752014AbbIQTUc (ORCPT ); Thu, 17 Sep 2015 15:20:32 -0400 Received: from mail-bl2on0146.outbound.protection.outlook.com ([65.55.169.146]:31092 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751904AbbIQTUa (ORCPT ); Thu, 17 Sep 2015 15:20:30 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Message-ID: <1442517622.19102.59.camel@freescale.com> Subject: Re: [PATCH 1/2] memory: fsl-corenet: Fix module autoload for OF platform driver From: Scott Wood To: Luis de Bethencourt CC: , Santosh Shilimkar , Wolfram Sang Date: Thu, 17 Sep 2015 14:20:22 -0500 In-Reply-To: <20150917174145.GA29275@goodgumbo.baconseed.org> References: <20150917174145.GA29275@goodgumbo.baconseed.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.0-fta1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [2601:448:8100:f9f:485b:31af:11cc:cd8b] X-ClientProxiedBy: BLUPR14CA0083.namprd14.prod.outlook.com (25.163.209.179) To CY1PR03MB1487.namprd03.prod.outlook.com (25.163.17.17) X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1487;2:hM9pcDJIGIOi1s5CFSKM5ypkPIk4ELHShVi7PsZ9LE9e4zk+gF9JxNP0y20B21DU1Vp4r6C/tPsu9HThjN33ivktVP5bjhRBO1H1gSTwthqA88vFYguYXGkvtv7FaFKJAwPFyCiZJi25ft90/yiAnBuzE9iXL5QpkA8lrho10ec=;3:Kl6lsXY6yqr5Vys/KJpFzs3IU9VXlTgpeVW4ayS7zolD5Z361dx1PU70Kq0rRGiRRVe8SzmWFoZNcRc5kDqRJhYJCwAoCtxZnjlf59xP5QLMwwaIVPxfzaPpigr0c9cDZU68e7oVV4PWQT97n842HA==;25:EOjVFS1NXn5xjn/uE2+jK1Z8u7KT0TDlfVKIq6laegCU8L3me62Uwj0xn84y+boZ5bCjGnyiKXFkcyW35x2iEkukY/75gqWkRBIaisfkIRJy8EpunMDRw5+f+IAq5dVDuej/n1eCOygdrJ7x32Vj/WvTH6OxhA0pqdHXktZLEIoL7EY2WCWGo12EyYFIUbTJpjOG1f22fLdbce8558bOWcrkf2tA077KVpM/d3dte9h11dHOq1IVlk0Uf3I2//iV+N24Wny/U1rq1FlItWiSDg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1487; X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1487;20:KUolKCzyJL08nD2YOXgZNTXo4HOESia6qOJ3wAOtz3HW7AaK0TVHDqqN6POTqh3aeYyZGwAoSnTrdId/8aAPsHXcJtulE9Rb6ApL8XAxRPeSJHc0yg+sK/cNe16t4vDJfwjIieGKqVDmwMnklrerYFheZ4mxIYHrhj0nAkLJK7OcHObIj8Aa5zgtSGNquhnaqOExShryJxe9uFBgdom6D5ZMRiqDugO/5LVymQ9sDAXsbhExT9qfhIzYUQL+Z9tDu0fBIX40kRmBOOLwW6KddRQJoLAXpcQNzufbk/srSg5VSCqyCOqkRDg3Ih/kqRSGFZuvuuKizhIl6j7B3aHXHAtkEDY/+AWqQl2sd/TMwF0Z3LnljqmLBUXhqJ2zH3RSilXyfJI2Ee33mxS53Qrl70UwAhhoKTMG4IDvvjvzyvOEwTdg6+43PrPu147ASqsuDcexW6u0A3x3gOvkN+hMZEF2dNwTtajpsRV85SzXOtRPGfOsMf05PtuWm8e9aDlo;4:bLKHtAFoo7mR/tNSTNup5mo0YFVroivRMgb5FQjae1TQYK8gax7PRr+YvgN3mKQEmupSHOwLOrPccWevPFGiqmtjHWphV0SZscPXGz+NlgxS6CKy4xUiXGWNRUP7VmBafWGhZGMP62PLThNYPwX20kPCGu0wEiWdQtK93F6vBE9SyjsSkCqYpec7r8hvrZAcgiMfK6xYM8Vh0PpfBCOwJYgjQWrj7tBBiL4rDJy+IxPHBxuLJ3uc92rchdQRhmFK9+WhBQT39W1tm9E/wWDR2Lt4biTm3VxovU3jHKmdBOxzFj+nyGFs2N4y5hAW43uwPvJ6KkbiD594FywVQ8Z+lSeaCaravDCeSVfim1Ii1FOvIUuHW2vODuym2ZEqJbrg X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(8121501046)(520058)(520078)(5005006)(520075)(3002001);SRVR:CY1PR03MB1487;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1487; X-Forefront-PRVS: 07025866F6 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(189002)(24454002)(199003)(377424004)(101416001)(4001540100001)(103116003)(110136002)(5001860100001)(77156002)(2950100001)(122386002)(5820100001)(92566002)(50986999)(189998001)(81156007)(77096005)(68736005)(87976001)(62966003)(36756003)(46102003)(40100003)(23676002)(76176999)(106356001)(86362001)(5007970100001)(5001830100001)(33646002)(50226001)(42186005)(105586002)(50466002)(19580405001)(5001960100002)(5004730100002)(64706001)(97736004)(19580395003)(47776003)(99106002)(3826002)(5001840100002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR03MB1487;H:[IPv6:2601:448:8100:f9f:485b:31af:11cc:cd8b];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjAzTUIxNDg3OzIzOkdYcGpCQTc4MHk3ZDk4Q3VXQ09mSWZPbzF3?= =?utf-8?B?MzZSQU1VUzhlYXpJdHJQUklyeFhhT2NYSWpKc1NFZUY1dnFnaGdXTTZ1UDhY?= =?utf-8?B?ejUvcUk1UzQ2czVjdUJXWWg5TTdaVWlZckQwN1ozam5JUHVhb1FVZzRMaC9i?= =?utf-8?B?K1ZDVmJqTWRZMzdoVVBTRTB1NU9SQlcvU0MzK2w4ODRRc2ZmQXB4UEcrMVAw?= =?utf-8?B?OU91Mld0S2llbXhNbGNEU1lpdWVqZVhyYUZpTGlPeDNRa2FrTUFuKzM2S2VZ?= =?utf-8?B?Z3JrbVRvRVVmcGg3SWVKakNtMjNSUWRTR1hoMlF0VE90L3pyMnVBcmN4ZnZD?= =?utf-8?B?dW5BRDIyY2w3L05vM2p1UnB3R3lLWGdISElNeVBXcFZaOHRCM2NVUjBPbk9K?= =?utf-8?B?c0pOcWdONzZwc3BscnlpVHE3NHEwVXQxTkd4aE9CbmxHa0RTMmkwbjhpTTVa?= =?utf-8?B?eUdQK0ZwNDloSVFrSVBzUVY2ZmdvSW85V1VwQkRJV0VkZTNVM2xxYUhjTTRz?= =?utf-8?B?MUpiazBlMnFqMVBqTlRtQU9Dd1Iyb0hCd2RxKzZiRlU1OTVTYkJqVFFkQk9s?= =?utf-8?B?cDdUN1pGMDRPQm1QeWg5RWg0SThwNkRIaGJjY0x6Uk15VUlEcFlGckdpRXhB?= =?utf-8?B?b1JLaVNLOVlSbkF5MHVqYU9EamNHcWk5UzBvVzhKTFlhM0lvNW1ySkY5eTFY?= =?utf-8?B?SEQ2M3BueGp5aUV2NXZGVHlWcjBHZ2toWTF2M0p2M29zcy93UEpLRTFnM2pk?= =?utf-8?B?d3V2cUFId3VteCtCSmhTKy9vYjNRR1p2TlR2NFJsUCtKenRXempDSmd6U09R?= =?utf-8?B?eDVpcGRUaFlhQVpNdm9YdFRWeHhmajZyK2EvK2ZJS0pmNUtPMnpZQW1hV3A2?= =?utf-8?B?WG16MEMxOXpDaEk3bjRKK2tMbnduNVdhTzlaanlDeEV3NVphcjJzNkxzZ2lW?= =?utf-8?B?c2UybEowb0Z4QUpTaFVPNG1QSlN4SzFBaEJJWTVDWGF6RmVDbXBIdGlKa3c1?= =?utf-8?B?R1owdHR6d3pvazkweHp4Y1VSSnNuVGNVUzFYR1lLTU1TdCtNZCsyK1FuQjNk?= =?utf-8?B?dVdJUnhVWXZoUHdlQnFvS2QyK3dlb1BweFI4a2lyV05rdU5xblBNdUYwUHYv?= =?utf-8?B?TXhxYVlnK1RxamJjVGhHNVlLaHRBbURsVG5Yc1hYb0krN0ZpSCsveTdiaHpj?= =?utf-8?B?am01RDFQZFdaSnBCOTVVYkxPc1NKWGhaY3Q5TEF4L2hDSGVaMTdaRUZuZy9J?= =?utf-8?B?QkxDOFRwd0lVWDhFdHlyVUYvOUp1Y1Urc0dXc3VWZmwvSkFJSUVwNW1xRzVY?= =?utf-8?B?Si8wcm03emRmOWFoVjVvS2V6U2t6Q20weWxEb2hRUWZza2NuWWRvVTVDd093?= =?utf-8?B?bEFqSUZjMnhkQVdLQkxxYSsvREdNemNadWdteWdvSG5tMmtRK2RaWDV2TnJG?= =?utf-8?B?bFRjdTJJY0RWWGw1emt6M0FONWd6dmk3ZmhtVHRPYUdnVjZWdmJFNVFNdlFO?= =?utf-8?B?RzNrQlpZRmRxY0ZQSnpFdEZvNzJJL2U2VitidDQ3bXZ6Tks2cXdvc25uRmg1?= =?utf-8?B?THN4QVZCaUhJVk1LWUhmZndZdEtkS2FPVHlnN25KaUJTVmU1cS9UaGhkWnNi?= =?utf-8?B?MjlTQmpKN1J1MU44Zk01Rk00V0JFN01qeHJuNE1OZGZZeWJlaUt1WE5NVlVP?= =?utf-8?Q?1v6F6TOTp4armrWJ6Q=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1487;5:dKnGeLcjM7X7Oynj34tPq1tb0Rt2I58/FVfnL0hSHoaqyUAc0KV//o39cjmb2GOAebNh9MVZ8cjXGWVxVYukQIjiYkIRvDiOnzR12UEnPfHZTWnq9AYUnqQYMA51nqQAoX2F07ymlL6HgovQp8xkSQ==;24:vPAq8/NAYJBArpOCPoRpv9bsyx/M1dEQWpobOukJ5fYhUB5894J+lFeHVNwdgm08Drx7eudvihaJTkKIOuvC2ubGDl7VlrUwiWAmY2r8n+Y=;20:FGHQhwLuj5Cr9A+ZsytrIbDzPDTb9dCMfLuAHQVpJyRCNX8xHGQW8bH4qlL34Ay3IvmK3hZcU6FC6jJmEjJUaw== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2015 19:20:27.9276 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1487 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-09-17 at 19:41 +0200, Luis de Bethencourt wrote: > This platform driver has a OF device ID table but the OF module > alias information is not created so module autoloading won't work. > > Signed-off-by: Luis de Bethencourt > --- > drivers/memory/fsl-corenet-cf.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/memory/fsl-corenet-cf.c b/drivers/memory/fsl-corenet- > cf.c > index d708ded..662d050 100644 > --- a/drivers/memory/fsl-corenet-cf.c > +++ b/drivers/memory/fsl-corenet-cf.c > @@ -61,6 +61,7 @@ static const struct of_device_id ccf_matches[] = { > }, > {} > }; > +MODULE_DEVICE_TABLE(of, ccf_matches); > > struct ccf_err_regs { > u32 errdet; /* 0x00 Error Detect Register */ Acked-by: Scott Wood -Scott