From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752555AbbIRASp (ORCPT ); Thu, 17 Sep 2015 20:18:45 -0400 Received: from mail-bn1bn0103.outbound.protection.outlook.com ([157.56.110.103]:22290 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751929AbbIRASn (ORCPT ); Thu, 17 Sep 2015 20:18:43 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Message-ID: <1442535513.19102.83.camel@freescale.com> Subject: Re: [PATCH 02/26] clk: Replace __clk_get_num_parents with clk_hw_get_num_parents() From: Scott Wood To: Stephen Boyd CC: Mike Turquette , , , Boris Brezillon , Chao Xie , Krzysztof Kozlowski , Javier Martinez Canillas , Tomasz Figa , Maxime Ripard , Emilio =?ISO-8859-1?Q?L=F3pez?= , Tero Kristo , Geert Uytterhoeven Date: Thu, 17 Sep 2015 19:18:33 -0500 In-Reply-To: <1438362246-6664-3-git-send-email-sboyd@codeaurora.org> References: <1438362246-6664-1-git-send-email-sboyd@codeaurora.org> <1438362246-6664-3-git-send-email-sboyd@codeaurora.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.0-fta1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [2601:448:8100:f9f:2d70:bd3f:bb1b:9b2b] X-ClientProxiedBy: BN3PR11CA0009.namprd11.prod.outlook.com (25.162.169.19) To CY1PR03MB1487.namprd03.prod.outlook.com (25.163.17.17) X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1487;2:6q8XUnAwkKlsocOpf0IbkDg4f6HlHbzP1N1Y9bxF15j4It+wcuUNtCSwbk4dPF8nMSaaxXnJVdeY0RO87wsO0/5AIFM5PcyakxbLJQ3IwOtjJQJyyuwQvu6DgIqdUCrW+jCiCSRzUBXVkwm6UacR8r/3CiyVTXs2LiB8D3x/0pE=;3:OLJnZL0pE6+8Wc9W/dNxTV5+gKo7cBS4yGnhUssxGBHlZevcQmKT0D5Ot8fQUMUQeogyYDcgG8SSoPE+Dglqmp/3N2/SgcpoCBjR6yXLp12dDBokuGAPxLASsUY72qnq1oxt7rnsBWXXNp2BC9J3og==;25:rV1pb0cbBsPs+eb3pTPfe8P8ftgDqslWeCP8sLnUcjOE7vLSym2g9kY4OUL7nsIGGwOucab08l4efUQL8OdG7viVxHDXfkcbzmads5yQgN4sXTW44MBgLt7Ev+lTOiH9YWWNELmjEthzmCoccLNe8HPta+vVFbHEMnPWoyBuK+kBBAfqQWrwRreglm5w9wCCFpzgVQhjbtWwXNFvb14K/X3BVVKacEl9ocDcZeYQ8x8cTL6tv6Rf7XvNsyniveQhMki0wsXeYKJ2t1svScv+Aw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1487; X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1487;20:3NmU62mnt/HI4n14OI4oOAvtgd7JgA41gb/bu4Aa5kcVvbx3Suyyz2wynkmcmK1gXtE+yPPR/XDUBTrA5wU7EpaapDtIjXdT0w+JN1MekNsHPhc/W7a8ppPNNSX03vTJ9EV+FUU6sLeM1O+Y5+5T2B+o2iYeYC86b1Yi899oMJ49G2gIA0jLLf6CWisAWo2Ea+1CjriregcdW3KYkD4cLlyy6BAn46QqvTx1BzSZHWMQJUBfkr5B1RJvfzYLcCTeZDNod1XfJJM1L63+4xFnd+71POBLo7XpCw8CYv+gBPJRE5B/YD4P9U51AvT932ZOruAmHUcLVzKxotuVjIv1a1DkgUX7Sww3tTK1qtlaitExrGmWjW/XINcnadhyCfaiUOQa08PIlU417Sp0R0MJZFbLcF+TpY27LvZhiZQid05V6Zuag0qMkjewHQKU85HNHl7d/1mnlRgGfOl2+0eKz/glQNdaS5pxwTTn6WowX1D5iXtMhrZQ0q8e/ZLt3K40;4:A9SfW6pDLBzZGr3twFMfqnRmCEwuEsunRmWPWSzMpuxxAciSNMMGWOSxEQLlNhPnHC9AiQmHekWSSdYq2BOysI6hiCRsTlRTk06IWX4vJVWuQmsqD/6K5U8IBvm6uGbGpaOE+e7oXrp9NMLHQQEerhdAxAg4MVHueTvxE8IZE0uPQDqUBayMVVIyNgkAvUkFobaj8ljuPeNoRG7ZZ0F2weC7QsAKgUUYcLdkE9TEZ9MtmW6oDr5zpLsBTRaDq1H6TefAcE3DdGIgO0SPq5cWGtbOUQ6R9RQHcTTlMOfHN6Swoj63FkTxlZWg9bAHVjJiDWZHkcSCK7O/AUVhtKLSIC2pH0aMWFUD1l9igAHkd/dTYZdeMD62BmO37EywJJSl X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(520078)(520058)(8121501046)(5005006)(520075)(3002001);SRVR:CY1PR03MB1487;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1487; X-Forefront-PRVS: 0703B549E4 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(24454002)(189002)(199003)(377424004)(40100003)(103116003)(4001540100001)(101416001)(5001860100001)(15975445007)(2950100001)(122386002)(110136002)(77156002)(92566002)(5820100001)(189998001)(50986999)(77096005)(81156007)(87976001)(62966003)(68736005)(36756003)(46102003)(23676002)(33646002)(106356001)(5001830100001)(86362001)(5007970100001)(105586002)(50226001)(42186005)(50466002)(5001960100002)(5004730100002)(64706001)(97736004)(19580395003)(47776003)(76176999)(99106002)(3826002)(5001840100002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR03MB1487;H:[IPv6:2601:448:8100:f9f:2d70:bd3f:bb1b:9b2b];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjAzTUIxNDg3OzIzOi9wY1NFQ2FXM2dEZzVuOG9wd2NGYjdzUFNH?= =?utf-8?B?NEt4RTkvbHZiK3piaGllQldtZC9xTXFsTUZySDN0SDFGaHBWL3hobmU5Sy9E?= =?utf-8?B?dmRQSkt4WjBQOTZGamV5OWxJZERDR1poNjlqR2pHR05yMENTL01mVGVVYU9X?= =?utf-8?B?WVVSZEh5YW10aFdOVjN4M3BkVldJT2xQQ3BsMENkbkxCZW5ySjdXdWRSV3dO?= =?utf-8?B?NHlPZDVEaVEvaWdPZEN1MXp6SU1TUU41dnkzaFhDQkN2UjhCZ2wvNFRiQW9G?= =?utf-8?B?R21INlBsSlhFOUxWWXpKcWkrV3RJdjJLUWtFRER4RTVTaXo5U2hRLzI3Nzcw?= =?utf-8?B?VTA2VmtxVVUxZFFGc2E4bmZTcWM2ZUp1cmtxbGdJUnVLWWt4eHBEdUlGQmlv?= =?utf-8?B?eGMxMjJGYzg0ZVlUOUQxQkViRjAxTGZicThHdDdvSGVzdHpBYlY4bDRQc1hi?= =?utf-8?B?NzVOTUlLcDhoTUZIeUpKME9QTjIrMVpoWktBam9kL3NMeEppcnh3S3Zkakxj?= =?utf-8?B?T2Zzak5qWUM1V21hRDU0QllWMTM2aE53L3lqZlpKdVplK1Y2eWZFaVV4c3BW?= =?utf-8?B?b2x4Q21URFJ3ZDFKZlFTdkk3ZjViTzZGVFc3MzQ5TWlvbzRtQVlqV2NPM0VQ?= =?utf-8?B?OUgzQ1gwZ0M3R2Nab3VBZmplNzJiUURjeW56UkE0ekFyb3c0QmliT200YUlE?= =?utf-8?B?cnpSQXpmRHFsNWo5UGdlWkN3VCtnK0xlMGlOQ2JXZVJPQnZxVGVVZ2Vtb2ty?= =?utf-8?B?dmZPSDVYTFlCRERMcU1YTStpa21nS2pzY3N4UFl3dWJhTndDZWw2SStpRXlP?= =?utf-8?B?TkN4U3ZaV3doMUV6U1ViOFg3andzdmtUeHczeTJDTjRXOTRzdkt0NlRPaEI3?= =?utf-8?B?dVdDckx4YTFTdVNYb0pEdmhRSUp1YktWdSs2N29VV3grVkJwTGpzZGVJcTMr?= =?utf-8?B?Q2hUcXhzRFExNXM3VWE2dnJXZHZqcHFjYkVVUXVJZWxPcFZxdjRHNVhpYUNj?= =?utf-8?B?aVpLdTIyUHU4RFVkRVpWb2gzalpBdkN1aDlmWU1LbnpLcGtjc1RhbGZsMWVy?= =?utf-8?B?T3hScFk1YTg1aE8xRUNGWWxERGhEeHlMbVZUaGwrdytBZit3b2RneXl4VGZC?= =?utf-8?B?NXdDRysvQWNvTFIwTFAxY3dLcjV5bEthTUtsK2w5K0FyamkzRTZhaEszNWhP?= =?utf-8?B?ZmprOW9GQ3ZpUllDMmtmblpTdmcxUDFWMnZIays3TmUwb2swYVMyQTVKTGJU?= =?utf-8?B?Nm1XSUNNYUxsaUF1Z2RMZkVnNUp5M2o0MW9kZjNSbWlmRXdpRnoyZms5ZUhG?= =?utf-8?B?R3p3UngvVElab3RZSmRlN0pnRGkyWXZTU1QyNDdqM3Q2ZW1oRDB5ZU9KUGpS?= =?utf-8?B?RzExWXRGajBwT3dkeCtwdHJxTVRwcTlWNlhUWllTYklKMGZJZkJoT1ZBckp6?= =?utf-8?B?NmdjYlVqR1BSUWpVOFFRSWhrV1AwbzJmQUdpUHZqZkkzclcyTC9tSFRJTWdF?= =?utf-8?B?c3dsM1pGVkNUNWwxR1Q0bWdWNVJqVFBGTVBsc3VDTDlRdFdPWUZQczZTUnlT?= =?utf-8?B?NFpZalNxVktIbm1aYjRFMHV2bzdJcGxiczA4N0Zac2tXQkY4OEkrTkViL3lj?= =?utf-8?B?aFpOQmN4TU5QVTEvT1c5NWhZVmNoYXZzSVNCZmRac1ZzZWdsR0xvaE5oQjNW?= =?utf-8?Q?pVJL3tJVpYeJcRnytM=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1487;5:aROUs0pi/0T3AgPBaaGj8BGxepoMUSzlyPJp5Zay4pqqHYy7FItVNafGCd0ZuU2U/GXZWdACAbiGoVHKChixXED+FHQbWJdWwAr1j64Du+SuDSzN7roRMR/J5+QO5N5sC4jCJ6NT9if/E/Dndt+3VQ==;24:8knCQJUfAr/9XAsug+Kpl1egz4z9J+pHtD+36kjx8mKarLWtRW9h+lGUsM9v5IP6fd0yWCXz8Re0CdJcfFM6aieuv0H8QRbm4knA7iputQE=;20:wsVeyonpYSAICxQ/O60rqB8nb1qC5cf3GbQDoyczP3HI5bvMr3DHbCWxHSQPWl7chBWeQpfbX/bR7rM4AUgA/A== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2015 00:18:38.8917 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1487 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-07-31 at 10:03 -0700, Stephen Boyd wrote: > Mostly converted with the following semantic patch: > > @@ > struct clk_hw *E; > @@ > > -__clk_get_num_parents(E->clk) > +clk_hw_get_num_parents(E) I don't understand why this is considered a clock provider API. How is a clock consumer, such as cpufreq, supposed to find out the number of parents or similar information, so that it knows what its options are for calling clk_set_parent()? This is the caller I had in mind: http://patchwork.ozlabs.org/patch/507619/ Surely asking the clock to describe itself is better than what that cpufreq driver currently does, which is to look in the device tree and make assumptions about how that maps to what the clock provider driver does... -Scott