From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753288AbbIRJvB (ORCPT ); Fri, 18 Sep 2015 05:51:01 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:32784 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753059AbbIRJu7 (ORCPT ); Fri, 18 Sep 2015 05:50:59 -0400 Message-ID: <1442569855.13652.1.camel@ingics.com> Subject: [PATCH] nvmem: core: Handle shift bits in-place if cell->nbits is non-zero From: Axel Lin To: Srinivas Kandagatla , Maxime Ripard Cc: linux-kernel@vger.kernel.org Date: Fri, 18 Sep 2015 17:50:55 +0800 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It's pointless to test (cell->bit_offset || cell->bit_offset). nvmem_shift_read_buffer_in_place() should be called when (cell->bit_offset || cell->nbits). Signed-off-by: Axel Lin --- drivers/nvmem/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index d3c6676..c39723a 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -825,7 +825,7 @@ static int __nvmem_cell_read(struct nvmem_device *nvmem, return rc; /* shift bits in-place */ - if (cell->bit_offset || cell->bit_offset) + if (cell->bit_offset || cell->nbits) nvmem_shift_read_buffer_in_place(cell, buf); *len = cell->bytes; -- 2.1.4