From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755205AbbIRP54 (ORCPT ); Fri, 18 Sep 2015 11:57:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48522 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754188AbbIRP5y (ORCPT ); Fri, 18 Sep 2015 11:57:54 -0400 From: =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= To: linux-kernel@vger.kernel.org Cc: kvm@vger.kernel.org, Paolo Bonzini , Marcelo Tosatti , Luiz Capitulino Subject: [RFC PATCH 0/2] kvmclock: fix ABI breakage from PVCLOCK_COUNTS_FROM_ZERO. Date: Fri, 18 Sep 2015 17:54:28 +0200 Message-Id: <1442591670-5216-1-git-send-email-rkrcmar@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch series will be disabling PVCLOCK_COUNTS_FROM_ZERO flag and is RFC because I haven't explored many potential problems or tested it. [1/2] uses a different algorithm in the guest to start counting from 0. [2/2] stops exposing PVCLOCK_COUNTS_FROM_ZERO in the hypervisor. A viable alternative would be to implement opt-in features in kvm clock. And because we probably only broke one old user (the infamous SLES 10), a workaround like this is also possible: (but I'd rather not do that) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index a60bdbccff51..ae9049248aaf 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -2007,7 +2007,8 @@ int kvm_set_msr_common(struct kvm_vcpu *vcpu, struct msr_data *msr_info) ka->boot_vcpu_runs_old_kvmclock = tmp; - ka->kvmclock_offset = -get_kernel_ns(); + if (!ka->boot_vcpu_runs_old_kvmclock) + ka->kvmclock_offset = -get_kernel_ns(); } vcpu->arch.time = data; Radim Krčmář (2): x86: kvmclock: abolish PVCLOCK_COUNTS_FROM_ZERO Revert "KVM: x86: zero kvmclock_offset when vcpu0 initializes kvmclock system MSR" arch/x86/include/asm/pvclock-abi.h | 1 + arch/x86/kernel/kvmclock.c | 46 +++++++++++++++++++++++++++++--------- arch/x86/kvm/x86.c | 4 ---- 3 files changed, 36 insertions(+), 15 deletions(-) -- 2.5.2