From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932601AbbIUUBO (ORCPT ); Mon, 21 Sep 2015 16:01:14 -0400 Received: from mail-bn1on0147.outbound.protection.outlook.com ([157.56.110.147]:22816 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932502AbbIUUBN (ORCPT ); Mon, 21 Sep 2015 16:01:13 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Message-ID: <1442865662.19102.172.camel@freescale.com> Subject: Re: [PATCH 2/4] powerpc/device-tree: bindings for DSP cores/clusters for Freescale SOCs From: Scott Wood To: Aggrwal Poonam-B10812 CC: "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "devicetree-discuss@lists.ozlabs.org" Date: Mon, 21 Sep 2015 15:01:02 -0500 In-Reply-To: References: <1442686567-14320-1-git-send-email-poonam.aggrwal@freescale.com> <1442708128.19102.147.camel@freescale.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.0-fta1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [2601:448:8100:f9f:d9a:aaef:168d:e441] X-ClientProxiedBy: BN4PR15CA0021.namprd15.prod.outlook.com (25.164.54.159) To BY1PR03MB1484.namprd03.prod.outlook.com (25.162.210.142) X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1484;2:KhqoiHGcSXD/3/I175UEt7JX+fieWwsqBIgs3ZTQoO7FU/ekg2tfmzOFwuCtL1cTuFbil7aI2hkLYpE3SXxsDyShq5wr9gqj1J3BNvfv6jDJF7WhqwNii3Hxy7D4Hs5T0CG+sTvqw8ekfay5qXNFFTowX+FxIjhSQKUmkxBpGmY=;3:zn3VoYCl3fHnpOCZG4tuSAOnnsX/bsGWjct2MQFlv6MFU2fz27EyaNHJ8+RmM1jQuhyPV9QLpmfBi5Y5pUeFPry3ZjuGunK3Ovf1umD4UtA1nxV8ipgMefSO7gx6Q3b2JKYa3pA67j97zhX8MRpijA==;25:WN0rnW65QI5vSKcuXZpzm+LtRUMnbZDz7z4tfv+oIWSTvIcsqoqPkXwqncOI+E8fOxlJMNB0BQlQe4kpY4idBODzvsVuxc13z2Hhqeaz+GMDivxDivFPQEGtUANgfhZqLNohVOXhh5Zh/0ZHYaB/eQ/fFMGCC9DJc4aJPHQfCA/8oaCkcVqYyoYL1Jl0gV1avwEcblSjQh0ysntPy+IHdifgU7K65WCuwz5RlUOVIhJtAuHazaYR87s3c0sQQ7WMvQbYxhlGm3mAq41s5lowVg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1484; X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1484;20:3n+GoAD8UAGTYUDcV4rLQMkznKB3f2aBu0fcdAU+8TLF3bTrrLTKngFnvdA16E+wCRmykBgrB16546pvJRedXcqrKYRROVC9KJJx+NOSanfaYop0O7+wy28O8eOxxX3RCNqzMNh7i/SdrTEZ0SFYAGiDZvoEK0ZWu2xsAXYgfTE/qNXIJN6rXOSiI1z74ZosRbIzDQzugHKYFtccRJbVg8aL8epvNnAc4fwjpM/wOwyUHlVX3yWzK5hRT0QxKDw/SXg539dzaqdpoUgWeEGukfG9UibaN4AyLB020LwAWon10jvOuiSGFcSQbGYoHW5lwYVcz/mpIfMV4f5bULLvVPp9YWRWcxnkyarNJJ6VJY98wmawqzj/c1A8dStcbK3Wk/9QYS7O141dKrWMB7e6tL45bjXShHvz2p/1OzQzcTQmqzAuhXUpX5YebRjE9iu7ig9abJkubgcqZr6g6WAbMU/HoisR0yzAbhQc3l2vWKdDzM6yRRwxVk+yjEiTwR29;4:/SXOGFJ6gIVAwbRJXxGYYYeV1VDCoCK6FlP7PwDUbiy7KxicaC1O5DE9qJU74rK85zyACm7gUlJtZqFf2mNHpqrdXKcidSMTqDugkmbpyN4UCZ8ExcRB1rnGMJ0gbB/CLd8dcpKNC4cUvjglgMwRluiGEIG6haRouVJG7yhmbBT8j7rILPcHZc0U3QBISUJ/Oj2w+vjgchObIJOVIawoMmduVqS6WoSSweT7UsokjX/ADiT+leqpmKnrp1nuZQbFF1AHZIPODfEbnZPBZ3xvKZT/66ddVVezjdxm2X9hEw6ltf8shMK3ea6lhzkjMMeAaxV4V3BvQnNJoIQ0GY6OeQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(520078)(8121501046)(5005006)(3002001);SRVR:BY1PR03MB1484;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1484; X-Forefront-PRVS: 07063A0A30 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(199003)(13464003)(24454002)(189002)(377424004)(377454003)(62966003)(68736005)(33646002)(2950100001)(36756003)(5820100001)(5007970100001)(97736004)(46102003)(81156007)(19580405001)(19580395003)(92566002)(23676002)(40100003)(5001830100001)(77096005)(4001540100001)(77156002)(103116003)(5004730100002)(86362001)(105586002)(106356001)(64706001)(101416001)(47776003)(42186005)(76176999)(110136002)(4001450100002)(50986999)(189998001)(87976001)(5001860100001)(50226001)(50466002)(5001960100002)(122386002)(99106002)(3826002)(5001840100002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR03MB1484;H:[IPv6:2601:448:8100:f9f:d9a:aaef:168d:e441];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTFQUjAzTUIxNDg0OzIzOkxKN200cFZpMnVlRjBZN1pURmJySXZIZlYz?= =?utf-8?B?RXVRTFNVMUZ1V1dxYWhtT1M3VVNHR3ovZVdleTI2SjRGdzBZWWMrcmVVQkZj?= =?utf-8?B?SmRrNFBuNkhlY0dGWmdZZ0hTV1UzWXVQcDlKTU9tMXRCYjFFT1JtSENVTU8w?= =?utf-8?B?SGZicms5bU9ZdWpDb292UGNEcnpBaE5sQ0Q0VjRYdzBEQ0hqSWg1SGpES1FL?= =?utf-8?B?WThkMVN3Y21CaEJ0c2twT2pSZ2xUeWlsUDBFN3VHa2hKcHpTTGRRNUJOVGto?= =?utf-8?B?dzhya0kzUUdPSjlkUXBKNkI1Sjhybnc1NS9FTy9WQXJlalNuRUlTYXp3bFgy?= =?utf-8?B?SWdYa003ZGE3NWU1TzRIL0xjL1JKUUZQaVlIZ1R0RXRyN3J6TW5XaWVhTlhO?= =?utf-8?B?Zno1WFVEU1BCVmg0eDNabTRHa01OMU9oWGZFL0hmM3IvWUZGRURRazc5M0c5?= =?utf-8?B?cVU4Y0pxU2NDQlhiWXJ6c3RCalJ1d1FwR1BqVUZ3bkNlL0ZXODhaTnFVaHRw?= =?utf-8?B?L2gyNC9SUmp1Y0p2LzZoMWYrTnNEWUM5TGprNVFSV3RyNzZtSCs2QTF6S3RK?= =?utf-8?B?cGlKdjBkVmtYQnhuSGJtRnlaQ0Q5SldxU1lLTTlnK0pJaFhnWS91QW5zTUtl?= =?utf-8?B?NFpPcGZqd0FCeThvb2JVdlRTMmk2aDZaVnAwWW95K3BENTZFTnFZNmFvcUVj?= =?utf-8?B?RHV5T0duVTJqSUtkd0FHU1ZlRDhzZm9od1VBZCtGOUt2a2NXYW1DK2dvSjh3?= =?utf-8?B?aGlLdW5UOVZCR0d3R2VDVUlOWktIaDNsekZlZkJaTnRSNTdnTUFsa2JzbXA3?= =?utf-8?B?a0pSSGNDV3JTZmhYcW9tN1BEUmtYc2RhLzd5d2xDOWxlQ1IrYWV6ZGE5YnJt?= =?utf-8?B?RmtndFcwQVBPbmRPVkFqcnR1dkp3ZlZYMDlJdSsxUkRGQkRjZFR0dWhzdFJK?= =?utf-8?B?MmVDb3pCMFNCb0NmOFF0OHZFOFdRWG5menNBb2gzRnBtYzVQc2ZVOXJRK3NP?= =?utf-8?B?a2RGeHF4NFNLT1lTRFkyckErakIxYmlWV0Zoby9HVVp1VU9GSkVBditSbGhr?= =?utf-8?B?OHdzR3A5NkNEOENFd1ZzcXBCR1RsaUlBdzRCTHJUekZ0SWRnVmZxUC96V3p0?= =?utf-8?B?UlRCUGZHeFBSZ2xNZG9xMlE4Q01hdmMwZjZHWXNQSUY1V3lzNURkTXExTW05?= =?utf-8?B?K2RjeTNsamRoREpFd3ppV3NTK2VwQm5HR25aUFdwZnExNE9QL3ZHT1VmblVi?= =?utf-8?B?YXo4VHlyM0JkVVdOWW9NQnlzMzE1SzNhQXdQcEFYdkdjOCs2VWwxMFVJRENY?= =?utf-8?B?V29RdHRIdi9VK1VHNkNnSm9KSjBJa0wwS0Rtbzl6eXlOVE5qdHpVNGlQV2NO?= =?utf-8?B?WXNtZE9SOXpKN0pmZk9yTTJSOCt4TEpHcGtZVFRWOWVxT0JNOUE1WUs5cTFB?= =?utf-8?B?UHBSb2lTaG4vYzVmZHlaU29BRW93c3FWYTIwRHhXK0xWNUd5bXRUc1dpMmlT?= =?utf-8?B?QzM0MS9HaklEemVKUWE5S212SldjazFIczFWeVhVRVNCUmMrajFpc2d1QTVM?= =?utf-8?B?S3pybjY1a3NReTdkUmxIc2lPaFRrbDZyaUtyRHJwLzZnNEtWRXRibWUvcFk2?= =?utf-8?B?eG1GdlJXMzVib0UrVHVDUEcyYnNjMGc0SlBmMG1vNndKSDlBZE5CbXFEaHhz?= =?utf-8?B?NGY0RXpiaUN0K0tBb3BEdit5eFFnQVVmS1JwN0lqWnUzRWtKU3F5dE1qRmFG?= =?utf-8?Q?2fl+LJ0gSquCUAE5hdu4iwiWP45p0U1qX5MQU=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1484;5:VM/Vy4LIdTMBtZyeci5hl/ZVMLY65glFxTeRa8rx470hgTwN6SuPhgBRJlQikNPauaNh1fEY8LHNCQWnUxZ7JrR3AdXwL6Trj+h+xvJPcENly8KsjUQbItCoyj6OtgXHMAffFUEHMHtJKageOjaw1A==;24:ECWl4nvAWvPby0ybqRnEcQ1IzJ+PTjZkqDGxcqO1T23SyrcnAYhA3TSrL9fEEZubmjsdxn8gHMEyxN4dL2kY+X1+OUBiA0h+Wn4ynX1LPAA=;20:HTnoffd5U1waPTrT1dFKdpUJTVOvlslwtUsd72apkhHVJjV8RvQQxF9MKWzue6V6QVFNwe6v/cgGfNqeuQGRqQ== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2015 20:01:09.3328 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1484 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-09-21 at 03:36 -0500, Aggrwal Poonam-B10812 wrote: > > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Sunday, September 20, 2015 5:45 AM > > To: Aggrwal Poonam-B10812 > > Cc: linuxppc-dev@lists.ozlabs.org; linux-kernel@vger.kernel.org; > > devicetree- > > discuss@lists.ozlabs.org > > Subject: Re: [PATCH 2/4] powerpc/device-tree: bindings for DSP > > cores/clusters for Freescale SOCs > > > > On Sat, 2015-09-19 at 23:46 +0530, Poonam Aggrwal wrote: > > > From: poonam aggrwal > > > > > > Device Tree Bindings for DSP CPU clusters and DSP CPUs for Freescale > > > PowerPC SOCs which have DSP CPUs in addition to PowerPC CPUs. > > > For example B4860 has 3 DSP clusters which have 2 SC3900 cores each. > > > > > > Signed-off-by: Poonam Aggrwal > > > --- > > > - based of: > > > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > > > branch master > > > > > > This patch was sent earlier and some comments were received. Some have > > > been taken care; others we can further discuss. Apologize for not > > > following up on them in time. > > > .../devicetree/bindings/powerpc/fsl/dsp-cpus.txt | 78 > > > ++++++++++++++++++++++ > > > 1 file changed, 78 insertions(+) > > > create mode 100644 > > Documentation/devicetree/bindings/powerpc/fsl/dsp- > > > cpus.txt > > > > > > diff --git > > > a/Documentation/devicetree/bindings/powerpc/fsl/dsp-cpus.txt > > > b/Documentation/devicetree/bindings/powerpc/fsl/dsp-cpus.txt > > > new file mode 100644 > > > index 0000000..6d901ef > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/powerpc/fsl/dsp-cpus.txt > > > @@ -0,0 +1,78 @@ > > > > > +========================================================= > > ========== > > > +Binding for DSP CPU clusters and DSP CPUs for Freescale SOCs which > > > +have DSP CPUs in addition to PowerPC cpus. > > > +Copyright 2013 Freescale Semiconductor Inc. > > > + > > > +Power Architecture CPUs in Freescale SOCs are represented in device > > > +trees > > > as > > > +per the definition in ePAPR. > > > + > > > +Required properties for DSP CPU cluster: > > > +- compatible : should be "fsl,sc3900-cluster". > > > +- reg : should contain the cluster index > > > + > > > +Required properties for DSP CPU: > > > +- compatible : should be "fsl,sc3900". > > > +- reg : should contain index of DSP CPU within the DSP clsuter. > > > +- next-level-cache : should point to the phandle of the next-level L2 > > > cache. > > > > Why is the dsp-clusters container only shown in the example, not the > > binding > > itself? > > I will try to add more description in the binding for cluster; And the > structure of dsp cluster (like sub node of DSP cluster is core, etc). > Did I get your feedback right? No, I was complaining that the example has a "dsp-clusters" container node and the binding itself doesn't mention it at all. -Scott