Re: [linux-sunxi] [PATCH 0/2] ASoC: Add support for the Allwinner A10 codec

[Priit Laes <plaes@plaes.org>]

On Sat, 2015-09-12 at 15:26 +0200, Maxime Ripard wrote:
> Hi everyone,
> 
> This patch set adds the support for what Allwinner calls the codec on
> their SoCs.
> 
> This codec is actually a combination of a codec and DAI, tied
> together
> in a single memory-mapped IP. It is completely standalone, and
> outputs
> directly the analog signal.
> 
> While it supports both playback and capture, the capture is not
> implemented in this patch, and will be posted eventually as a
> separate
> one.
> 
> This set, in order to be functional, has a dependency on the audio
> clocks patch set posted separately. However, it doesn't needs this to
> compile properly, so I guess it can be merged without really caring
> for the merging status of the clock patches.

It works on Gemei G9 tablet which has also extra chip that
automatically switches output over from internal speakers to headphones
when connector is inserted.

Now I noticed some weird things:

When I have all the switches as ON in alsamixer, and I start disabling
them, I get following weird results.

Left Mixer Left - LML
Right Mixer Left - LMR
Right Mixer Right - RMR

Very faint output:
LML - ON
RML - Mute
RMR - ON

Output works fully:
LML - Mute
RML - Mute
RMR - Mute

When I Mute Pre-Amplifier and fiddle any of LML, RML or RMR, the output
stays mute even after setting Pre-Amplifier Mute back on:

1. All switches on
2. Mute pre-amplifier
3. Mute RMR
4. Pre-Amilifier Mute Off
.. Music stays off
5. Toggle Pre-Amplifier twice - output turns on


And also following in dmesg:
sun4i-codec 1c22c00.codec: Codec <-> 1c22c00.codec mapping ok
sun4i-codec 1c22c00.codec: ASoC: no sink widget found for Headphone Jack
sun4i-codec 1c22c00.codec: ASoC: Failed to add route HP Left -> direct -> Headphone Jack
sun4i-codec 1c22c00.codec: ASoC: no sink widget found for Headphone Jack
sun4i-codec 1c22c00.codec: ASoC: Failed to add route HP Right -> direct -> Headphone Jack


With following patch to DTS:

+&codec {
+       routing = "Headphone Jack", "HP Left",
+                         "Headphone Jack", "HP Right";
+       status = "okay";
+};

> 
> Let me know what you think,
> Maxime
> 
> Emilio López (1):
>   ASoC: sunxi: add support for the on-chip codec on early Allwinner
> SoCs
> 
> Maxime Ripard (1):
>   Documentation: bindings: Add the Allwinner A10 codec bindings
> 
>  .../devicetree/bindings/sound/sun4i-codec.txt      |  33 +
>  sound/soc/Kconfig                                  |   1 +
>  sound/soc/Makefile                                 |   1 +
>  sound/soc/sunxi/Kconfig                            |  11 +
>  sound/soc/sunxi/Makefile                           |   2 +
>  sound/soc/sunxi/sun4i-codec.c                      | 720
> +++++++++++++++++++++
>  6 files changed, 767 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/sun4i-
> codec.txt
>  create mode 100644 sound/soc/sunxi/Kconfig
>  create mode 100644 sound/soc/sunxi/Makefile
>  create mode 100644 sound/soc/sunxi/sun4i-codec.c
> 
> -- 
> 2.5.1
>