From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933628AbbIVN2q (ORCPT ); Tue, 22 Sep 2015 09:28:46 -0400 Received: from s3.sipsolutions.net ([5.9.151.49]:52123 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933308AbbIVN2o (ORCPT ); Tue, 22 Sep 2015 09:28:44 -0400 Message-ID: <1442928492.2018.9.camel@sipsolutions.net> Subject: Re: [PATCH 4/4] sound/core/seq: make prioq_match return bool From: Johannes Berg To: Yaowei Bai Cc: perex@perex.cz, tiwai@suse.com, k.kozlowski@samsung.com, elfring@users.sourceforge.net, fabf@skynet.be, lars@metafoo.de, linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Date: Tue, 22 Sep 2015 15:28:12 +0200 In-Reply-To: <20150922132257.GB4221@bbox> References: <1442843834-4648-1-git-send-email-bywxiaobai@163.com> <1442843834-4648-4-git-send-email-bywxiaobai@163.com> <1442844660.1876.2.camel@sipsolutions.net> <20150922132257.GB4221@bbox> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-09-22 at 21:22 +0800, Yaowei Bai wrote: > On Mon, Sep 21, 2015 at 04:11:00PM +0200, Johannes Berg wrote: > > > > > -static inline int prioq_match(struct snd_seq_event_cell *cell, > > > +static inline bool prioq_match(struct snd_seq_event_cell *cell, > > > int client, int timestamp) > > > > I think you should fix up the indentation now. > > Sorry, I'm quite a new guy to linux kernel. I think you mean this > patch is not appropriate, right? > No, the change itself is fine, but you should fix the indentation there so it lines up properly after your change. johannes