From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751839AbbIVPYe (ORCPT <rfc822;w@1wt.eu>);
	Tue, 22 Sep 2015 11:24:34 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47538 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751262AbbIVPYc (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 22 Sep 2015 11:24:32 -0400
Message-ID: <1442935469.13084.36.camel@redhat.com>
Subject: Re: [PATCH v2 5/6] virtio-gpu: add basic prime support
From: Gerd Hoffmann <kraxel@redhat.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
        open list <linux-kernel@vger.kernel.org>,
        "open list:VIRTIO GPU DRIVER" <dri-devel@lists.freedesktop.org>,
        "open list:VIRTIO GPU DRIVER" 
	<virtualization@lists.linux-foundation.org>,
        Dave Airlie <airlied@redhat.com>
Date: Tue, 22 Sep 2015 17:24:29 +0200
In-Reply-To: <20150922094027.GF3383@phenom.ffwll.local>
References: <1442828417-6165-1-git-send-email-kraxel@redhat.com>
	 <1442828417-6165-6-git-send-email-kraxel@redhat.com>
	 <20150922094027.GF3383@phenom.ffwll.local>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > +int virtgpu_gem_prime_mmap(struct drm_gem_object *obj,
> > +		       struct vm_area_struct *area)
> > +{
> > +	WARN_ONCE(1, "not implemented");
> > +	return ENOSYS;
> 
> This can get called by userspace, so please don't WARN here. Also missing
> negate sign:
> 
> 	return -ENOSYS;

Hmm now checkpatch throws a warning at me:

<quote>
   WARNING: ENOSYS means 'invalid syscall nr' and nothing else
   #12: FILE: drivers/gpu/drm/virtio/virtgpu_prime.c:70:
   +       return -ENOSYS;
</quote>

I guess I should use something else then (here and elsewhere in the
file)?  Maybe -EINVAL?  Other suggestions?

thanks,
  Gerd