From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750892AbbIWEGY (ORCPT ); Wed, 23 Sep 2015 00:06:24 -0400 Received: from mail-bn1on0135.outbound.protection.outlook.com ([157.56.110.135]:45472 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750705AbbIWEGV (ORCPT ); Wed, 23 Sep 2015 00:06:21 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Message-ID: <1442981170.19102.322.camel@freescale.com> Subject: Re: [PATCH 04/17] powerpc: mpic: use IRQCHIP_SKIP_SET_WAKE instead of redundant mpic_irq_set_wake From: Scott Wood To: Sudeep Holla CC: , , "Thomas Gleixner" , "Rafael J. Wysocki" , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Hongtao Jia , Marc Zyngier , , Wang Dongsheng-B40534 Date: Tue, 22 Sep 2015 23:06:10 -0500 In-Reply-To: <1442850433-5903-5-git-send-email-sudeep.holla@arm.com> References: <1442850433-5903-1-git-send-email-sudeep.holla@arm.com> <1442850433-5903-5-git-send-email-sudeep.holla@arm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.0-fta1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [2601:448:8100:f9f:50e1:d489:16f6:5d07] X-ClientProxiedBy: BLUPR11CA0061.namprd11.prod.outlook.com (10.141.30.29) To BY1PR03MB1482.namprd03.prod.outlook.com (25.162.210.140) X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1482;2:ONufKUIZOah+9cVB1e3OsZZ0Kvsl3yO3Y0tpzYWLkMxfBw/g/Fc+gXxacrvtlLlWZuFdYrpsEGGtbSCPz/GzrmyNtx5vfh3NyPxNwfwKtnM4Q/SrOe/3b7U+1tlNj8b0k19xmi8LdB657cwzxC6CdDdgfgCOLUFzuXsPOkAZnb0=;3:Awifyih/b6GtWrXJ9AKCB4HtZSX0gKvzRk96wiilHAsvlXfNwIRTqfo5kxf+QQBrt6rXGhW+qj6eDm8dGhPHcebmqOmPGICnyOkH9gLI90pKJTKffbIyuQrljQys2IW8o5QRt1uy/8+yFTXGHSdXCw==;25:3v3SzIePTchyD1yYNMb7ci/HjjreCy7+cnP98cGQ4N0t4lNNKtSv1DKVQ+kZ8bN9Hgo4T2FM4M2j08bYgWuzqbY9d4SETictdORJjWPfuCgnjWngHsgV9Is2iDz60w6ZdZZ/7hS8Ekb0qssnujRr5DGbK8M7rX/3e0PJUJMz2lM6ENZbxWaQyiMspud0IeCp2MjevgXOIPMscu0DAl4vFiPPnKQx+YmuyNll3gTNKqKRJSETHz/6gnQ7Ql5hcD6o6aZ/F4VoduSoTG+YoNCjVw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1482; X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1482;20:wKhYqtVmMu6dHwV7/RlDT4+dFKWtIRiE6ZYcJiVHSr1sg85cjrtw/47eW5F1navH0XVTh1RDV23QXtUYyJERDJd7pZAcB6GUmVmTCBQKDapViyCXj2W4uZQ+y9k3eXj+i3loVIrtL/xa3xgMeqGr1j3IY5yTxWcYPXUydsey/SDnTrGhK4YZJcFgzrzbOgFatHhOwdGkQmGNYFTN4B2EYcRSttj0BmaZQKmGOnrQB7+lesJW61heQDS/4o2fHGokrzt6BBMR+gtxBqN2kl6x5p2FsJnOHnhcXni/kyktCEGRqshEMJ8CVqhQKVjeEFvn1B1DWxDsGD1EzOMYyPxM3v7ejhJWlibv2bUrlzysjFmUQSy8iho5tw2NtMQbvyPGct2StCPRKP8T3aT0rAsaapD+1U5M/jWMMI6g1PQgrrrOcUjDw/JRzGV4Eu+bnErpHaUMsCMjcKWyFqPYfboU0J82kKtDZNhcIO4FkCSKzJoi9aoXXVm8TPd+r0i0EuDb;4:lxg7rnEyWSvXfFDgJ7aNWYj16XTZKiUGGai8lcoS3DNbbAKiOFCpTCnjesl89/7E4GR0L212oReNO92MJvWhatDPJAnaczT5NEUp/V6Yks7mOwtiAL2Pb3ABcXaJCYN8R0mcojrw0WtmZf3b90wGo++yfpNPdXlWoYqQ4nu5N8K/hJeYBK/jgOKLz6nZi1EoMDEOwaqNpyM2jtv5QKJZduhJ2+ktDvbXinGxSKm8uapzFHSthd/QU0mDT/Icjc6HTSPLy9qfgSBadgvFXV0NlP2iyXOc5R8SaTLqliB+7v22GL6T+fzqGDZzxsZGKdJ1/G7n8pjg7/40xN3JMSysAs4BwfhGNwIC+vLrkL7R2TU= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(8121501046)(5005006)(3002001);SRVR:BY1PR03MB1482;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1482; X-Forefront-PRVS: 07083FF734 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(199003)(189002)(24454002)(377424004)(46102003)(86362001)(76176999)(189998001)(19580405001)(105586002)(110136002)(47776003)(23676002)(5001960100002)(5007970100001)(50466002)(42186005)(106356001)(103116003)(64706001)(5004730100002)(50986999)(50226001)(19580395003)(107886002)(101416001)(87976001)(77156002)(2950100001)(122386002)(81156007)(68736005)(36756003)(92566002)(97736004)(62966003)(5001830100001)(4001540100001)(40100003)(5820100001)(77096005)(33646002)(5001860100001)(99106002)(3826002)(5001840100002)(4001430100001);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR03MB1482;H:[IPv6:2601:448:8100:f9f:50e1:d489:16f6:5d07];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTFQUjAzTUIxNDgyOzIzOjA2dmt6cFdhYk5KTkl1U1VyaHI0U3BlcS9O?= =?utf-8?B?REgrdE0yblYrTnpRQnN2Q1NLc2pQQkRRbE5nRzdIcU9MZWJiMmZQMEMvTzE3?= =?utf-8?B?R3ErZHRzVXpIbGRSQzNtWkx4aERzNkR6a3ZqaGNHYVAxYnpjU2JGYmlRNldH?= =?utf-8?B?WTNIWlpGbXJmeGYzT1A2cFZXQ000Y3ByU3NNYWJXOFdCTmpBSlFSZ29lR3hC?= =?utf-8?B?ZVFrUFh6UG50VW1CMUZOTEt1d1FOVnBGMmQrS0tiTHNUa2NnSHh0c0NVVTkv?= =?utf-8?B?bmlpQ3VyaUVRVnc0bkU2VW5Ta0FjdHdKUWFLMWVjZlZoT1NKQ0lQdlhyUWk0?= =?utf-8?B?bXdVZUIyTWtRM2k4SThFMFpUTHV3ZzY1aVprcVNNZ3pNRURuSHZxell0YWU5?= =?utf-8?B?TS9oUHZWdmFabHoydDlIZGNPV3hCc3c2ME04S1A3UzNhRlRUVUNoWEtVTG45?= =?utf-8?B?Tk5VRDVEbkIrS0JJU2IyaUkxclpHTlhPN3dUTm15Y3hSY2crZWFWUXlXNU14?= =?utf-8?B?dkZHRFdxYkFSU0lYNWNLOWlPT0IxaWFnOGZPVzRZdEtUa0EveHFWZ0lYUnkv?= =?utf-8?B?MjArMk1MSk5uZ3ZrTU5BeDJDSjhOOXlKYTZsT3FGRitDaVZTamRlT2NBNUtT?= =?utf-8?B?T0dDUVpqcU5WYWNRKy9zQ09jakw4ZUNVMk5BK3c0M2ZxTE13c2sxNVRHbUlk?= =?utf-8?B?Y01tdk1DUWwrUWlCZ1RrN0poUWtjN0drSXE0MmVzUUdXRTM1TjVLd01Id3ha?= =?utf-8?B?eTRKS2NYUkFsd2IzZVBkVU9qU3lLNW8zaU5YSGxoT2xUWDMyZkNocVQwNXJD?= =?utf-8?B?VmdGREZhcGdVR01GS2FSREJENHNYY2NPbkliR2xQSzFLZnppN2tYQXl3UFFQ?= =?utf-8?B?MUJGY0Y2WEN1RXJqaWl5SXdNbCsvb215RDFrdmI4SnBtNnhWQVFmdVp4aXRo?= =?utf-8?B?STBBenBWRStWb0pRU2VWaXVMZDFOSFpEeGxhUjU0V3NkU2dVYU84emdLaEo3?= =?utf-8?B?YzlOdVMxU2x4cUprT0RRejNjbm5PODBNbG4zVHV5VFR6VEtKNVcwY2k4ditw?= =?utf-8?B?QlI0M3JLL3BXMlg2TFVnK0NkUWNnOEFOYnpVdU9JT2RKSHp4QnlsY2dzWkhI?= =?utf-8?B?WTlHQVdYRnM3dFB6SHptT3RjblBkTC9IbHgwUU9HVjNvSVJ1bW9tY2U5VzFE?= =?utf-8?B?R09lK3JJUndROU83SGxTMENXRm04MFFYdjlsYUFtV005YStKS3I4bURudDYr?= =?utf-8?B?ODBQMlVJMzFpQ1lQUHIyOVZBSnlqU29nOWx3STYrS1lSV1RTU3QrS1REK3BD?= =?utf-8?B?elpRaHk5Z2Vvc0VFL21WV0FITUI1QUMxaXI4SHBKbmZjNHd1bWxiN1RZbnZX?= =?utf-8?B?dzhuS3pHYmlGL2VDelZBMVFXbDJ3TmovTU9lenh4RE9RV0Q0YW8rOE8vdlp3?= =?utf-8?B?ZGJVcjM1MForTGU4UC9KODBoUE5GTDAxd0FXRFN6RUQ3bFNXZHlzUmVYdTVN?= =?utf-8?B?Z2ZPSngyVlBIWGh4bVNuc0l4cFdkTVMvY1I4anJJUXUyQ1BmNUpsRkw0RW5w?= =?utf-8?B?RzZtcXZQWERQUVFVMjBmaDdLSC9hNnJ4ZHZOWDBOVnhUalJiYWhFQlpDRXJ0?= =?utf-8?B?aU5aNkVRdjF2ZGdGNTVia0xxYVhCeS9GT0JsV25YTUZISFdGdCtFdlJMSlU5?= =?utf-8?B?c0gwYnQ5RDVMbjNpVWU1b0lpQVNqWElZTEZXdFRWcGMxU1NBSW9OeUJya1M0?= =?utf-8?B?dFIyWVI4T2NRREhSaERwUT09?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1482;5:0nCKcOFIa7HmxW0xDdun057DTEXl8yBGeFeR+lmifsJcvJgZCOwJDT7MGTVSwaMs1v5kfiABNgHpQvcUAzmM5rg/BYccD3l/hQwlgAPScesFnZ0CK1ZSbhuUhQzADoLVqECgpz7x0v4BkmIhLttYbQ==;24:vuqb/WT9l/kW3bKG2yIA7D06VBeVP3F/kV3NLmMeUYzqAFLxTVcEnFBhEqH1yarGiCMb0zLhf7VdDBZZLU5DDe8rY8KcGxET+XHNwr1esPE=;20:dtMIe6RGv0qdd05jV0NhJMi69GPNyIfdV+MGCtJ2U5D/l6E1OKcdrPu0vfKFQEHd9pk4kh2P9XHHYgXZ6O1UrQ== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2015 04:06:17.7314 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1482 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-09-21 at 16:47 +0100, Sudeep Holla wrote: > mpic_irq_set_wake return -ENXIO for non FSL MPIC and sets IRQF_NO_SUSPEND > flag for FSL ones. enable_irq_wake already returns -ENXIO if irq_set_wak > is not implemented. Also there's no need to set the IRQF_NO_SUSPEND flag > as it doesn't guarantee wakeup for that interrupt. > > This patch removes the redundant mpic_irq_set_wake and sets the > IRQCHIP_SKIP_SET_WAKE for only FSL MPIC. > > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Michael Ellerman > Cc: Scott Wood > Cc: Hongtao Jia > Cc: Marc Zyngier > Cc: linuxppc-dev@lists.ozlabs.org > Signed-off-by: Sudeep Holla > --- > arch/powerpc/sysdev/mpic.c | 23 ++++------------------- > 1 file changed, 4 insertions(+), 19 deletions(-) Acked-by: Scott Wood -Scott