* [PATCH] Staging: rtl8712: rtl871x_mp.h: Coding style warnings fix for block comment
@ 2015-09-23 20:24 Punit Vara
2015-09-24 9:00 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: Punit Vara @ 2015-09-23 20:24 UTC (permalink / raw)
To: Larry.Finger
Cc: florian.c.schilhabel, gregkh, devel, linux-kernel, Punit Vara
This is a patch to the rtl871x_mp.h that fixes up following warnings
reported by checkpatch.pl :
-Block comments use a trailing */ on a separate line
Signed-off-by: Punit Vara <punitvara@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mp.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mp.h b/drivers/staging/rtl8712/rtl871x_mp.h
index 75893f2..20a4273 100644
--- a/drivers/staging/rtl8712/rtl871x_mp.h
+++ b/drivers/staging/rtl8712/rtl871x_mp.h
@@ -108,7 +108,8 @@ struct mp_priv {
unsigned char network_macaddr[6];
/*Testing Flag*/
u32 mode;/*0 for normal type packet,
- * 1 for loopback packet (16bytes TXCMD)*/
+ * 1 for loopback packet (16bytes TXCMD)
+ */
sint prev_fw_state;
u8 *pallocated_mp_xmitframe_buf;
u8 *pmp_xmtframe_buf;
--
2.5.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Staging: rtl8712: rtl871x_mp.h: Coding style warnings fix for block comment
2015-09-23 20:24 [PATCH] Staging: rtl8712: rtl871x_mp.h: Coding style warnings fix for block comment Punit Vara
@ 2015-09-24 9:00 ` Dan Carpenter
2015-09-24 10:27 ` Sudip Mukherjee
0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2015-09-24 9:00 UTC (permalink / raw)
To: Punit Vara
Cc: Larry.Finger, devel, florian.c.schilhabel, linux-kernel, gregkh
On Thu, Sep 24, 2015 at 01:54:22AM +0530, Punit Vara wrote:
> This is a patch to the rtl871x_mp.h that fixes up following warnings
> reported by checkpatch.pl :
>
> -Block comments use a trailing */ on a separate line
>
> Signed-off-by: Punit Vara <punitvara@gmail.com>
> ---
> drivers/staging/rtl8712/rtl871x_mp.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_mp.h b/drivers/staging/rtl8712/rtl871x_mp.h
> index 75893f2..20a4273 100644
> --- a/drivers/staging/rtl8712/rtl871x_mp.h
> +++ b/drivers/staging/rtl8712/rtl871x_mp.h
> @@ -108,7 +108,8 @@ struct mp_priv {
> unsigned char network_macaddr[6];
> /*Testing Flag*/
> u32 mode;/*0 for normal type packet,
This first line is missing some spaces so the whole comment needs to be
redone.
u32 mode; /* 0 for normal type packet,
* 1 for loopback packet (16bytes TXCMD)
*/
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Staging: rtl8712: rtl871x_mp.h: Coding style warnings fix for block comment
2015-09-24 9:00 ` Dan Carpenter
@ 2015-09-24 10:27 ` Sudip Mukherjee
2015-09-24 11:22 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: Sudip Mukherjee @ 2015-09-24 10:27 UTC (permalink / raw)
To: Dan Carpenter
Cc: Punit Vara, devel, florian.c.schilhabel, gregkh, linux-kernel,
Larry.Finger
On Thu, Sep 24, 2015 at 12:00:01PM +0300, Dan Carpenter wrote:
> On Thu, Sep 24, 2015 at 01:54:22AM +0530, Punit Vara wrote:
> > This is a patch to the rtl871x_mp.h that fixes up following warnings
> > reported by checkpatch.pl :
> >
> > -Block comments use a trailing */ on a separate line
> >
> > Signed-off-by: Punit Vara <punitvara@gmail.com>
> > ---
> > drivers/staging/rtl8712/rtl871x_mp.h | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8712/rtl871x_mp.h b/drivers/staging/rtl8712/rtl871x_mp.h
> > index 75893f2..20a4273 100644
> > --- a/drivers/staging/rtl8712/rtl871x_mp.h
> > +++ b/drivers/staging/rtl8712/rtl871x_mp.h
> > @@ -108,7 +108,8 @@ struct mp_priv {
> > unsigned char network_macaddr[6];
> > /*Testing Flag*/
> > u32 mode;/*0 for normal type packet,
>
> This first line is missing some spaces so the whole comment needs to be
> redone.
>
> u32 mode; /* 0 for normal type packet,
> * 1 for loopback packet (16bytes TXCMD)
> */
If he is modifying the first line then shouldn't it be:
u32 mode; /*
* 0 for normal type packet,
* 1 for loopback packet (16bytes TXCMD)
*/
regards
sudip
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Staging: rtl8712: rtl871x_mp.h: Coding style warnings fix for block comment
2015-09-24 10:27 ` Sudip Mukherjee
@ 2015-09-24 11:22 ` Dan Carpenter
2015-09-24 16:57 ` punit vara
0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2015-09-24 11:22 UTC (permalink / raw)
To: Sudip Mukherjee
Cc: Punit Vara, devel, florian.c.schilhabel, gregkh, linux-kernel,
Larry.Finger
On Thu, Sep 24, 2015 at 03:57:22PM +0530, Sudip Mukherjee wrote:
> On Thu, Sep 24, 2015 at 12:00:01PM +0300, Dan Carpenter wrote:
> > On Thu, Sep 24, 2015 at 01:54:22AM +0530, Punit Vara wrote:
> > > This is a patch to the rtl871x_mp.h that fixes up following warnings
> > > reported by checkpatch.pl :
> > >
> > > -Block comments use a trailing */ on a separate line
> > >
> > > Signed-off-by: Punit Vara <punitvara@gmail.com>
> > > ---
> > > drivers/staging/rtl8712/rtl871x_mp.h | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/staging/rtl8712/rtl871x_mp.h b/drivers/staging/rtl8712/rtl871x_mp.h
> > > index 75893f2..20a4273 100644
> > > --- a/drivers/staging/rtl8712/rtl871x_mp.h
> > > +++ b/drivers/staging/rtl8712/rtl871x_mp.h
> > > @@ -108,7 +108,8 @@ struct mp_priv {
> > > unsigned char network_macaddr[6];
> > > /*Testing Flag*/
> > > u32 mode;/*0 for normal type packet,
> >
> > This first line is missing some spaces so the whole comment needs to be
> > redone.
> >
> > u32 mode; /* 0 for normal type packet,
> > * 1 for loopback packet (16bytes TXCMD)
> > */
> If he is modifying the first line then shouldn't it be:
> u32 mode; /*
> * 0 for normal type packet,
> * 1 for loopback packet (16bytes TXCMD)
> */
>
Networking code doesn't use the empty first line.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Staging: rtl8712: rtl871x_mp.h: Coding style warnings fix for block comment
2015-09-24 11:22 ` Dan Carpenter
@ 2015-09-24 16:57 ` punit vara
0 siblings, 0 replies; 5+ messages in thread
From: punit vara @ 2015-09-24 16:57 UTC (permalink / raw)
To: Dan Carpenter
Cc: Sudip Mukherjee, devel, Flo Schil, Greg KH, linux-kernel,
Larry.Finger
On Thu, Sep 24, 2015 at 4:52 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Thu, Sep 24, 2015 at 03:57:22PM +0530, Sudip Mukherjee wrote:
>> On Thu, Sep 24, 2015 at 12:00:01PM +0300, Dan Carpenter wrote:
>> > On Thu, Sep 24, 2015 at 01:54:22AM +0530, Punit Vara wrote:
>> > > This is a patch to the rtl871x_mp.h that fixes up following warnings
>> > > reported by checkpatch.pl :
>> > >
>> > > -Block comments use a trailing */ on a separate line
>> > >
>> > > Signed-off-by: Punit Vara <punitvara@gmail.com>
>> > > ---
>> > > drivers/staging/rtl8712/rtl871x_mp.h | 3 ++-
>> > > 1 file changed, 2 insertions(+), 1 deletion(-)
>> > >
>> > > diff --git a/drivers/staging/rtl8712/rtl871x_mp.h b/drivers/staging/rtl8712/rtl871x_mp.h
>> > > index 75893f2..20a4273 100644
>> > > --- a/drivers/staging/rtl8712/rtl871x_mp.h
>> > > +++ b/drivers/staging/rtl8712/rtl871x_mp.h
>> > > @@ -108,7 +108,8 @@ struct mp_priv {
>> > > unsigned char network_macaddr[6];
>> > > /*Testing Flag*/
>> > > u32 mode;/*0 for normal type packet,
>> >
>> > This first line is missing some spaces so the whole comment needs to be
>> > redone.
>> >
>> > u32 mode; /* 0 for normal type packet,
>> > * 1 for loopback packet (16bytes TXCMD)
>> > */
>> If he is modifying the first line then shouldn't it be:
>> u32 mode; /*
>> * 0 for normal type packet,
>> * 1 for loopback packet (16bytes TXCMD)
>> */
>>
>
> Networking code doesn't use the empty first line.
>
> regards,
> dan carpenter
>
Yes I did that mistake in 2-3 files but after that I have got I was
doing mistake . Then I did not repeat the mistake. I Am waiting for
Greg's response whether again I have to send all patches in series So
I will definitely resend after fixing it.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-09-24 16:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-23 20:24 [PATCH] Staging: rtl8712: rtl871x_mp.h: Coding style warnings fix for block comment Punit Vara
2015-09-24 9:00 ` Dan Carpenter
2015-09-24 10:27 ` Sudip Mukherjee
2015-09-24 11:22 ` Dan Carpenter
2015-09-24 16:57 ` punit vara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox