From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756725AbbIXOBo (ORCPT ); Thu, 24 Sep 2015 10:01:44 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:50422 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755865AbbIXOBM (ORCPT ); Thu, 24 Sep 2015 10:01:12 -0400 X-AuditID: cbfec7f5-f794b6d000001495-b8-560402259874 From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Tejun Heo , linux-ide@vger.kernel.org Subject: [PATCH 03/19] libata: samsung_cf: fix handling platform_get_irq result Date: Thu, 24 Sep 2015 16:00:11 +0200 Message-id: <1443103227-25612-4-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1443103227-25612-1-git-send-email-a.hajda@samsung.com> References: <1443103227-25612-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmplluLIzCtJLcpLzFFi42I5/e/4NV1VJpYwgw+PRC1urTvHarFxxnpW i2M7HjFZXN41h81i7ZG77Ba/lh9ldGDz2LSqk82jb8sqRo/Pm+QCmKO4bFJSczLLUov07RK4 Mv5O28ZcsJ+rYsO9ZewNjBc5uhg5OSQETCQ273nPCGGLSVy4t56ti5GLQ0hgKaPEtQW/mCCc JiaJPw1LWUCq2AQ0Jf5uvskGYosIKEhs7n3GClLELHCMUWLerydgCWEBf4lnf+aC2SwCqhJ/ H4A0c3DwCjhLPHzvArFNTuLkscmsIDangIvE26mbmEBsIaCSE0dmsU1g5F3AyLCKUTS1NLmg OCk910ivODG3uDQvXS85P3cTIyRwvu5gXHrM6hCjAAejEg/vTB3mMCHWxLLiytxDjBIczEoi vBzvgUK8KYmVValF+fFFpTmpxYcYpTlYlMR5Z+56HyIkkJ5YkpqdmlqQWgSTZeLglGpgtOHS LjhQWrrUN/fb2hufjA8ZuX71vXLxbThP1YSdv744aE3dWO/OeWvJ3f7cvmvuIf8yW46e3b7n Ycze49ZTi/YzeqZJ7VzoNXUtm/vu+ouT+p2DAsQ/zDzlpPxms+WBDEPXONO0wMrbh2Kku1q7 btptMtV4x/ijYH7RvBiWxpiNzRPXpgo0KLEUZyQaajEXFScCAF+X3fIYAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function can return negative value. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 Signed-off-by: Andrzej Hajda --- Hi, To avoid problems with too many mail recipients I have sent whole patchset only to LKML. Anyway patches have no dependencies. Regards Andrzej --- drivers/ata/pata_samsung_cf.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/ata/pata_samsung_cf.c b/drivers/ata/pata_samsung_cf.c index cbb5a47..e028763 100644 --- a/drivers/ata/pata_samsung_cf.c +++ b/drivers/ata/pata_samsung_cf.c @@ -510,8 +510,6 @@ static int __init pata_s3c_probe(struct platform_device *pdev) return -ENOMEM; } - info->irq = platform_get_irq(pdev, 0); - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); info->ide_addr = devm_ioremap_resource(dev, res); @@ -551,9 +549,10 @@ static int __init pata_s3c_probe(struct platform_device *pdev) info->cpu_type = cpu_type; + ret = platform_get_irq(pdev, 0); + info->irq = ret > 0 ? ret : 0; if (info->irq <= 0) { ap->flags |= ATA_FLAG_PIO_POLLING; - info->irq = 0; ata_port_desc(ap, "no IRQ, using PIO polling\n"); } -- 1.9.1