From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756860AbbIXOBq (ORCPT ); Thu, 24 Sep 2015 10:01:46 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:8833 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755871AbbIXOBM (ORCPT ); Thu, 24 Sep 2015 10:01:12 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-57-56040226e92a From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Laurent Pinchart , Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: [PATCH 04/19] v4l: omap3isp: fix handling platform_get_irq result Date: Thu, 24 Sep 2015 16:00:12 +0200 Message-id: <1443103227-25612-5-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1443103227-25612-1-git-send-email-a.hajda@samsung.com> References: <1443103227-25612-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupnluLIzCtJLcpLzFFi42I5/e/4NV01JpYwgwXvFCxurTvHarFxxnpW i86JS9gtLu+aw2bRs2Erq8XaI3fZLVY/q3Bg95jdMZPVY0v/XXaPvi2rGD0+b5ILYInisklJ zcksSy3St0vgyvj1cSNrwUnOih1zP7I0MH5m72Lk5JAQMJG41fCGCcIWk7hwbz1bFyMXh5DA UkaJ67M+MEM4TUwSV+7dZQGpYhPQlPi7+SYbiC0ioCCxufcZK0gRs8A0JomzF/sYQRLCAl4S B3Z3gY1lEVCV+LVzBVicV8BZYuG2e4wQ6+QkTh6bzApicwq4SLydugmsXgio5sSRWWwTGHkX MDKsYhRNLU0uKE5KzzXUK07MLS7NS9dLzs/dxAgJpi87GBcfszrEKMDBqMTD66DFHCbEmlhW XJl7iFGCg1lJhJfjPVCINyWxsiq1KD++qDQntfgQozQHi5I479xd70OEBNITS1KzU1MLUotg skwcnFINjMs7NgZr/do696BddnquA4+18b1uP1fWphfPs4+W/po4d3l7wdaS+MS7a3T2J8T7 KrNf6b6nFf3WPv2ZZXV21xONg5Hhsw5GW5su2STXtsmZ90RnpOqeyc7TuO8q1HXuuaXGrvzf 3i4iZUdAZHq1uyF/IOuMxZzscg3Sfo5eEz+elThZqHFDiaU4I9FQi7moOBEAYv8euyICAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function can return negative value. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 Signed-off-by: Andrzej Hajda --- Hi, To avoid problems with too many mail recipients I have sent whole patchset only to LKML. Anyway patches have no dependencies. Regards Andrzej --- drivers/media/platform/omap3isp/isp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c index 56e683b..df9d2c2 100644 --- a/drivers/media/platform/omap3isp/isp.c +++ b/drivers/media/platform/omap3isp/isp.c @@ -2442,12 +2442,13 @@ static int isp_probe(struct platform_device *pdev) } /* Interrupt */ - isp->irq_num = platform_get_irq(pdev, 0); - if (isp->irq_num <= 0) { + ret = platform_get_irq(pdev, 0); + if (ret <= 0) { dev_err(isp->dev, "No IRQ resource\n"); ret = -ENODEV; goto error_iommu; } + isp->irq_num = ret; if (devm_request_irq(isp->dev, isp->irq_num, isp_isr, IRQF_SHARED, "OMAP3 ISP", isp)) { -- 1.9.1