From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932429AbbIXOBv (ORCPT ); Thu, 24 Sep 2015 10:01:51 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:50429 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755931AbbIXOBQ (ORCPT ); Thu, 24 Sep 2015 10:01:16 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-6f-5604022afae4 From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , "David S. Miller" , dingtianhong , netdev@vger.kernel.org Subject: [PATCH 07/19] net: hisilicon: fix handling platform_get_irq result Date: Thu, 24 Sep 2015 16:00:15 +0200 Message-id: <1443103227-25612-8-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1443103227-25612-1-git-send-email-a.hajda@samsung.com> References: <1443103227-25612-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupnluLIzCtJLcpLzFFi42I5/e/4NV0tJpYwgw03VS1urTvHarFxxnpW iznnW1gs3hzdwWZxedccNou1R+6yWxxbIObA7rFl5U0mj5Yjb1k9+rasYvT4vEkugCWKyyYl NSezLLVI3y6BK2Ph1nPsBQs5Kn5s38HewPifrYuRk0NCwESie9dZKFtM4sK99UA2F4eQwFJG ieO/NrBAOE1MEov2vGcHqWIT0JT4u/kmWIeIgILE5t5nrCBFzAK/GSX2PHzICpIQFvCW2HL2 MBOIzSKgKtG05SsjiM0r4CxxZPpvFoh1chInj00Gq+cUcJF4O3UTWL0QUM2JI7PYJjDyLmBk WMUomlqaXFCclJ5rqFecmFtcmpeul5yfu4kREkxfdjAuPmZ1iFGAg1GJh9dBizlMiDWxrLgy 9xCjBAezkggvx3ugEG9KYmVValF+fFFpTmrxIUZpDhYlcd65u96HCAmkJ5akZqemFqQWwWSZ ODilGhhrjphcaA+w0z3yuyKsNfV9gNAiuTe5OowKh1NNp3PInT8Y+2RSUp+Lgqje5Rl8Ytvu 6RUy+zdePmzbvc73oti2t42dkooKYrPmiU7MX9xp0BA2V6A8gvmPt+8SM53Ot9K6mVryfYFL Ghgl/i9U7FjwRv/8qehvZzpLd1aKvdsdtzKI/53leiWW4oxEQy3mouJEAIO3bxsiAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function can return negative value. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 Signed-off-by: Andrzej Hajda --- Hi, To avoid problems with too many mail recipients I have sent whole patchset only to LKML. Anyway patches have no dependencies. Regards Andrzej --- drivers/net/ethernet/hisilicon/hip04_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hip04_eth.c b/drivers/net/ethernet/hisilicon/hip04_eth.c index cc2d8b4..253f8ed 100644 --- a/drivers/net/ethernet/hisilicon/hip04_eth.c +++ b/drivers/net/ethernet/hisilicon/hip04_eth.c @@ -816,7 +816,7 @@ static int hip04_mac_probe(struct platform_device *pdev) struct net_device *ndev; struct hip04_priv *priv; struct resource *res; - unsigned int irq; + int irq; int ret; ndev = alloc_etherdev(sizeof(struct hip04_priv)); -- 1.9.1