From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756964AbbIXOBz (ORCPT ); Thu, 24 Sep 2015 10:01:55 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:8839 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755963AbbIXOBR (ORCPT ); Thu, 24 Sep 2015 10:01:17 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-74-5604022bada0 From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org Subject: [PATCH 08/19] clk: st: fix handling result of of_property_count_strings Date: Thu, 24 Sep 2015 16:00:16 +0200 Message-id: <1443103227-25612-9-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1443103227-25612-1-git-send-email-a.hajda@samsung.com> References: <1443103227-25612-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjluLIzCtJLcpLzFFi42I5/e/4NV1tJpYwgz+dBha31p1jtdg4Yz2r xceee6wWl3fNYbNYe+Quu8XFU64WP850sziwe7y/0crucbmvl8mjb8sqRo/Pm+QCWKK4bFJS czLLUov07RK4MprPPWIteMVd8WByeQPjHc4uRk4OCQETiUm3+tghbDGJC/fWs3UxcnEICSxl lHi27CcrhNPEJHH84AZWkCo2AU2Jv5tvsoHYIgIKEpt7n4EVMQv8Z5T4MHErE0hCWCBA4uDJ 7WA2i4CqxNtrS5lBbF4BZ4lj9w6wQqyTkzh5bDKYzSngIvF26iaweiGgmhNHZrFNYORdwMiw ilE0tTS5oDgpPddQrzgxt7g0L10vOT93EyMklL7sYFx8zOoQowAHoxIPr4MWc5gQa2JZcWXu IUYJDmYlEV6O90Ah3pTEyqrUovz4otKc1OJDjNIcLErivHN3vQ8REkhPLEnNTk0tSC2CyTJx cEo1MAruPOXwsim67c7JB0dqF9TPktz/NsA7+N3jabEVafqt93e2RvocY4o7+Oi2cE2q1Po1 +RttI91e//HO2Fh+L+dqtuexOXUXq+L6F89n89ZsDVX5fZBNZ+I8/qs7A4L1Sr03XkyoiNOd PrV/97Sq/Q48OZGXcjO33e80XzDHOm3qsq9rJhzonq7EUpyRaKjFXFScCABjFMe+IQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function can return negative value. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 Signed-off-by: Andrzej Hajda --- Hi, To avoid problems with too many mail recipients I have sent whole patchset only to LKML. Anyway patches have no dependencies. Regards Andrzej --- drivers/clk/st/clk-flexgen.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/clk/st/clk-flexgen.c b/drivers/clk/st/clk-flexgen.c index bd355ee..24d9959 100644 --- a/drivers/clk/st/clk-flexgen.c +++ b/drivers/clk/st/clk-flexgen.c @@ -268,6 +268,7 @@ static void __init st_of_flexgen_setup(struct device_node *np) int num_parents, i; spinlock_t *rlock = NULL; unsigned long flex_flags = 0; + int ret; pnode = of_get_parent(np); if (!pnode) @@ -285,13 +286,13 @@ static void __init st_of_flexgen_setup(struct device_node *np) if (!clk_data) goto err; - clk_data->clk_num = of_property_count_strings(np , - "clock-output-names"); - if (clk_data->clk_num <= 0) { + ret = of_property_count_strings(np, "clock-output-names"); + if (ret <= 0) { pr_err("%s: Failed to get number of output clocks (%d)", __func__, clk_data->clk_num); goto err; } + clk_data->clk_num = ret; clk_data->clks = kcalloc(clk_data->clk_num, sizeof(struct clk *), GFP_KERNEL); -- 1.9.1