From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932894AbbIYRml (ORCPT ); Fri, 25 Sep 2015 13:42:41 -0400 Received: from s3.sipsolutions.net ([5.9.151.49]:47704 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932675AbbIYRmi (ORCPT ); Fri, 25 Sep 2015 13:42:38 -0400 Message-ID: <1443202945.2161.8.camel@sipsolutions.net> Subject: Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' From: Johannes Berg To: Viresh Kumar , Greg Kroah-Hartman Cc: linaro-kernel@lists.linaro.org, QCA ath9k Development , Intel Linux Wireless , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, linux-bluetooth@vger.kernel.org, iommu@lists.linux-foundation.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, linux-edac@vger.kernel.org, linux-mm@kvack.org, alsa-devel@alsa-project.org Date: Fri, 25 Sep 2015 19:42:25 +0200 In-Reply-To: (sfid-20150925_184230_610012_AD3DF607) References: (sfid-20150925_184230_610012_AD3DF607) Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-09-25 at 09:41 -0700, Viresh Kumar wrote: > Signed-off-by: Viresh Kumar > --- > V3->V4: > - Create a local variable instead of changing type of global_lock > (Rafael) Err, surely that wasn't what Rafael meant, since it's clearly impossible to use a pointer to the stack, assign to it once, and the expect anything to wkr at all ... johannes