Re: [PATCH v3 9/9] arch: sh: migor: Use new renesas-ceu camera driver

Laurent Pinchart
2018-01-04T20:10:09Z

Hi Jacopo,

Thank you for the patch.

On Thursday, 4 January 2018 18:03:17 EET Jacopo Mondi wrote:
> Migo-R platform uses sh_mobile_ceu camera driver, which is now being
> replaced by a proper V4L2 camera driver named 'renesas-ceu'.
>
> Move Migo-R platform to use the v4l2 renesas-ceu camera driver
> interface and get rid of soc_camera defined components used to register
> sensor drivers and of platform specific enable/disable routines.
>
> Register clock source and GPIOs for sensor drivers, so they can use
> clock and gpio APIs.
>
> Also, memory for CEU video buffers is now reserved with membocks APIs,
> and need to be declared as dma_coherent during machine initialization to
> remove that architecture specific part from CEU driver.
>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> arch/sh/boards/mach-migor/setup.c | 225 ++++++++++++++----------------
> arch/sh/kernel/cpu/sh4a/clock-sh7722.c | 2 +-
> 2 files changed, 101 insertions(+), 126 deletions(-)

--
Regards,

Laurent Pinchart