From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756767AbbI1IqO (ORCPT ); Mon, 28 Sep 2015 04:46:14 -0400 Received: from mga01.intel.com ([192.55.52.88]:23477 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753045AbbI1IqM (ORCPT ); Mon, 28 Sep 2015 04:46:12 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,602,1437462000"; d="scan'208";a="778812771" Message-ID: <1443429967.8361.227.camel@linux.intel.com> Subject: Re: [PATCH 1/1] dmaengine: dw: resolve recursion lock when audio playback From: Andy Shevchenko To: yitian , "'Andy Shevchenko'" , "'Viresh Kumar'" Cc: "'Viresh Kumar'" , "'Vinod Koul'" , "'Dan Williams'" , "'dmaengine'" , "'Linux Kernel Mailing List'" Date: Mon, 28 Sep 2015 11:46:07 +0300 In-Reply-To: <035501d0f9be$8ef49340$acddb9c0$@tangramtek.com> References: <025c01d0f858$4d19c790$e74d56b0$@tangramtek.com> <035501d0f9be$8ef49340$acddb9c0$@tangramtek.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-09-28 at 15:23 +0800, yitian wrote: > > > > From: Andy Shevchenko [mailto:andy.shevchenko@gmail.com] > > Sent: Monday, September 28, 2015 3:06 PM > > To: Viresh Kumar > > Cc: yitian ; Viresh Kumar > > ; Andy Shevchenko > > ; Vinod Koul < > > vinod.koul@intel.com>; > > Dan Williams ; dmaengine > > ; Linux Kernel Mailing List > > > > Subject: Re: [PATCH 1/1] dmaengine: dw: resolve recursion > > > I am not sure if this is a sane way of doing that, and we were > > > scanning > > > the descriptors for some valid reason.. > > > > Actually one of the patches in a pile sitting in my private repo is > > also including similar change. In my case the reason is to support > > cyclic transfers natively. > > > > Yes, i am using DW DMAC to support cyclic transfer. > Currently it is very easy to get recursion lock crash, but > after this patch everything is fine on my device. What is an actual hardware you are running kernel on? -- Andy Shevchenko Intel Finland Oy