From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756290AbbJANfQ (ORCPT <rfc822;w@1wt.eu>);
	Thu, 1 Oct 2015 09:35:16 -0400
Received: from mga03.intel.com ([134.134.136.65]:44743 "EHLO mga03.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752961AbbJANfO (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 1 Oct 2015 09:35:14 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.17,617,1437462000"; 
   d="scan'208";a="817170557"
Message-ID: <1443706510.16309.52.camel@gmail.com>
Subject: Re: [PATCH] fs/ubifs: remove unnecessary new_valid_dev check
From: Artem Bityutskiy <dedekind1@gmail.com>
Reply-To: dedekind1@gmail.com
To: Richard Weinberger <richard.weinberger@gmail.com>,
        Yaowei Bai <bywxiaobai@163.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>, Adrian Hunter <adrian.hunter@intel.com>,
        "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Date: Thu, 01 Oct 2015 16:35:10 +0300
In-Reply-To: <CAFLxGvwdvW8k07ENLQP7PyXrznVf0UKsnZMUCGahULqsDrgfGQ@mail.gmail.com>
References: <1443446807-4838-1-git-send-email-bywxiaobai@163.com>
	 <1443535053-4673-1-git-send-email-bywxiaobai@163.com>
	 <CAFLxGvwdvW8k07ENLQP7PyXrznVf0UKsnZMUCGahULqsDrgfGQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.16.5 (3.16.5-1.fc22) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2015-09-30 at 10:11 +0200, Richard Weinberger wrote:
> >  {
> > -       if (new_valid_dev(rdev)) {
> > -               dev->new = cpu_to_le32(new_encode_dev(rdev));
> > -               return sizeof(dev->new);
> > -       } else {
> > -               dev->huge = cpu_to_le64(huge_encode_dev(rdev));
> > -               return sizeof(dev->huge);
> > -       }
> > +       dev->new = cpu_to_le32(new_encode_dev(rdev));
> > +       return sizeof(dev->new);
> >  }
> 
> Reviewed-by: Richard Weinberger <richard@nod.at>

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>