From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933241AbbJANqA (ORCPT <rfc822;w@1wt.eu>);
	Thu, 1 Oct 2015 09:46:00 -0400
Received: from mailgw01.mediatek.com ([210.61.82.183]:58946 "EHLO
	mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org
	with ESMTP id S933013AbbJANp4 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 1 Oct 2015 09:45:56 -0400
X-Listener-Flag: 11101
Message-ID: <1443707149.22188.1.camel@mtksdaap41>
Subject: Re: [PATCH v4 3/5] ARM: mediatek: add smp bringup code
From: Yingjoe Chen <yingjoe.chen@mediatek.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
CC: Matthias Brugger <matthias.bgg@gmail.com>, <devicetree@vger.kernel.org>,
        Arnd Bergmann <arnd@arndb.de>, Stephen Boyd <sboyd@codeaurora.org>,
        <linux-kernel@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
        <linux-mediatek@lists.infradead.org>,
        Sascha Hauer <kernel@pengutronix.de>, Olof Johansson <olof@lixom.net>,
        <srv_heupstream@mediatek.com>, <linux-arm-kernel@lists.infradead.org>
Date: Thu, 1 Oct 2015 21:45:49 +0800
In-Reply-To: <20150926093835.GA20255@n2100.arm.linux.org.uk>
References: <1443109140-5406-1-git-send-email-yingjoe.chen@mediatek.com>
	 <1443109140-5406-4-git-send-email-yingjoe.chen@mediatek.com>
	 <20150926093835.GA20255@n2100.arm.linux.org.uk>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.2.3-0ubuntu6 
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MTK: N
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 2015-09-26 at 10:38 +0100, Russell King - ARM Linux wrote:
> On Thu, Sep 24, 2015 at 11:38:58PM +0800, Yingjoe Chen wrote:
> > +struct mtk_smp_boot_info {
> > +	unsigned long smp_base;
> ...
> > +static const struct mtk_smp_boot_info mtk_mt8135_tz_boot = {
> > +	0x80002000, 0x3fc,
> ...
> > +static const struct mtk_smp_boot_info mtk_mt6589_boot = {
> > +	0x10002000, 0x34,
> ...
> > +	if (trustzone) {
> > +		/* smp_base(trustzone-bootinfo) is reserved by device tree */
> > +		mtk_smp_base = phys_to_virt(mtk_smp_info->smp_base);
> 
> I can't say whether this is correct or not, as we've got rid of most of
> the information that would allow me to make that decision.
> 
> The address passed to phys_to_virt() _must_ be one which is mapped by
> the kernel as lowmem.  I've no idea if the above would fall into that
> category though.
> 

Currently only mt8127/mt8135 trustzone firmware use this reserve
location. The reserved memory is before kernel code, so it will
definitely in lowmem.

Joe.C