From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752262AbbJBMV6 (ORCPT ); Fri, 2 Oct 2015 08:21:58 -0400 Received: from mga09.intel.com ([134.134.136.24]:55229 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750730AbbJBMV5 (ORCPT ); Fri, 2 Oct 2015 08:21:57 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,623,1437462000"; d="scan'208";a="817872309" Message-ID: <1443788513.8361.333.camel@linux.intel.com> Subject: Re: [PATCH 1/1] mfd: intel-lpss: fix build error when !CONFIG_PM_SLEEP From: Andy Shevchenko To: Lee Jones Cc: linux-kernel@vger.kernel.org Date: Fri, 02 Oct 2015 15:21:53 +0300 In-Reply-To: <20151001144539.GA3214@x1> References: <1443704817-70402-1-git-send-email-andriy.shevchenko@linux.intel.com> <20151001144539.GA3214@x1> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-10-01 at 15:45 +0100, Lee Jones wrote: > On Thu, 01 Oct 2015, Andy Shevchenko wrote: > > > Jim Davis reported the compilation error with a random > > configuration which > > apparently has CONFIG_PM=y and CONFIG_PM_SLEEP=n. With that > > conditions we have > > missed definition of INTEL_LPSS_SLEEP_PM_OPS macro. Add it here. > > > > Reported-by: Jim Davis > > Signed-off-by: Andy Shevchenko > > --- > > drivers/mfd/intel-lpss.h | 2 ++ > > 1 file changed, 2 insertions(+) > > Why are you using this email address? In fact it *had* the proper address [1] and after you confused me [2]. [1] http://www.spinics.net/lists/kernel/msg2073973.html [2] http://www.spinics.net/lists/linux-fsdevel/msg90269.html > > Please use ./get_maintainer.pl properly. > > > diff --git a/drivers/mfd/intel-lpss.h b/drivers/mfd/intel-lpss.h > > index f28cb28a..2c7f8d7 100644 > > --- a/drivers/mfd/intel-lpss.h > > +++ b/drivers/mfd/intel-lpss.h > > @@ -42,6 +42,8 @@ int intel_lpss_resume(struct device *dev); > > .thaw = intel_lpss_resume, \ > > .poweroff = intel_lpss_suspend, \ > > .restore = intel_lpss_resume, > > +#else > > +#define INTEL_LPSS_SLEEP_PM_OPS > > #endif > > > > #define INTEL_LPSS_RUNTIME_PM_OPS \ -- Andy Shevchenko Intel Finland Oy