public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: <lee.jones@linaro.org>
Cc: <patches@opensource.wolfsonmicro.com>,
	<linux-kernel@vger.kernel.org>, <rf@opensource.wolfsonmicro.com>,
	<sameo@linux.intel.com>
Subject: [PATCH v2 3/6] mfd: arizona: Downgrade type mismatch messages to dev_warn
Date: Fri, 2 Oct 2015 13:29:12 +0100	[thread overview]
Message-ID: <1443788955-7523-3-git-send-email-ckeepax@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1443788955-7523-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>

From: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>

If the declared codec type doesn't match the detected type
we issue a log message but carry on registering the device,
so a dev_warn() is appropriate rather than a dev_err()

Signed-off-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
Acked-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
 drivers/mfd/arizona-core.c |   16 ++++++++--------
 1 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
index e32d0d3..c3f88e5 100644
--- a/drivers/mfd/arizona-core.c
+++ b/drivers/mfd/arizona-core.c
@@ -1130,8 +1130,8 @@ int arizona_dev_init(struct arizona *arizona)
 	case 0x5102:
 		type_name = "WM5102";
 		if (arizona->type != WM5102) {
-			dev_err(arizona->dev, "WM5102 registered as %d\n",
-				arizona->type);
+			dev_warn(arizona->dev, "WM5102 registered as %d\n",
+				 arizona->type);
 			arizona->type = WM5102;
 		}
 		apply_patch = wm5102_patch;
@@ -1149,8 +1149,8 @@ int arizona_dev_init(struct arizona *arizona)
 			break;
 		default:
 			type_name = "WM5110";
-			dev_err(arizona->dev, "WM5110 registered as %d\n",
-				arizona->type);
+			dev_warn(arizona->dev, "WM5110 registered as %d\n",
+				 arizona->type);
 			arizona->type = WM5110;
 			break;
 		}
@@ -1161,8 +1161,8 @@ int arizona_dev_init(struct arizona *arizona)
 	case 0x8997:
 		type_name = "WM8997";
 		if (arizona->type != WM8997) {
-			dev_err(arizona->dev, "WM8997 registered as %d\n",
-				arizona->type);
+			dev_warn(arizona->dev, "WM8997 registered as %d\n",
+				 arizona->type);
 			arizona->type = WM8997;
 		}
 		apply_patch = wm8997_patch;
@@ -1181,8 +1181,8 @@ int arizona_dev_init(struct arizona *arizona)
 
 		default:
 			type_name = "WM8998";
-			dev_err(arizona->dev, "WM8998 registered as %d\n",
-				arizona->type);
+			dev_warn(arizona->dev, "WM8998 registered as %d\n",
+				 arizona->type);
 			arizona->type = WM8998;
 		}
 
-- 
1.7.2.5


  parent reply	other threads:[~2015-10-02 12:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-02 12:29 [PATCH v2 1/6] mfd: arizona: factor out DCVDD isolation control Charles Keepax
2015-10-02 12:29 ` [PATCH v2 2/6] mfd: arizona: factor out checking of jack detection state Charles Keepax
2015-10-13  9:24   ` Lee Jones
2015-10-02 12:29 ` Charles Keepax [this message]
2015-10-13  9:24   ` [PATCH v2 3/6] mfd: arizona: Downgrade type mismatch messages to dev_warn Lee Jones
2015-10-02 12:29 ` [PATCH v2 4/6] mfd: arizona: Simplify adding subdevices Charles Keepax
2015-10-13  9:24   ` Lee Jones
2015-10-02 12:29 ` [PATCH v2 5/6] mfd: arizona: Remove use of codec build config #ifdefs Charles Keepax
2015-10-13  9:23   ` Lee Jones
2015-10-13  9:25   ` Lee Jones
2015-10-02 12:29 ` [PATCH v2 6/6] mfd: arizona: use correct type ID for device tree config Charles Keepax
2015-10-13  9:25   ` Lee Jones
2015-10-13  9:23 ` [PATCH v2 1/6] mfd: arizona: factor out DCVDD isolation control Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443788955-7523-3-git-send-email-ckeepax@opensource.wolfsonmicro.com \
    --to=ckeepax@opensource.wolfsonmicro.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=rf@opensource.wolfsonmicro.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox