From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751299AbbJBVU0 (ORCPT ); Fri, 2 Oct 2015 17:20:26 -0400 Received: from gate.crashing.org ([63.228.1.57]:57356 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750991AbbJBVUZ (ORCPT ); Fri, 2 Oct 2015 17:20:25 -0400 Message-ID: <1443819066.27295.19.camel@kernel.crashing.org> Subject: Re: [PATCH 0/5 v2] Fix NVMe driver support on Power with 32-bit DMA From: Benjamin Herrenschmidt To: Nishanth Aravamudan , Matthew Wilcox Cc: Keith Busch , Paul Mackerras , Michael Ellerman , Alexey Kardashevskiy , David Gibson , Christoph Hellwig , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Date: Sat, 03 Oct 2015 06:51:06 +1000 In-Reply-To: <20151002200953.GB40695@linux.vnet.ibm.com> References: <20151002171606.GA41011@linux.vnet.ibm.com> <20151002200953.GB40695@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 (3.16.5-3.fc22) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-10-02 at 13:09 -0700, Nishanth Aravamudan wrote: > 1) add a generic dma_get_page_shift implementation that just returns > PAGE_SHIFT So you chose to return the granularity of the iommu to the driver rather than providing a way for the driver to request a specific alignment for DMA mappings. Any specific reason ? Cheers, Ben.