From: Chandra S Gorentla <csgorentla@gmail.com>
To: gregkh@linuxfoundation.org
Cc: dan.carpenter@oracle.com, johnny.kim@atmel.com,
rachel.kim@atmel.com, chris.park@atmel.com,
linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org,
Chandra S Gorentla <csgorentla@gmail.com>
Subject: [PATCH 1/2] drivers: staging: wilc1000: Move spin lock to the start of critical section
Date: Sat, 3 Oct 2015 14:57:29 +0530 [thread overview]
Message-ID: <1443864450-18167-1-git-send-email-csgorentla@gmail.com> (raw)
The spin_lock_irqsave is moved to just beginning of critical section.
This change moves a couple of return statements out of the lock.
Signed-off-by: Chandra S Gorentla <csgorentla@gmail.com>
---
drivers/staging/wilc1000/wilc_msgqueue.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b/drivers/staging/wilc1000/wilc_msgqueue.c
index d5ebd6d..284a3f5 100644
--- a/drivers/staging/wilc1000/wilc_msgqueue.c
+++ b/drivers/staging/wilc1000/wilc_msgqueue.c
@@ -72,8 +72,6 @@ int wilc_mq_send(WILC_MsgQueueHandle *pHandle,
goto ERRORHANDLER;
}
- spin_lock_irqsave(&pHandle->strCriticalSection, flags);
-
/* construct a new message */
pstrMessage = kmalloc(sizeof(Message), GFP_ATOMIC);
if (!pstrMessage)
@@ -87,6 +85,8 @@ int wilc_mq_send(WILC_MsgQueueHandle *pHandle,
}
memcpy(pstrMessage->pvBuffer, pvSendBuffer, u32SendBufferSize);
+ spin_lock_irqsave(&pHandle->strCriticalSection, flags);
+
/* add it to the message queue */
if (!pHandle->pstrMessageList) {
pHandle->pstrMessageList = pstrMessage;
--
2.1.4
next reply other threads:[~2015-10-03 9:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-03 9:27 Chandra S Gorentla [this message]
2015-10-03 9:27 ` [PATCH 2/2] drivers: staging: wilc1000: Call kfree only for error cases Chandra S Gorentla
2015-10-04 8:44 ` Greg KH
2015-10-04 9:16 ` Dan Carpenter
2015-10-04 10:10 ` Greg KH
2015-10-04 10:28 ` Chandra Gorentla
2015-10-05 3:23 ` Tony Cho
2015-10-04 8:43 ` [PATCH 1/2] drivers: staging: wilc1000: Move spin lock to the start of critical section Greg KH
2015-10-04 10:07 ` Chandra Gorentla
2015-10-04 10:19 ` Greg KH
2015-10-05 3:23 ` Tony Cho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443864450-18167-1-git-send-email-csgorentla@gmail.com \
--to=csgorentla@gmail.com \
--cc=chris.park@atmel.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johnny.kim@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rachel.kim@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).