From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752308AbbJCMi6 (ORCPT ); Sat, 3 Oct 2015 08:38:58 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:36284 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752068AbbJCMi5 (ORCPT ); Sat, 3 Oct 2015 08:38:57 -0400 Message-ID: <1443875934.4186.27.camel@gmail.com> Subject: Re: [PATCH v4 12/26] ARM: pxa: magician: Rename charger cable detection EGPIOs From: Philipp Zabel To: Petr Cvek , robert.jarzmik@free.fr, daniel@zonque.org, haojian.zhuang@gmail.com, linux@arm.linux.org.uk Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Sat, 03 Oct 2015 14:38:54 +0200 In-Reply-To: <5609B1F8.8070104@tul.cz> References: <5609B1F8.8070104@tul.cz> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Montag, den 28.09.2015, 23:32 +0200 schrieb Petr Cvek: > This patch renames EGPIOs, which are used for the charging cable > presence > and type detection. Old names did not correspond with an observed > functionality (on board_id 0x3a). The behavior is not: > > - AC charger > - USB charger > - Cable detection > > , but: > > - AC/USB type > - Cable detection1 > - Cable detection2 > > This patch fixes a possible typo in the bit offset for the cable > detection > EGPIO declaration, too. > > Signed-off-by: Petr Cvek Just to be sure, please tell me what are the values of those three EGPIOs while a) wall plug charger plugged in b) usb cable connected to a host plugged in c) no cable plugged in It could well be there are differences between our boards. regards Philipp