From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752586AbbJCMln (ORCPT ); Sat, 3 Oct 2015 08:41:43 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:36877 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752143AbbJCMlm (ORCPT ); Sat, 3 Oct 2015 08:41:42 -0400 Message-ID: <1443876099.4186.28.camel@gmail.com> Subject: Re: [PATCH v4 14/26] ARM: pxa: magician: Fix platform data for both PXA27x I2C controllers From: Philipp Zabel To: Petr Cvek , robert.jarzmik@free.fr, daniel@zonque.org, haojian.zhuang@gmail.com, linux@arm.linux.org.uk Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Sat, 03 Oct 2015 14:41:39 +0200 In-Reply-To: <5609B243.9020306@tul.cz> References: <5609B243.9020306@tul.cz> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Montag, den 28.09.2015, 23:33 +0200 schrieb Petr Cvek: > This patch changes fast_mode settings for the normal and power I2C > controller on the HTC Magician machine. > > Connected device on the Power I2C: > - MAX1587A: working in the fast mode > > Connected devices on the Normal I2C: > - UDA1380: working in the fast mode > - OV9640: bus became stuck in the fast mode > > The OV9640 is not using a standard I2C protocol, but an SCCB variant. > Maybe > it is not fully compatible in the fast mode. Therefore fast mode for > normal > I2C is disabled. If you not using the OV9640 then you can enable the > fast > mode for the UDA1380. > > Signed-off-by: Petr Cvek > --- > arch/arm/mach-pxa/magician.c | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-pxa/magician.c b/arch/arm/mach > -pxa/magician.c > index 906df6d..86d395d 100644 > --- a/arch/arm/mach-pxa/magician.c > +++ b/arch/arm/mach-pxa/magician.c > @@ -818,7 +818,16 @@ static struct platform_device strataflash = { > */ > > static struct i2c_pxa_platform_data i2c_info = { > - .fast_mode = 1, > + /* FIXME both I2C devices should support fast mode */ Maybe add the info from the commit description here (it's OV9640 that doesn't support fast mode). Otherwise, Acked-by: Philipp Zabel regards Philipp