From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752238AbbJCMpb (ORCPT ); Sat, 3 Oct 2015 08:45:31 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:38479 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752061AbbJCMpa (ORCPT ); Sat, 3 Oct 2015 08:45:30 -0400 Message-ID: <1443876327.4186.32.camel@gmail.com> Subject: Re: [PATCH v4 17/26] ARM: pxa: magician: Fix wrongly enabled USB host ports From: Philipp Zabel To: Petr Cvek , robert.jarzmik@free.fr, daniel@zonque.org, haojian.zhuang@gmail.com, linux@arm.linux.org.uk Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Sat, 03 Oct 2015 14:45:27 +0200 In-Reply-To: <5609B33B.6070301@tul.cz> References: <5609B33B.6070301@tul.cz> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Montag, den 28.09.2015, 23:38 +0200 schrieb Petr Cvek: > USB host ports on the HTC Magician are wrongly enabled. Port 1 is for > bluetooth and port 2 is for OTG (mux in the charger connector). > > Signed-off-by: Petr Cvek > --- > arch/arm/mach-pxa/magician.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-pxa/magician.c b/arch/arm/mach > -pxa/magician.c > index 8e8b122..af8133a 100644 > --- a/arch/arm/mach-pxa/magician.c > +++ b/arch/arm/mach-pxa/magician.c > @@ -780,8 +780,10 @@ static struct pxamci_platform_data > magician_mci_info = { > > static struct pxaohci_platform_data magician_ohci_info = { > .port_mode = PMM_PERPORT_MODE, > - .flags = ENABLE_PORT1 | ENABLE_PORT3 | > POWER_CONTROL_LOW, > + /* port1: CSR Bluetooth, port2: OTG with UDC */ > + .flags = ENABLE_PORT1 | ENABLE_PORT2 | > POWER_CONTROL_LOW, > .power_budget = 0, > + .power_on_delay = 100, > }; I have only ever tested the CSR bluetooth chip, so this could be correct, or again something that is different between the magician variants. I don't know. regards Philipp