From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751709AbbJERwv (ORCPT ); Mon, 5 Oct 2015 13:52:51 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:46654 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750892AbbJERwu (ORCPT ); Mon, 5 Oct 2015 13:52:50 -0400 Message-ID: <1444067568.2238.25.camel@HansenPartnership.com> Subject: Re: [PATCH 0/5] Modify ida_* users to use ida_simple_* From: James Bottomley To: Tejun Heo Cc: Lee Duncan , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Hannes Reinecke , Johannes Thumshirn , Christoph Hellwig , Greg Kroah-Hartman , Matthew Wilcox , linux-nvme@lists.infradead.org, Joshua Morris , Philip Kelleher Date: Mon, 05 Oct 2015 10:52:48 -0700 In-Reply-To: <20151005174426.GB11164@htj.duckdns.org> References: <20151005174426.GB11164@htj.duckdns.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-10-05 at 13:44 -0400, Tejun Heo wrote: > On Thu, Oct 01, 2015 at 11:59:04AM -0700, Lee Duncan wrote: > > The ida index management routines are used in several > > driver modules to manage allocation and release of > > index values. Reviewing the way in which the > > ida routines were called, together with the small > > number of such clients, led to the belief that > > these users should all be able to share a simple > > built-in lock in the ida module by calling the > > ida_simple_*() functions instead of the non-simple > > versions. This means that ida does all the > > required locking so that clients don't have to > > manage that. > > The whole series looks good to me. Please feel free to add Since they're all independent, they can go via the correct trees without adverse consequences. It's probably me: 1/5; Jens 2-4/5; Greg 5/5 James