From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964800AbbJHPoL (ORCPT ); Thu, 8 Oct 2015 11:44:11 -0400 Received: from mga11.intel.com ([192.55.52.93]:6563 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934072AbbJHPoI (ORCPT ); Thu, 8 Oct 2015 11:44:08 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,655,1437462000"; d="scan'208";a="787718225" From: "Koul, Vinod" To: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "patrice.chotard@st.com" , "maxime.coquelin@st.com" , "srinivas.kandagatla@gmail.com" , "peter.griffin@linaro.org" CC: "dmaengine@vger.kernel.org" , "ludovic.barre@st.com" , "lee.jones@linaro.org" , "robh+dt@kernel.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH v2 3/9] dmaengine: st_fdma: Add STMicroelectronics FDMA driver header file Thread-Topic: [PATCH v2 3/9] dmaengine: st_fdma: Add STMicroelectronics FDMA driver header file Thread-Index: AQHQ7Jw3cgu7CTUlHEWqoPsQFKjvgJ5d5KOA Date: Thu, 8 Oct 2015 15:43:59 +0000 Message-ID: <1444118413.3579.46.camel@intel.com> References: <1441980871-24475-1-git-send-email-peter.griffin@linaro.org> <1441980871-24475-4-git-send-email-peter.griffin@linaro.org> In-Reply-To: <1441980871-24475-4-git-send-email-peter.griffin@linaro.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.4.63] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t98FiMjI031597 On Fri, 2015-09-11 at 15:14 +0100, Peter Griffin wrote: > +#define FDMA_ID_OFST 0x00000 > +#define FDMA_VER_OFST 0x00004 > > + > +#define FDMA_EN_OFST 0x00008 Why cant these be BIT() to maintain consistency? -- ~Vinod {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I