From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752356AbbJGWp2 (ORCPT ); Wed, 7 Oct 2015 18:45:28 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:49393 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751361AbbJGWp0 (ORCPT ); Wed, 7 Oct 2015 18:45:26 -0400 From: Arnaldo Carvalho de Melo To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, Jiri Olsa , David Ahern , Peter Zijlstra , Arnaldo Carvalho de Melo Subject: [PATCH 1/5] perf tools: Get rid of superfluos call to reset_dimensions Date: Wed, 7 Oct 2015 19:45:13 -0300 Message-Id: <1444257917-24527-2-git-send-email-acme@kernel.org> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1444257917-24527-1-git-send-email-acme@kernel.org> References: <1444257917-24527-1-git-send-email-acme@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jiri Olsa There's no need to call reset_dimensions within __setup_output_field function. It's already called in its caller setup_sorting right before perf_hpp__init, which will be changed in following patch to respect taken dimension. Signed-off-by: Jiri Olsa Acked-by: Namhyung Kim Cc: David Ahern Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1444134312-29136-2-git-send-email-jolsa@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/sort.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c index ee94b728fca4..8521e3c89b8d 100644 --- a/tools/perf/util/sort.c +++ b/tools/perf/util/sort.c @@ -1917,8 +1917,6 @@ static int __setup_output_field(void) if (field_order == NULL) return 0; - reset_dimensions(); - strp = str = strdup(field_order); if (str == NULL) { error("Not enough memory to setup output fields"); -- 2.1.0