From: "Hon Ching(Vicky) Lo" <honclo@linux.vnet.ibm.com>
To: tpmdd-devel@lists.sourceforge.net
Cc: Peter Huewe <PeterHuewe@gmx.de>,
Ashley Lai <ashley@ashleylai.com>,
Mimi Zohar <zohar@linux.vnet.ibm.com>,
Vicky Lo <honclo2014@gmail.com>,
linux-kernel@vger.kernel.org,
"Hon Ching(Vicky) Lo" <honclo@linux.vnet.ibm.com>
Subject: [PATCH] vTPM: fix memory allocation flag for rtce buffer at kernel boot
Date: Wed, 7 Oct 2015 20:11:51 -0400 [thread overview]
Message-ID: <1444263114-15081-1-git-send-email-honclo@linux.vnet.ibm.com> (raw)
At ibm vtpm initialzation, tpm_ibmvtpm_probe() registers its interrupt
handler, ibmvtpm_interrupt, which calls ibmvtpm_crq_process to allocate
memory for rtce buffer. The current code uses 'GFP_KERNEL' as the
type of kernel memory allocation, which resulted a warning at
kernel/lockdep.c. This patch uses 'GFP_ATOMIC' instead so that the
allocation is high-priority and does not sleep.
Signed-off-by: Hon Ching(Vicky) Lo <honclo@linux.vnet.ibm.com>
---
drivers/char/tpm/tpm_ibmvtpm.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
index 27ebf95..3e6a226 100644
--- a/drivers/char/tpm/tpm_ibmvtpm.c
+++ b/drivers/char/tpm/tpm_ibmvtpm.c
@@ -491,7 +491,7 @@ static void ibmvtpm_crq_process(struct ibmvtpm_crq *crq,
}
ibmvtpm->rtce_size = be16_to_cpu(crq->len);
ibmvtpm->rtce_buf = kmalloc(ibmvtpm->rtce_size,
- GFP_KERNEL);
+ GFP_ATOMIC);
if (!ibmvtpm->rtce_buf) {
dev_err(ibmvtpm->dev, "Failed to allocate memory for rtce buffer\n");
return;
--
1.7.1
next reply other threads:[~2015-10-08 0:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-08 0:11 Hon Ching(Vicky) Lo [this message]
2015-10-08 0:11 ` [PATCH v2 1/3] vTPM: fix searching for the right vTPM node in device tree Hon Ching(Vicky) Lo
2015-10-08 0:11 ` [PATCH v2 2/3] vTPM: reformat event log to be byte-aligned Hon Ching(Vicky) Lo
2015-10-13 18:43 ` Ashley Lai
2015-10-13 21:27 ` Hon Ching(Vicky) Lo
2015-10-14 21:15 ` Ashley Lai
2015-10-14 21:20 ` Ashley Lai
2015-10-08 0:11 ` [PATCH v2 3/3] vTPM: get the buffer allocated for event log instead of the actual log Hon Ching(Vicky) Lo
-- strict thread matches above, loose matches on Subject: below --
2015-10-08 0:10 [PATCH] vTPM: fix memory allocation flag for rtce buffer at kernel boot Hon Ching(Vicky) Lo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444263114-15081-1-git-send-email-honclo@linux.vnet.ibm.com \
--to=honclo@linux.vnet.ibm.com \
--cc=PeterHuewe@gmx.de \
--cc=ashley@ashleylai.com \
--cc=honclo2014@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).